Bug 970411 - Review Request: mingw-libid3tag - ID3 tag manipulation library [NEEDINFO]
Review Request: mingw-libid3tag - ID3 tag manipulation library
Status: CLOSED DUPLICATE of bug 1076456
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
unspecified Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Extras Quality Assurance
NotReady
:
Depends On:
Blocks: FE-DEADREVIEW
  Show dependency treegraph
 
Reported: 2013-06-03 21:31 EDT by Steve
Modified: 2014-03-14 08:46 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2014-03-14 07:34:53 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
amigadave: needinfo? (ulatekh)


Attachments (Terms of Use)

  None (edit)
Description Steve 2013-06-03 21:31:25 EDT
Spec URL: https://www.box.com/s/g19jin7x5ago4yng0416
SRPM URL: https://www.box.com/s/lftygl2h98pe67olj2qq
Description: libid3tag is a library for reading and (eventually) writing ID3 tags, both ID3v1 and the various versions of ID3v2.
This is the MinGW version of a package that Fedora already has in its repository.
Fedora Account System Username: ulatekh
Comment 1 David King 2014-02-07 06:04:09 EST
Hi, I cannot give a formal review because I am not a sponsor, but I can give some informal comments:

* BuildRoot is not required: https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
* %clean is not required: https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean
* "BuildRequires:  mingw32-gcc-c++" does not seem to be needed (as there are no C++ source files)
* "BuildRequires:  mingw??-binutils" is not required, as it is automatically pulled in via mingw??-gcc
* "Requires:       pkgconfig" is not required, as it is pulled in automatically
* "%defattr(-,root,root,-)" is not required: https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions
* "rm -rf %{buildroot}" in %install is not required
Comment 2 David King 2014-02-07 06:06:12 EST
I have made the changes which reflect my review comments (as I needed libid3tag for a MinGW version of EasyTAG), which you can find in one of my github repositories:

https://github.com/amigadave/easytag-dlls-specs/commit/51fa0002312afdd23206722d914d4dbaec4bb24f
Comment 3 David King 2014-03-07 06:33:18 EST
Hi, this review seems to be stalled, as you (Steve) have not responded to my comments for 1 month. Following https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews#Submitter_not_responding I will close this bug in a week if there is no further response.
Comment 4 David King 2014-03-14 07:34:53 EDT
Closing after a further week of inactivity as per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews#Submitter_not_responding
Comment 5 David King 2014-03-14 08:46:10 EDT

*** This bug has been marked as a duplicate of bug 1076456 ***

Note You need to log in before you can comment on or make changes to this bug.