RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 970516 - Monitor command acl_add can't insert before last list element
Summary: Monitor command acl_add can't insert before last list element
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: qemu-kvm
Version: 6.4
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Markus Armbruster
QA Contact: Virtualization Bugs
Markus Armbruster
URL:
Whiteboard:
Depends On:
Blocks: 990615
TreeView+ depends on / blocked
 
Reported: 2013-06-04 08:36 UTC by Markus Armbruster
Modified: 2013-11-21 06:58 UTC (History)
11 users (show)

Fixed In Version: qemu-kvm-0.12.1.2-2.390.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 990615 (view as bug list)
Environment:
Last Closed: 2013-11-21 06:58:50 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2013:1553 0 normal SHIPPED_LIVE Important: qemu-kvm security, bug fix, and enhancement update 2013-11-20 21:40:29 UTC

Description Markus Armbruster 2013-06-04 08:36:08 UTC 
Description of problem:
When you ask acl_add to insert a rule before the last rule in the
list, it appends to the list instead.

How reproducible:
Always

Steps to Reproduce:
1. qemu-kvm -nodefaults -S -vnc :0,acl,sasl -monitor stdio
2. Monitor commands:
    acl_show vnc.username
    acl_add vnc.username drei allow
    acl_show vnc.username
    acl_add vnc.username zwei allow 1
    acl_show vnc.username
    acl_add vnc.username eins allow 1
    acl_show vnc.username

Actual results:

(qemu) acl_show vnc.username
policy: deny
(qemu) acl_add vnc.username drei allow
acl: added rule at position 1
(qemu) acl_show vnc.username
policy: deny
1: allow drei
(qemu) acl_add vnc.username zwei allow 1
acl: added rule at position 2
(qemu) acl_show vnc.username
policy: deny
1: allow drei
2: allow zwei
(qemu) acl_add vnc.username eins allow 1
acl: added rule at position 1
(qemu) acl_show vnc.username
policy: deny
1: allow eins
2: allow drei
3: allow zwei

Expected results:
The second acl_add inserts at position 1, with final result
policy: deny
1: allow eins
2: allow zwei
3: allow drei

Additional info:
Upstream misbehaves the same.

Root cause is an off-by-one in qemu_acl_insert(): when index ==
acl->nentries, it appends instead of inserting before the last list
element.
Comment 2 Chao Yang 2013-06-05 03:12:58 UTC 
Providing qa_qck+
Comment 5 Markus Armbruster 2013-06-21 13:23:24 UTC 
Proposed upstream fix: http://lists.nongnu.org/archive/html/qemu-devel/2013-06/msg02921.html
Comment 8 Markus Armbruster 2013-06-26 15:46:24 UTC 
Upstream commit 4999f3a8a6009de05ba82e58e723277917f16254
Comment 13 mazhang 2013-09-09 05:19:12 UTC 
Reproduce this bug on qemu-kvm-0.12.1.2-2.376.el6.x86_64

[root@localhost qemu-kvm-376]# rpm -qa |grep qemu
gpxe-roms-qemu-0.9.7-6.10.el6.noarch
qemu-kvm-tools-0.12.1.2-2.376.el6.x86_64
qemu-kvm-0.12.1.2-2.376.el6.x86_64
qemu-kvm-debuginfo-0.12.1.2-2.376.el6.x86_64
qemu-img-0.12.1.2-2.376.el6.x86_64

Steps to Reproduce:
1. /usr/libexec/qemu-kvm -nodefaults -S -vnc :0,acl,sasl -monitor stdio
2. Monitor commands:
    acl_show vnc.username
    acl_add vnc.username drei allow
    acl_show vnc.username
    acl_add vnc.username zwei allow 1
    acl_show vnc.username
    acl_add vnc.username eins allow 1
    acl_show vnc.username

Actual results:
[root@localhost ~]# /usr/libexec/qemu-kvm -nodefaults -S -vnc :0,acl,sasl -monitor stdio
QEMU 0.12.1 monitor - type 'help' for more information
(qemu) acl_show vnc.username
policy: deny
(qemu) acl_add vnc.username drei allow
acl: added rule at position 1
(qemu) acl_show vnc.username
policy: deny
1: allow drei
(qemu) acl_add vnc.username zwei allow 1
acl: added rule at position 2
(qemu) acl_show vnc.username
policy: deny
1: allow drei
2: allow zwei
(qemu) acl_add vnc.username eins allow 1
acl: added rule at position 1
(qemu) acl_show vnc.username
policy: deny
1: allow eins
2: allow drei
3: allow zwei
(qemu) 

Expected results:
The second acl_add inserts at position 1, with final result
policy: deny
1: allow eins
2: allow zwei
3: allow drei
Comment 14 mazhang 2013-09-09 05:26:04 UTC 
Verify this bug on qemu-kvm-0.12.1.2-2.400.el6.x86_64 .

Steps to Reproduce:
1. /usr/libexec/qemu-kvm -nodefaults -S -vnc :0,acl,sasl -monitor stdio
2. Monitor commands:
    acl_show vnc.username
    acl_add vnc.username drei allow
    acl_show vnc.username
    acl_add vnc.username zwei allow 1
    acl_show vnc.username
    acl_add vnc.username eins allow 1
    acl_show vnc.username

Actual results:
[root@localhost ~]# /usr/libexec/qemu-kvm -nodefaults -S -vnc :0,acl,sasl -monitor stdio
QEMU 0.12.1 monitor - type 'help' for more information
(qemu) acl_show vnc.username
policy: deny
(qemu) acl_add vnc.username drei allow
acl: added rule at position 1
(qemu) acl_show vnc.username
policy: deny
1: allow drei
(qemu) acl_add vnc.username zwei allow 1
acl: added rule at position 1
(qemu) acl_show vnc.username
policy: deny
1: allow zwei
2: allow drei
(qemu) acl_add vnc.username eins allow 1
acl: added rule at position 1
(qemu) acl_show vnc.username
policy: deny
1: allow eins
2: allow zwei
3: allow drei
(qemu) 

So this bug has been fixed.
Comment 16 errata-xmlrpc 2013-11-21 06:58:50 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2013-1553.html
Note You need to log in before you can comment on or make changes to this bug.