Spec URL: http://goldmann.fedorapeople.org/package_review/jboss-websocket-1.0-api/1/jboss-websocket-1.0-api.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/jboss-websocket-1.0-api/1/jboss-websocket-1.0-api-1.0.0-0.1.Beta1.fc18.src.rpm Fedora Account System Username: goldmann Description: The JSR-356: Java WebSocket 1.0 API classes. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5464909
can you add additional alias? -a "javax.websocket:javax.websocket-api,javax.websocket:javax.websocket-client-api" the poject have home at https://java.net/projects/websocket-spec/ and jboss maintainer merged these in one jar https://svn.java.net/svn/websocket-spec~source-code-repository/tags/javax.websocket-all-1.0/api/client/pom.xml https://svn.java.net/svn/websocket-spec~source-code-repository/tags/javax.websocket-all-1.0/api/server/pom.xml regard
I wouldn't want to do it, since this websocket-api wasn't chosen as the default implementation of the API for Fedora (yet). If we'll decide so, I'll add it for sure.
BLOCKER: * Lincese-Tag in spec is wrong: CDDL should be GPLv2+ with exception as LICENSE says. Package Review ============== Legend: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in jboss- websocket-1.0-api-javadoc ---> false postive: docs should not requires "binary/compiled"-pkgs. [x]: Package complies to the Packaging Guidelines [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 33 files have unknown license. Detailed output of licensecheck in /home/bjoern.esser/fedora/review/970651-jboss- websocket-1.0-api/licensecheck.txt ---> LISENSE is GPLv2+ with exception [x]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 30720 bytes in 2 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Java: [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Fully versioned dependency in subpackages, if present. [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) [x]: Bundled jar/class files should be removed before build Maven: [x]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Pom files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [x]: Dist tag is present. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: jboss-websocket-1.0-api-1.0.0-0.1.Beta1.fc20.noarch.rpm jboss-websocket-1.0-api-javadoc-1.0.0-0.1.Beta1.fc20.noarch.rpm jboss-websocket-1.0-api.noarch: E: incorrect-fsf-address /usr/share/doc/jboss-websocket-1.0-api-1.0.0/LICENSE jboss-websocket-1.0-api-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados jboss-websocket-1.0-api-javadoc.noarch: E: incorrect-fsf-address /usr/share/doc/jboss-websocket-1.0-api-javadoc-1.0.0/LICENSE 2 packages and 0 specfiles checked; 2 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint jboss-websocket-1.0-api-javadoc jboss-websocket-1.0-api jboss-websocket-1.0-api-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados jboss-websocket-1.0-api-javadoc.noarch: E: incorrect-fsf-address /usr/share/doc/jboss-websocket-1.0-api-javadoc-1.0.0/LICENSE jboss-websocket-1.0-api.noarch: E: incorrect-fsf-address /usr/share/doc/jboss-websocket-1.0-api-1.0.0/LICENSE 2 packages and 0 specfiles checked; 2 errors, 1 warnings. # echo 'rpmlint-done:' ---> You should ask upstream to update LICENSE to recent GPLv2+ rev. Requires -------- jboss-websocket-1.0-api-javadoc (rpmlib, GLIBC filtered): jpackage-utils jboss-websocket-1.0-api (rpmlib, GLIBC filtered): jpackage-utils Provides -------- jboss-websocket-1.0-api-javadoc: jboss-websocket-1.0-api-javadoc jboss-websocket-1.0-api: jboss-websocket-1.0-api mvn(org.jboss.spec.javax.websocket:jboss-websocket-api_1.0_spec) osgi(org.jboss.spec.javax.websocket.jboss-websocket-api_1.0_spec) Source checksums ---------------- https://github.com/jboss/jboss-websocket-api_spec/archive/1.0.0.Beta1.tar.gz : CHECKSUM(SHA256) this package : 3395f32d2e8aeaafc2afa4b9f3ec00d4cc4dca6ab58f0d9b7b1cedf28c1a305d CHECKSUM(SHA256) upstream package : 3395f32d2e8aeaafc2afa4b9f3ec00d4cc4dca6ab58f0d9b7b1cedf28c1a305d Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 970651 ##### When you correct license-tag and upload the corrected spec and I'll grant review.
Hi Bjoern, Thank you for the review. Regarding the license tag - this is exactly the same things as in https://bugzilla.redhat.com/show_bug.cgi?id=970964#c2. The only issue here is that I missed the GPL license, so the tag should look like this: "CDDL or GPLv2 with exceptions". I'll fix this at the import time if you agree with me to do so.
You're welcome! Fix this in SCM, then. APPROVED!
Thanks! New Package SCM Request ======================= Package Name: jboss-websocket-1.0-api Short Description: JSR-356: Java WebSocket 1.0 API Owners: goldmann
Git done (by process-git-requests).