Bug 971881 - Shutting down Swift services trough initscripts doesn't add a newline
Summary: Shutting down Swift services trough initscripts doesn't add a newline
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: openstack-swift
Version: 3.0
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: beta
: 4.0
Assignee: Pete Zaitcev
QA Contact: Dafna Ron
URL:
Whiteboard:
Depends On: 927423
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-06-07 13:36 UTC by Martina Kollarova
Modified: 2016-04-26 18:04 UTC (History)
10 users (show)

Fixed In Version: openstack-swift-1.8.0-7.el6ost
Doc Type: Bug Fix
Doc Text:
Clone Of: 927423
Environment:
Last Closed: 2013-10-08 19:49:49 UTC
Target Upstream Version:
Embargoed:
abaron: internal-review+


Attachments (Terms of Use)
Proposed fix (538 bytes, patch)
2013-06-24 22:07 UTC, Pete Zaitcev
apevec: review+
abaron: review+
Details | Diff

Description Martina Kollarova 2013-06-07 13:36:40 UTC
+++ This bug was initially created as a clone of Bug #927423 +++

It would be nice if it was more explicit which command does a soft and which does a hard shutdown. Maybe add some note about it in the help message?

Also, I'm not getting a newline, so the output gets mangled up. This does not happen with the 'restart' command, for example.

[root@server ~]# service openstack-swift-proxy shutdown 
[root@server ~]# ack-swift-proxy:                       [  OK  ]

Comment 2 Pete Zaitcev 2013-06-24 22:07:30 UTC
Created attachment 764792 [details]
Proposed fix

I'm not sure about the help message. It is virtually unknown for
init scripts to include anything in the help message other than
a list of commands.

The missing newline was my bug, fix is attached for review.

Comment 8 Ayal Baron 2013-07-23 14:12:17 UTC
I reviewed the patch, it adds an empty line at the end of the output to fix output (code review only, not verified).
It does not address the hard vs. soft shutdown issue though.
For that if you want, please file an 'improvement' bug.

Comment 9 Martina Kollarova 2013-07-23 18:36:53 UTC
So, what exactly is the [needinfo] question?

Comment 11 Pete Zaitcev 2013-10-08 19:49:49 UTC
This is fixed in RHOS 3 1.8.0-7, verified in RHOS 4 1.9.1-1.


Note You need to log in before you can comment on or make changes to this bug.