Bug 971888 - Review Request: pacrunner - Proxy configuration dæmon
Review Request: pacrunner - Proxy configuration dæmon
Status: CLOSED CURRENTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Richard Hughes
Fedora Extras Quality Assurance
:
: 701470 (view as bug list)
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-07 09:45 EDT by David Woodhouse
Modified: 2014-07-02 04:46 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2014-07-02 04:46:54 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
rhughes: fedora‑review+
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description David Woodhouse 2013-06-07 09:45:26 EDT
Spec URL: http://david.woodhou.se/pacrunner.spec
SRPM URL: http://david.woodhou.se/pacrunner-0.6-1.fc19.src.rpm
Description: 
PacRunner provides a dæmon for processing proxy configuration
and providing information to clients over D-Bus.
Fedora Account System Username: dwmw2
Comment 1 David Woodhouse 2013-06-07 09:52:52 EDT
===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "GPL (v2 or later)", "GPL (v2)", "Unknown or generated". 3 files have
     unknown license. Detailed output of licensecheck in
     /home/dwmw2/redhat/SPECS/pacrunner/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Large documentation must go in a -doc subpackage.
     Note: Documentation size is 30720 bytes in 4 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: pacrunner-0.6-1.fc20.x86_64.rpm
pacrunner.x86_64: W: spelling-error Summary(en_US) dæmon -> demon, Damon
pacrunner.x86_64: W: spelling-error %description -l en_US dæmon -> demon, Damon
pacrunner.x86_64: W: non-conffile-in-etc /etc/dbus-1/system.d/pacrunner.conf
pacrunner.x86_64: W: no-manual-page-for-binary pacrunner
1 packages and 0 specfiles checked; 0 errors, 4 warnings.

I've checked other packages like NetworkManager, and this appears to be the normal way to ship files in /etc/dbus-1/system.d/*.conf.
Comment 2 Richard Hughes 2013-06-07 10:15:58 EDT
I'd love to use this in PackageKit -- on the assumption the D-Bus interface can be queried per-system, rather than per-session.
Comment 3 David Woodhouse 2013-06-07 11:05:51 EDT
New Package SCM Request
=======================
Package Name: pacrunner
Short Description: Proxy configuration dæmon
Owners: dwmw2
Branches: f18 f19 el6
Comment 4 Gwyn Ciesla 2013-06-07 12:51:02 EDT
Git done (by process-git-requests).
Comment 5 Dominik 'Rathann' Mierzejewski 2014-07-02 04:45:43 EDT
*** Bug 701470 has been marked as a duplicate of this bug. ***
Comment 6 Dominik 'Rathann' Mierzejewski 2014-07-02 04:46:54 EDT
I see it's been built for F19+.

Note You need to log in before you can comment on or make changes to this bug.