Spec URL: http://snavin.fedorapeople.org/packages/sugar-starchart/sugar-starchart.spec SRPM URL: http://snavin.fedorapeople.org/packages/sugar-starchart/sugar-starchart-15-1.fc18.src.rpm Description: This activity will display a map of the sky showing the position of the visible stars, some of the larger and brighter deep-sky objects (DSOs), the "classical" planets, the sun and the moon. Fedora Account System Username: snavin
Review:- + Mock build successful for f20 - rpmlint on generated rpms gave sugar-starchart.noarch: E: script-without-shebang /usr/share/sugar/activities/StarChart.activity/activity/activity.info sugar-starchart.noarch: E: script-without-shebang /usr/share/sugar/activities/StarChart.activity/activity/StarChart.svg sugar-starchart.noarch: E: wrong-script-end-of-line-encoding /usr/share/sugar/activities/StarChart.activity/activity/StarChart.svg 2 packages and 0 specfiles checked; 3 errors, 0 warnings. + Source verified with upstream as (sha256sum) srpm tarball : c5e1e4275303b8d60f335a5d73804535daebcb3c312e89546436ec478192ec94 upstream tarball : c5e1e4275303b8d60f335a5d73804535daebcb3c312e89546436ec478192ec94 + License is valid and its text is available + rest looks as per packaging guidelines Suggestions 1) As suggested in previous other reviews change --prefix=%{buildroot}/%{_prefix} to --prefix=%{buildroot}%{_prefix} 2) rpmlint errors can be fixed by adding following line in %prep chmod 644 activity/*
reverted the spec as per suggestions in comment #1 SPEC URL: http://snavin.fedorapeople.org/packages/sugar-starchart/sugar-starchart.spec SRPM URL: http://snavin.fedorapeople.org/packages/sugar-starchart/sugar-starchart-15-2.fc18.src.rpm
Looks good. APPROVED.
New Package SCM Request ======================= Package Name: sugar-starchart Short Description: Display a map of the sky showing the position of the visible stars Owners: snavin Branches: f17 f18 f19 InitialCC:
Git done (by process-git-requests).
sugar-starchart-15-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/sugar-starchart-15-3.fc18
sugar-starchart-15-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/sugar-starchart-15-3.fc19
sugar-starchart-15-3.fc18 has been pushed to the Fedora 18 testing repository.
sugar-starchart-15-3.fc18 has been pushed to the Fedora 18 stable repository.
sugar-starchart-15-3.fc19 has been pushed to the Fedora 19 stable repository.