Bug 972650 - Review Request: sugar-tuxmath - TuxMath is an arcade game that helps people practice their math facts.
Review Request: sugar-tuxmath - TuxMath is an arcade game that helps people p...
Status: NEW
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Extras Quality Assurance
:
Depends On:
Blocks: FE-DEADREVIEW FE-GAMESIG
  Show dependency treegraph
 
Reported: 2013-06-10 06:43 EDT by Danishka Navin
Modified: 2017-08-23 00:57 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Danishka Navin 2013-06-10 06:43:16 EDT
Spec URL: http://snavin.fedorapeople.org/packages/sugar-tuxmath/sugar-tuxmath.spec
SRPM URL:  http://snavin.fedorapeople.org/packages/sugar-tuxmath/sugar-tuxmath-2-1.fc18.src.rpm

Description: TuxMath is an arcade game that helps people practice their math facts.

Fedora Account System Username: snavin
Comment 1 Parag AN(पराग) 2013-11-22 22:44:54 EST
1) See http://fedoraproject.org/wiki/Packaging:Python , you will find now its recommended to use python2 not just python in macros 
so if you have python macro %{__python} change it to %{__python2}


2) This package failed to build because of wrong BR: sugar-toolkit-gtk3
You can identify what correct BR: you can use in your package spec by just looking into setup.py file of upstream source

if it contains lines starting with following code
from sugar.activity 
this mean you should use BR: sugar-toolkit

if it contains lines starting with following code
from sugar3.activity 
this mean you should use BR: sugar-toolkit-gtk3

So, use correct BuildRequires: sugar-toolkit and this package will build fine.

3) also, this package uses bundled libraries which is not accepted in Fedora. See https://fedoraproject.org/wiki/Packaging:Guidelines#Duplication_of_system_libraries

Work with upstream to have this package built against system libraries.
Comment 2 Ben Rosser 2017-08-22 20:47:28 EDT
Are you still interested in this review?
Comment 3 Danishka Navin 2017-08-23 00:57:12 EDT
Yes,I would like to resume working on this.

Note You need to log in before you can comment on or make changes to this bug.