Bug 972995 - RFE: do a size check, and if the image is too small, return a specific error message in addition to FAIL
Summary: RFE: do a size check, and if the image is too small, return a specific error ...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: isomd5sum
Version: rawhide
Hardware: All
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Anaconda Maintenance Team
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-06-11 03:21 UTC by Andre Robatino
Modified: 2019-08-21 15:55 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-08-21 15:55:32 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Andre Robatino 2013-06-11 03:21:50 UTC
Description of problem:
See https://bugzilla.redhat.com/show_bug.cgi?id=972561#c9

Many if not most cases of bad downloads are due to simple truncation. Browsers suck at downloading, and if the server has a hiccup, can just silently truncate the download. Command-line tools like wget are much better but many people don't use them. If checkisomd5 checked the size of the actual image compared to the ISO header size, it could give a specific error message if the image was too small. (Note that Fedora ISOs are hybrid and are bigger than the ISO header size, however it's my understanding that the mediacheck ignores anything past that size anyway.)

If the install type allows checking the ISO size quickly without reading the entire image (for example a hard drive install), this check could be done by anaconda without involving the mediacheck, so even someone who didn't do the mediacheck would be warned. I don't know if that's practical, and if it is it would be a separate RFE.

Version-Release number of selected component (if applicable):
isomd5sum-1.0.10-1.fc19

Comment 1 Brian Lane 2019-08-21 15:55:32 UTC
Closing this. I took a quick look at the code, and while it would be possible to do this I don't think there's enough benefit to justify the changes. It would require changing the checkmd5sum enum return value, resulting in a new API and all the users of checkisomd5, as well as python users, would need to adjust for that.


Note You need to log in before you can comment on or make changes to this bug.