Spec URL: http://slaanesh.fedorapeople.org/libguac-client-ssh.spec SRPM URL: http://slaanesh.fedorapeople.org/libguac-client-ssh-0.8.0-1.fc19.src.rpm Description: Guacamole is an HTML5 web application that provides access to desktop environments using remote desktop protocols such as VNC or RDP. A centralized server acts as a tunnel and proxy, allowing access to multiple desktops through a web browser. No plugins are needed: the client requires nothing more than a web browser supporting HTML5 and AJAX. libguac-client-ssh is a protocol support plugin for the Guacamole proxy (guacd) which provides support for SSH, the secure shell. Fedora Account System Username: slaanesh Note: this is a small library that is a plugin of the Guacamole suite. VNC and RDP libraries are already in the repositories; I need this for updating the main Guacamole app to 0.8.1.
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5492790 $ rpmlint -i -v *libguac-client-ssh.src: I: checking libguac-client-ssh.src: W: spelling-error Summary(en_US) guacd -> guard The value of this tag appears to be misspelled. Please double-check. libguac-client-ssh.src: W: spelling-error %description -l en_US guacd -> guard The value of this tag appears to be misspelled. Please double-check. libguac-client-ssh.src: E: description-line-too-long C libguac-client-ssh is a protocol support plugin for the Guacamole proxy (guacd) which Your description lines must not exceed 80 characters. If a line is exceeding this number, cut it to fit in two lines. libguac-client-ssh.src: I: checking-url http://guac-dev.org/ (timeout 10 seconds) libguac-client-ssh.src: I: checking-url http://guac-dev.org/pub/dist/source/libguac-client-ssh-0.8.0.tar.gz (timeout 10 seconds) libguac-client-ssh.i686: I: checking libguac-client-ssh.i686: W: spelling-error Summary(en_US) guacd -> guard The value of this tag appears to be misspelled. Please double-check. libguac-client-ssh.i686: W: spelling-error %description -l en_US guacd -> guard The value of this tag appears to be misspelled. Please double-check. libguac-client-ssh.i686: E: description-line-too-long C libguac-client-ssh is a protocol support plugin for the Guacamole proxy (guacd) which Your description lines must not exceed 80 characters. If a line is exceeding this number, cut it to fit in two lines. libguac-client-ssh.i686: I: checking-url http://guac-dev.org/ (timeout 10 seconds) libguac-client-ssh.i686: W: devel-file-in-non-devel-package /usr/lib/libguac-client-ssh.so A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. libguac-client-ssh.x86_64: I: checking libguac-client-ssh.x86_64: W: spelling-error Summary(en_US) guacd -> guard The value of this tag appears to be misspelled. Please double-check. libguac-client-ssh.x86_64: W: spelling-error %description -l en_US guacd -> guard The value of this tag appears to be misspelled. Please double-check. libguac-client-ssh.x86_64: E: description-line-too-long C libguac-client-ssh is a protocol support plugin for the Guacamole proxy (guacd) which Your description lines must not exceed 80 characters. If a line is exceeding this number, cut it to fit in two lines. libguac-client-ssh.x86_64: I: checking-url http://guac-dev.org/ (timeout 10 seconds) libguac-client-ssh.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libguac-client-ssh.so A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. libguac-client-ssh-debuginfo.i686: I: checking libguac-client-ssh-debuginfo.i686: I: checking-url http://guac-dev.org/ (timeout 10 seconds) libguac-client-ssh-debuginfo.x86_64: I: checking libguac-client-ssh-debuginfo.x86_64: I: checking-url http://guac-dev.org/ (timeout 10 seconds) libguac-client-ssh.spec: I: checking-url http://guac-dev.org/pub/dist/source/libguac-client-ssh-0.8.0.tar.gz (timeout 10 seconds) 5 packages and 1 specfiles checked; 3 errors, 8 warnings. The spelling errors can be ignored, also the devel file error (for this certain case). So there remain too long description lines. The problem is the %name macro which will be expanded in the resulting plain text description. Actually we have 75 characters in line 20, after expanding we have 86. $ licensecheck -r * include/display.h: MPL (v1.1) GPL (unversioned/unknown version) include/libssh_compat.h: MPL (v1.1) GPL (unversioned/unknown version) include/buffer.h: MPL (v1.1) GPL (unversioned/unknown version) include/char_mappings.h: MPL (v1.1) GPL (unversioned/unknown version) include/ssh_client.h: MPL (v1.1) GPL (unversioned/unknown version) include/terminal_handlers.h: MPL (v1.1) GPL (unversioned/unknown version) include/cursor.h: MPL (v1.1) GPL (unversioned/unknown version) include/common.h: MPL (v1.1) GPL (unversioned/unknown version) include/guac_handlers.h: MPL (v1.1) GPL (unversioned/unknown version) include/types.h: MPL (v1.1) GPL (unversioned/unknown version) include/client.h: MPL (v1.1) GPL (unversioned/unknown version) include/ibar.h: MPL (v1.1) GPL (unversioned/unknown version) include/terminal.h: MPL (v1.1) GPL (unversioned/unknown version) include/blank.h: MPL (v1.1) GPL (unversioned/unknown version) ltmain.sh: GPL (v2 or later) src/display.c: MPL (v1.1) GPL (unversioned/unknown version) src/terminal_handlers.c: MPL (v1.1) GPL (unversioned/unknown version) src/cursor.c: MPL (v1.1) GPL (unversioned/unknown version) src/client.c: MPL (v1.1) GPL (unversioned/unknown version) src/common.c: MPL (v1.1) GPL (unversioned/unknown version) src/ssh_client.c: MPL (v1.1) GPL (unversioned/unknown version) src/blank.c: MPL (v1.1) GPL (unversioned/unknown version) src/char_mappings.c: MPL (v1.1) GPL (unversioned/unknown version) src/guac_handlers.c: MPL (v1.1) GPL (unversioned/unknown version) src/buffer.c: MPL (v1.1) GPL (unversioned/unknown version) src/terminal.c: MPL (v1.1) GPL (unversioned/unknown version) src/ibar.c: MPL (v1.1) GPL (unversioned/unknown version) As "licensecheck" says, we have MPL v1.1 or GPL without versioning. I cannot find the "future versions" clause anywhere, and nowhere LGPL.
Hello, thanks for the review. If you want any other review in return please let me know. (In reply to Mario Blättermann from comment #1) > libguac-client-ssh.src: E: description-line-too-long C libguac-client-ssh is > a protocol support plugin for the Guacamole proxy (guacd) which > Your description lines must not exceed 80 characters. If a line is exceeding > this number, cut it to fit in two lines. Fixed. > $ licensecheck -r * > ltmain.sh: GPL (v2 or later) > src/ibar.c: MPL (v1.1) GPL (unversioned/unknown version) > > As "licensecheck" says, we have MPL v1.1 or GPL without versioning. I cannot > find the "future versions" clause anywhere, and nowhere LGPL. Well, the original website stated that each module of the guacamole stack [1] is triple licensed. Unfortunately the website has change and I can't find the page anymore. Is it ok for the following? License: MPLv1.1 or GPLv2+
Oops, did not paste the link for the other bits: [1] http://koji.fedoraproject.org/koji/search?match=glob&type=package&terms=*guac*
Well, according to [1] the unversioned "GNU General Public License (no version)" should be GPL+; so it should be; License: MPLv1.1 or GPL+ Spec URL: http://slaanesh.fedorapeople.org/libguac-client-ssh.spec SRPM URL: http://slaanesh.fedorapeople.org/libguac-client-ssh-0.8.0-2.fc19.src.rpm I will also check and fix the other guacamole packages. [1] https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses
New scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5496684 $ rpmlint -i -v *libguac-client-ssh.src: I: checking libguac-client-ssh.src: W: spelling-error Summary(en_US) guacd -> guard The value of this tag appears to be misspelled. Please double-check. libguac-client-ssh.src: W: spelling-error %description -l en_US guacd -> guard The value of this tag appears to be misspelled. Please double-check. libguac-client-ssh.src: I: checking-url http://guac-dev.org/ (timeout 10 seconds) libguac-client-ssh.src: I: checking-url http://guac-dev.org/pub/dist/source/libguac-client-ssh-0.8.0.tar.gz (timeout 10 seconds) libguac-client-ssh.i686: I: checking libguac-client-ssh.i686: W: spelling-error Summary(en_US) guacd -> guard The value of this tag appears to be misspelled. Please double-check. libguac-client-ssh.i686: W: spelling-error %description -l en_US guacd -> guard The value of this tag appears to be misspelled. Please double-check. libguac-client-ssh.i686: I: checking-url http://guac-dev.org/ (timeout 10 seconds) libguac-client-ssh.i686: W: devel-file-in-non-devel-package /usr/lib/libguac-client-ssh.so A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. libguac-client-ssh.x86_64: I: checking libguac-client-ssh.x86_64: W: spelling-error Summary(en_US) guacd -> guard The value of this tag appears to be misspelled. Please double-check. libguac-client-ssh.x86_64: W: spelling-error %description -l en_US guacd -> guard The value of this tag appears to be misspelled. Please double-check. libguac-client-ssh.x86_64: I: checking-url http://guac-dev.org/ (timeout 10 seconds) libguac-client-ssh.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libguac-client-ssh.so A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. libguac-client-ssh-debuginfo.i686: I: checking libguac-client-ssh-debuginfo.i686: I: checking-url http://guac-dev.org/ (timeout 10 seconds) libguac-client-ssh-debuginfo.x86_64: I: checking libguac-client-ssh-debuginfo.x86_64: I: checking-url http://guac-dev.org/ (timeout 10 seconds) libguac-client-ssh.spec: I: checking-url http://guac-dev.org/pub/dist/source/libguac-client-ssh-0.8.0.tar.gz (timeout 10 seconds) 5 packages and 1 specfiles checked; 0 errors, 8 warnings. The license is now fully canonical, also the length of the description lines. OK, here we go: --------------------------------- key: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. [+] MUST: The License field in the package spec file must match the actual license. MPLv1.1 or GPL+ [+] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. $ sha256sum * 3ba240031304de56e7f48a59c6d40ffdeb0fd7a5bba905d4b289844d645812db libguac-client-ssh-0.8.0.tar.gz 3ba240031304de56e7f48a59c6d40ffdeb0fd7a5bba905d4b289844d645812db libguac-client-ssh-0.8.0.tar.gz.orig [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [.] MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. [+] MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. [.] MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. [+] MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [+] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. [+] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [+] MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations) [+] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). [+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. [.] MUST: Static libraries must be in a -static package. [.] MUST: Development files must be in a -devel package. [+] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release} [+] MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. [.] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. [+] MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. [+] MUST: All filenames in rpm packages must be valid UTF-8. [.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [.] SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. [+] SHOULD: The reviewer should test that the package builds in mock. See Koji build above (which uses Mock anyway). [.] SHOULD: The package should compile and build into binary rpms on all supported architectures. [.] SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. [.] SHOULD: your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense. ---------------- PACKAGE APPROVED ----------------
Many thanks for the review!
New Package SCM Request ======================= Package Name: libguac-client-ssh Short Description: SSH support for guacd Owners: slaanesh Branches: f19 f18 f17 f16 el6 InitialCC:
Git done (by process-git-requests).
libssh-0.5.4-3.el6,libguac-client-ssh-0.8.0-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/libssh-0.5.4-3.el6,libguac-client-ssh-0.8.0-2.el6
libguac-client-ssh-0.8.0-2.fc19,guacamole-0.8.1-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/libguac-client-ssh-0.8.0-2.fc19,guacamole-0.8.1-1.fc19
libguac-client-ssh-0.8.0-2.fc17,guacamole-0.8.1-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/libguac-client-ssh-0.8.0-2.fc17,guacamole-0.8.1-1.fc17
Package libssh-0.5.4-3.el6, libguac-client-ssh-0.8.0-2.el6: * should fix your issue, * was pushed to the Fedora EPEL 6 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing libssh-0.5.4-3.el6 libguac-client-ssh-0.8.0-2.el6' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2013-10467/libssh-0.5.4-3.el6,libguac-client-ssh-0.8.0-2.el6 then log in and leave karma (feedback).
libguac-client-ssh-0.8.0-2.fc18,guacamole-0.8.1-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/libguac-client-ssh-0.8.0-2.fc18,guacamole-0.8.1-1.fc18
guacd-0.7.0-7.fc19,libguac-0.7.0-5.fc19,libguac-client-rdp-0.7.4-3.fc19,libguac-client-ssh-0.8.0-3.fc19,libguac-client-vnc-0.7.2-3.fc19,guacamole-ext-0.8.0-4.fc19,guacamole-common-js-0.7.1-3.fc19,guacamole-common-0.8.0-5.fc19,guacamole-0.8.1-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/guacd-0.7.0-7.fc19,libguac-0.7.0-5.fc19,libguac-client-rdp-0.7.4-3.fc19,libguac-client-ssh-0.8.0-3.fc19,libguac-client-vnc-0.7.2-3.fc19,guacamole-ext-0.8.0-4.fc19,guacamole-common-js-0.7.1-3.fc19,guacamole-common-0.8.0-5.fc19,guacamole-0.8.1-2.fc19
guacd-0.7.0-7.fc18,libguac-0.7.0-5.fc18,libguac-client-rdp-0.7.4-3.fc18,libguac-client-ssh-0.8.0-3.fc18,libguac-client-vnc-0.7.2-3.fc18,guacamole-ext-0.8.0-3.fc18,guacamole-common-js-0.7.1-3.fc18,guacamole-common-0.8.0-3.fc18,guacamole-0.8.1-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/guacd-0.7.0-7.fc18,libguac-0.7.0-5.fc18,libguac-client-rdp-0.7.4-3.fc18,libguac-client-ssh-0.8.0-3.fc18,libguac-client-vnc-0.7.2-3.fc18,guacamole-ext-0.8.0-3.fc18,guacamole-common-js-0.7.1-3.fc18,guacamole-common-0.8.0-3.fc18,guacamole-0.8.1-2.fc18
guacd-0.7.0-7.fc17,libguac-0.7.0-5.fc17,libguac-client-rdp-0.7.4-3.fc17,libguac-client-ssh-0.8.0-3.fc17,libguac-client-vnc-0.7.2-3.fc17,guacamole-ext-0.8.0-3.fc17,guacamole-common-js-0.7.1-3.fc17,guacamole-common-0.8.0-3.fc17,guacamole-0.8.1-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/guacd-0.7.0-7.fc17,libguac-0.7.0-5.fc17,libguac-client-rdp-0.7.4-3.fc17,libguac-client-ssh-0.8.0-3.fc17,libguac-client-vnc-0.7.2-3.fc17,guacamole-ext-0.8.0-3.fc17,guacamole-common-js-0.7.1-3.fc17,guacamole-common-0.8.0-3.fc17,guacamole-0.8.1-2.fc17
guacd-0.7.0-7.fc19, libguac-0.7.0-5.fc19, libguac-client-rdp-0.7.4-3.fc19, libguac-client-ssh-0.8.0-3.fc19, libguac-client-vnc-0.7.2-3.fc19, guacamole-ext-0.8.0-4.fc19, guacamole-common-js-0.7.1-3.fc19, guacamole-common-0.8.0-5.fc19, guacamole-0.8.1-2.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
guacd-0.7.0-7.fc17, libguac-0.7.0-5.fc17, libguac-client-rdp-0.7.4-3.fc17, libguac-client-ssh-0.8.0-3.fc17, libguac-client-vnc-0.7.2-3.fc17, guacamole-ext-0.8.0-3.fc17, guacamole-common-js-0.7.1-3.fc17, guacamole-common-0.8.0-3.fc17, guacamole-0.8.1-2.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report.
guacd-0.7.0-7.fc18, libguac-0.7.0-5.fc18, libguac-client-rdp-0.7.4-3.fc18, libguac-client-ssh-0.8.0-3.fc18, libguac-client-vnc-0.7.2-3.fc18, guacamole-ext-0.8.0-3.fc18, guacamole-common-js-0.7.1-3.fc18, guacamole-common-0.8.0-3.fc18, guacamole-0.8.1-2.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.
libssh-0.5.4-3.el6, libguac-client-ssh-0.8.0-3.el6, libguac-client-rdp-0.7.4-3.el6, libguac-client-vnc-0.7.2-3.el6, libguac-0.7.0-5.el6, guacd-0.7.0-6.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.