Bug 973343 - redhat-lsb fails to build for aarch64
redhat-lsb fails to build for aarch64
Product: Fedora
Classification: Fedora
Component: redhat-lsb (Show other bugs)
Unspecified Unspecified
unspecified Severity unspecified
: ---
: ---
Assigned To: Ondrej Vasik
Fedora Extras Quality Assurance
: Reopened
Depends On:
  Show dependency treegraph
Reported: 2013-06-11 14:10 EDT by Mark Salter
Modified: 2013-08-13 10:12 EDT (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2013-08-13 10:12:04 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
aarch64 support for redhat-lsb (5.28 KB, patch)
2013-06-11 14:10 EDT, Mark Salter
no flags Details | Diff

  None (edit)
Description Mark Salter 2013-06-11 14:10:29 EDT
Created attachment 759755 [details]
aarch64 support for redhat-lsb

Description of problem:
Cannot build redhat-lsb for aarch64. INTERNAL_SYSCALL needs to be defined for aarch64. Also, aarch64 kernel does not have __NR_symlink syscall. New architectures only have _NR_symlinkat. Patch attached.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:

Actual results:

Expected results:

Additional info:
Comment 1 Ondrej Vasik 2013-06-11 14:54:40 EDT
Thanks for suggestion. Actually, I see redhat-lsb spec doesn't respect arm and aarch64 too much - a lot of defines was missing. I added some guesses, please check them in https://lists.fedoraproject.org/pipermail/scm-commits/Week-of-Mon-20130610/1037979.html and propose adjustments, if needed. Built in Rawhide and F19, as it doesn't affect the primary arches, closing Rawhide (I don't need to do bodhi update for this).
Comment 2 Mark Salter 2013-06-11 16:17:48 EDT
Thanks for the quick turnaround. The other changes look fine except that the ldso name is ld-linux-aarch64.so.1 for aarch64.
Comment 3 Ondrej Vasik 2013-06-11 16:56:38 EDT
Ok, I changed that and pushed it to the Fedora master/f19 git ... no build, no release bump - it will get fixed by the next build.
Comment 4 Mark Salter 2013-08-12 13:19:00 EDT

We got mixed up somewhere and the redhat-lsb-aarch64.patch is a patch of the patchfile, not the actual patch we need. If you get my meaning. :) When %prep applies it, it just creates the patch file we actually want to apply. So build is still broken on aarch64.
Comment 5 Ondrej Vasik 2013-08-13 10:12:04 EDT
Oops, fixed the patch so it patches the file and not that it creates new patch for patching the file. If you know what I mean :). ( https://lists.fedoraproject.org/pipermail/scm-commits/Week-of-Mon-20130812/1091650.html ) - closing RAWHIDE again.

Note You need to log in before you can comment on or make changes to this bug.