Bug 973848 - GUI Error Notification Missing (create new stored key/cert)
Summary: GUI Error Notification Missing (create new stored key/cert)
Alias: None
Product: Spacewalk
Classification: Community
Component: WebUI (Show other bugs)
(Show other bugs)
Version: 1.9
Hardware: Unspecified Unspecified
Target Milestone: ---
Assignee: Tomas Lestach
QA Contact: Red Hat Satellite QA List
: 1104631 (view as bug list)
Depends On:
Blocks: 462714 space21
TreeView+ depends on / blocked
Reported: 2013-06-12 23:21 UTC by The PowerTool
Modified: 2017-05-17 19:38 UTC (History)
3 users (show)

Fixed In Version: spacewalk-java-2.1.38-1
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2014-03-04 13:06:41 UTC
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

Description The PowerTool 2013-06-12 23:21:40 UTC
Description of problem:
Uploading 0-byte file when using "create new stored key/cert" causes the UI to be non-responsive.  No error is presented.  Repeatedly clicking "Create Key" has no effect other than to leave you in the same dialog thinking the button didn't work.

Version-Release number of selected component (if applicable):
Spacewalk 1.9

How reproducible:
Ever time without fail as long as the file is 0 bytes in size

Steps to Reproduce:
Systems : Kickstart : GPG and SSL Keys :

I successfully added RPM-GPG-KEY-rpmfusion-free-fedora-18

I then went to add RPM-GPG-KEY-rpmfusion-nonfree-fedora-18.  I clicked the link to "create new stored key/cert" and then entered the description, left type at GPG, and selected the file to upload using the "Browse" button.  Clicking on Create Key had no effect.

Apparently the GUI knew the I was attempting to upload a 0-byte file but neglected to share this with me.  I spent time troubleshooting this to discover there's an error message missing from the GUI.  If you select a 0-byte file and then click "Create Key" it should warn you that nothing will happen and that your file has no content.

What's a legitimate scenario where this might happen:  Go to a trusted source for keys - http://rpmfusion.org/keys and then download  using the "get" link the 2013-05-19 attachment for the nonfree-fedora-18.  Now you're all set to upload a 0-byte file and click on that "Create Key" button to your heart's content.

Actual results:
No change in UI.  You are left on the same dialog which is prompting you to upload a file containing a key.

Expected results:
An error should display stating that the file contains 0 bytes.  Additional errors may be required--what if the file contents are inappropriate?

Additional info:

Comment 1 Jan Dobes 2013-07-31 16:11:38 UTC
When I try upload blank file on Spacewalk nightly, it fails to same dialog but there is a message in UI - "No file found. Please select a file from your local machine to upload."

Maybe, it's some sort of OS/Browser specific problem, can you provide more info?

Comment 2 The PowerTool 2013-08-01 19:57:04 UTC
Upgraded browser.  Now I am seeing the described message "No file found.  Please select a file from your local machine to upload."  I forgot to look at what version of Firefox I was on before upgrading or I would include that for reference.

Technically the error message is incorrect in this case because the file does exist.  Rather than "No file found."  It should read "File %file is empty or does not contain a valid data structure."  That's assuming it performs some type of validation.

Comment 3 Tomas Lestach 2013-09-06 14:14:47 UTC
 81b58118809c58459544376d0ca9cdbfb175ecb2 (fix error messaging for GPG nad SSL key creation/edit)
 aa244cef42cfc9b344be7961a999a4a84f9f979f (define "type" string)
 49d6f035f9d0cbc2b8d5622851b81dee92713653 (correct an error message)
 d36f52e66348c1db2ce267bf25a1462428f76b89 (file upload isn't required on /rhn/keys/CryptoKeyEdit.do page)
 18797522906127b57b1690c8edc78e2f3dd593bf (store a key only if a file to upload is specified)

Comment 4 Matej Kollar 2014-01-17 12:15:34 UTC
Switching MODIFIED Spacewalk bugs to ON_QA before 2.1 release.

Comment 5 Matej Kollar 2014-03-04 13:06:41 UTC
Spacewalk 2.1 has been released.

Comment 6 Matej Kollar 2014-03-04 13:08:36 UTC
Spacewalk 2.1 has been released.

Comment 7 Grant Gainey 2017-05-17 19:38:57 UTC
*** Bug 1104631 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.