Bug 974054 - Script torquebox_eap_overlay.rb doesn't define modules variable properly
Summary: Script torquebox_eap_overlay.rb doesn't define modules variable properly
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Enterprise WFK Platform 2
Classification: Retired
Component: TorqueBox
Version: 2.3.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: CR1
: 2.3.0
Assignee: Marek Novotny
QA Contact: Tomas Repel
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-06-13 11:02 UTC by Tomas Repel
Modified: 2013-07-16 11:32 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-07-16 11:32:19 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Tomas Repel 2013-06-13 11:02:33 UTC
Description of problem:

Script torquebox_eap_overlay.rb does not define variable `modules` in method `polyglot_modules`. There should be line
`modules = Dir[polyglot_dir].map { |dir| File.basename(dir) }`
but the `modules = ` part is missing.

Version-Release number of selected component (if applicable):

WFK 2.3.0.ER1
TorqueBox 2.3.1.redhat.1

How reproducible:

Always.

Steps to Reproduce:
1. run the script (follow TorqueBox QuickStart Guide)

Actual results:

NameError: undefined local variable or method `modules' for #<EapOverlayer:0x43d248b4>
   polyglot_modules at torquebox_eap_overlay.rb:176
     add_extensions at torquebox_eap_overlay.rb:88
   transform_config at torquebox_eap_overlay.rb:72
  transform_configs at torquebox_eap_overlay.rb:64
            overlay at torquebox_eap_overlay.rb:30
             (root) at torquebox_eap_overlay.rb:208

Expected results:

The script runs without any errors.

Additional info:

This issue is already fix upstrem:
https://github.com/torquebox/torquebox/commit/847a739f0789ae235eedc8dcd0c687ec079f7183

Comment 1 Marek Novotny 2013-06-13 11:27:53 UTC
already fixed by picking up 2.3.2 version into product branch.

Look at merge commit at http://git.app.eng.bos.redhat.com/?p=torquebox.git;a=commitdiff;h=df6189f3a0ab9da89fdd0a7a538032e7e3009224

Comment 3 Tomas Repel 2013-06-26 09:29:09 UTC
Verified in WFK 2.3.0.CR1.


Note You need to log in before you can comment on or make changes to this bug.