Red Hat Bugzilla – Bug 974492
Review Request: php-xmlseclibs - PHP library for XML Security
Last modified: 2015-01-21 06:41:05 EST
Spec URL: http://fkooman.fedorapeople.org/php-xmlseclibs/php-xmlseclibs.spec SRPM URL: http://fkooman.fedorapeople.org/php-xmlseclibs/php-xmlseclibs-1.3.0-2.fc18.src.rpm Description: xmlseclibs is a library written in PHP for working with XML Encryption and Signatures. Fedora Account System Username: fkooman
Created attachment 761576 [details] phpci.log phpcompatinfo version 2.17.0.
Created attachment 761578 [details] review.txt Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 974492
Blockers [!]: Requires correct, justified where necessary. [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [!]: SourceX tarball generation or download is documented. [!]: %check is present and all tests pass.
Created attachment 761579 [details] review.txt
I think I fixed all issues where possible. Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5515838 Spec URL: http://fkooman.fedorapeople.org/php-xmlseclibs/php-xmlseclibs.spec SRPM URL: http://fkooman.fedorapeople.org/php-xmlseclibs/php-xmlseclibs-1.3.0-5.fc18.src.rpm Thanks for your thorough review!
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: SourceX tarball generation or download is documented. [x]: %check is present and all tests pass. [!]: Requires correct, justified where necessary. Still not correct. From http://fedoraproject.org/wiki/Packaging:PHP#Extensions_Requires "PHP extensions must have a Requires on ALL of the dependent extensions." So should , according to phpci, should be, else please justify php-dom php-hash php-libxml php-mcrypt php-openssl (and remove php-xml) [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. The request is fine but not enough. From https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text * Include a copy of what they believe the license text is intended to be... * Choose not to package that software for Fedora. So I propose to wait a little from upstream on your filed bug.
Spec URL: http://fkooman.fedorapeople.org/php-xmlseclibs/php-xmlseclibs.spec SRPM URL: http://fkooman.fedorapeople.org/php-xmlseclibs/php-xmlseclibs-1.3.0-6.fc18.src.rpm Updated the (Build)Requires according to phpci output. I hope the PEAR requirements are sufficient (as it is just used for testing). I also talked to upstream (mail) about the future of the project and they seem to be getting back to updating the code soon. I agree we should probably wait for a new release with the license stuff fixed.
Upstream released a new version, 1.3.1 which addresses all the issues as far as I know and allows for the patch to be removed. Spec URL: http://fkooman.fedorapeople.org/php-xmlseclibs/php-xmlseclibs.spec SRPM URL: http://fkooman.fedorapeople.org/php-xmlseclibs/php-xmlseclibs-1.3.1-1.fc18.src.rpm
[x]: Requires correct, justified where necessary. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. LICENSE file, provided by upstream now include. So, no more blockers. === APPROVED ===
New Package SCM Request ======================= Package Name: php-xmlseclibs Short Description: PHP library for XML Security Owners: fkooman Branches: f18 f19 InitialCC:
@Remi: do you want to be co-owner?
@François, no thanks (If need I will use my provenpackager super-power).
Git done (by process-git-requests).
php-xmlseclibs-1.3.1-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/php-xmlseclibs-1.3.1-1.fc19
php-xmlseclibs-1.3.1-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-xmlseclibs-1.3.1-1.fc18
php-xmlseclibs-1.3.1-1.fc19 has been pushed to the Fedora 19 testing repository.
php-xmlseclibs-1.3.1-1.fc19 has been pushed to the Fedora 19 stable repository.
Package Change Request ====================== Package Name: php-xmlseclibs New Branches: el6 epel7 Owners: fkooman siwinski InitialCC: Co-maintainership approved through email with fkooman. Does he need to add approval here as well?