Bug 974720 (ghc-SafeSemaphore) - Review Request: ghc-SafeSemaphore - Much safer replacement for QSemN, QSem, and SampleVar
Summary: Review Request: ghc-SafeSemaphore - Much safer replacement for QSemN, QSem, a...
Keywords:
Status: CLOSED ERRATA
Alias: ghc-SafeSemaphore
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jens Petersen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 838799
TreeView+ depends on / blocked
 
Reported: 2013-06-15 01:59 UTC by Ben Boeckel
Modified: 2013-07-04 00:51 UTC (History)
3 users (show)

Fixed In Version: ghc-SafeSemaphore-0.9.0-1.fc18
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-07-03 01:36:59 UTC
Type: ---
Embargoed:
petersen: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Ben Boeckel 2013-06-15 01:59:04 UTC
Spec URL: http://benboeckel.net/packaging/ghc-SafeSemaphore/ghc-SafeSemaphore.spec
SRPM URL: http://benboeckel.net/packaging/ghc-SafeSemaphore/ghc-SafeSemaphoer-0.9.0-1.fc20.src.rpm
Description:
This provides a much safer semaphore than the QSem, QSemN, SampleVar in base.                                                                              
Those base modules are not exception safe and can be broken by killThread.                                                                                 
See <https://github.com/ChrisKuklewicz/SafeSemaphore> for more details.

Fedora Account System Username: mathstuf

Comment 2 Jens Petersen 2013-06-17 06:38:14 UTC
BTW the spec url and srpm spec file are different but the differences
are only in the descriptions, changelog and release.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Static libraries in -static subpackage, if present.
  Note: Archive *.a files found in ghc-SafeSemaphore-devel
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries


===== MUST items =====

C/C++:
[-]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Fully versioned dependency in subpackages, if present.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ghc-
     SafeSemaphore-devel
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. No licenses
     found. Please check the source files for licenses manually.
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[-]: Large documentation must go in a -doc subpackage.
     Note: Documentation size is 706560 bytes in 36 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[-]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see attached
     diff).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: ghc-SafeSemaphore-0.9.0-1.fc20.x86_64.rpm
          ghc-SafeSemaphore-devel-0.9.0-1.fc20.x86_64.rpm
ghc-SafeSemaphore.x86_64: W: spelling-error %description -l en_US killThread -> kill Thread, kill-thread, threadlike
ghc-SafeSemaphore.x86_64: W: spelling-error %description -l en_US https -> HTTP
ghc-SafeSemaphore.x86_64: W: spelling-error %description -l en_US github -> git hub, git-hub, thuggish
2 packages and 0 specfiles checked; 0 errors, 3 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint ghc-SafeSemaphore ghc-SafeSemaphore-devel
ghc-SafeSemaphore.x86_64: W: spelling-error %description -l en_US killThread -> kill Thread, kill-thread, threadlike
ghc-SafeSemaphore.x86_64: W: spelling-error %description -l en_US https -> HTTP
ghc-SafeSemaphore.x86_64: W: spelling-error %description -l en_US github -> git hub, git-hub, thuggish
2 packages and 0 specfiles checked; 0 errors, 3 warnings.
# echo 'rpmlint-done:'



Diff spec file in url and in SRPM
---------------------------------
--- /home/petersen/pkgreview/974720-ghc-SafeSemaphore/srpm/ghc-SafeSemaphore.spec	2013-06-17 11:25:48.303400069 +0900
+++ /home/petersen/pkgreview/974720-ghc-SafeSemaphore/srpm-unpacked/ghc-SafeSemaphore.spec	2013-06-17 11:25:50.445392644 +0900
@@ -5,5 +5,5 @@
 Name:           ghc-%{pkg_name}
 Version:        0.9.0
-Release:        2%{?dist}
+Release:        1%{?dist}
 Summary:        Much safer replacement for QSemN, QSem, and SampleVar
 
@@ -21,6 +21,6 @@
 %description
 This provides a much safer semaphore than the QSem, QSemN, SampleVar in base.
-Those base modules are not exception safe and can be broken by killThread. See
-<https://github.com/ChrisKuklewicz/SafeSemaphore> for more details.
+Those base modules are not exception safe and can be broken by killThread.
+See <https://github.com/ChrisKuklewicz/SafeSemaphore> for more details.
 
 
@@ -33,7 +33,5 @@
 
 %description devel
-This package provides the development files for
-the Haskell %{pkg_name} library.
-
+This package provides the Haskell SafeSemaphore library development files.
 
 %prep
@@ -65,7 +63,4 @@
 
 %changelog
-* Sat Jun 15 2013 Fedora Haskell SIG <haskell.org> - 0.9.0-2
-- spec file generated by cabal-rpm-0.8.0
-
 * Sat Jun 15 2013 Fedora Haskell SIG <haskell.org> - 0.9.0-1
 - spec file generated by cabal-rpm-0.8.0


Requires
--------
ghc-SafeSemaphore (rpmlib, GLIBC filtered):
    ghc(base-4.5.1.0-6e4c9bdc36eeb9121f27ccbbcb62e3f3)
    ghc(containers-0.4.2.1-75f143aa39a3e77a1ce2300025bdd8ce)
    ghc(stm-2.4-464c94c0d4d2a3fb7bf1cd1f8648d14d)
    libHSarray-0.4.0.0-ghc7.4.2.so()(64bit)
    libHSbase-4.5.1.0-ghc7.4.2.so()(64bit)
    libHScontainers-0.4.2.1-ghc7.4.2.so()(64bit)
    libHSdeepseq-1.3.0.0-ghc7.4.2.so()(64bit)
    libHSghc-prim-0.2.0.0-ghc7.4.2.so()(64bit)
    libHSinteger-gmp-0.4.0.0-ghc7.4.2.so()(64bit)
    libHSstm-2.4-ghc7.4.2.so()(64bit)
    libc.so.6()(64bit)
    libgmp.so.10()(64bit)
    rtld(GNU_HASH)

ghc-SafeSemaphore-devel (rpmlib, GLIBC filtered):
    /bin/sh
    ghc(SafeSemaphore-0.9.0-b6962139e5e4fe3415b39fea6c8d5525)
    ghc-SafeSemaphore
    ghc-compiler
    ghc-devel(base-4.5.1.0-6e4c9bdc36eeb9121f27ccbbcb62e3f3)
    ghc-devel(containers-0.4.2.1-75f143aa39a3e77a1ce2300025bdd8ce)
    ghc-devel(stm-2.4-464c94c0d4d2a3fb7bf1cd1f8648d14d)



Provides
--------
ghc-SafeSemaphore:
    ghc(SafeSemaphore-0.9.0-b6962139e5e4fe3415b39fea6c8d5525)
    ghc-SafeSemaphore
    ghc-SafeSemaphore(x86-64)
    libHSSafeSemaphore-0.9.0-ghc7.4.2.so()(64bit)

ghc-SafeSemaphore-devel:
    ghc-SafeSemaphore-devel
    ghc-SafeSemaphore-devel(x86-64)
    ghc-devel(SafeSemaphore-0.9.0-b6962139e5e4fe3415b39fea6c8d5525)



Unversioned so-files
--------------------
ghc-SafeSemaphore: /usr/lib64/ghc-7.4.2/SafeSemaphore-0.9.0/libHSSafeSemaphore-0.9.0-ghc7.4.2.so

Source checksums
----------------
http://hackage.haskell.org/packages/archive/SafeSemaphore/0.9.0/SafeSemaphore-0.9.0.tar.gz :
  CHECKSUM(SHA256) this package     : e43f805c567a6bcc155cd4ff2b528199e3b22ef9bacd724ccc95231e190343f5
  CHECKSUM(SHA256) upstream package : e43f805c567a6bcc155cd4ff2b528199e3b22ef9bacd724ccc95231e190343f5


Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -b 974720


Package is APPROVED.

Comment 3 Jens Petersen 2013-06-17 06:51:52 UTC
(In reply to Jens Petersen from comment #2)
> Issues:
> =======
> - Static libraries in -static subpackage, if present.
>   Note: Archive *.a files found in ghc-SafeSemaphore-devel
>   See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries

This is normal for Haskell ghc libraries.

Comment 4 Ben Boeckel 2013-06-17 17:35:43 UTC
New Package SCM Request
=======================
Package Name: ghc-SafeSemaphore
Short Description: Much safer replacement for QSemN, QSem, and SampleVar
Owners: mathstuf
Branches: f18 f19
InitialCC: haskell-sig

Comment 5 Gwyn Ciesla 2013-06-17 17:39:11 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2013-06-24 06:27:20 UTC
ghc-SafeSemaphore-0.9.0-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/ghc-SafeSemaphore-0.9.0-1.fc18

Comment 7 Fedora Update System 2013-06-24 06:27:31 UTC
ghc-SafeSemaphore-0.9.0-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/ghc-SafeSemaphore-0.9.0-1.fc19

Comment 8 Fedora Update System 2013-06-24 18:49:03 UTC
ghc-SafeSemaphore-0.9.0-1.fc19 has been pushed to the Fedora 19 testing repository.

Comment 9 Fedora Update System 2013-07-03 01:36:59 UTC
ghc-SafeSemaphore-0.9.0-1.fc19 has been pushed to the Fedora 19 stable repository.

Comment 10 Fedora Update System 2013-07-04 00:51:52 UTC
ghc-SafeSemaphore-0.9.0-1.fc18 has been pushed to the Fedora 18 stable repository.


Note You need to log in before you can comment on or make changes to this bug.