Bugzilla (bugzilla.redhat.com) will be under maintenance for infrastructure upgrades and will not be unavailable on July 31st between 12:30 AM - 05:30 AM UTC. We appreciate your understanding and patience. You can follow status.redhat.com for details.
Bug 974724 (ghc-haskell-lexer) - Review Request: ghc-haskell-lexer - A fully compliant Haskell 98 lexer
Summary: Review Request: ghc-haskell-lexer - A fully compliant Haskell 98 lexer
Alias: ghc-haskell-lexer
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Jens Petersen
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: ghc-pretty-show
TreeView+ depends on / blocked
Reported: 2013-06-15 02:43 UTC by Ben Boeckel
Modified: 2013-09-14 02:35 UTC (History)
2 users (show)

Fixed In Version: ghc-haskell-lexer-1.0-2.fc18
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2013-09-14 02:32:38 UTC
Type: ---
petersen: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Ben Boeckel 2013-06-15 02:43:33 UTC
Spec URL: http://benboeckel.net/packaging/ghc-haskell-lexer/ghc-haskell-lexer.spec
SRPM URL: http://benboeckel.net/packaging/ghc-haskell-lexer/ghc-haskell-lexer-1.0-1.fc20.src.rpm
A fully compliant Haskell 98 lexer

Fedora Account System Username: mathstuf

Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5505484

Comment 1 Mario Blättermann 2013-07-10 20:19:47 UTC
Scratch build failed:

From build.log:

+ sed -i -e 's!/builddir/build/BUILDROOT/ghc-haskell-lexer-1.0-1.fc20.x86_64!!g' ghc-haskell-lexer.files
+ for i in ghc-haskell-lexer.files ghc-haskell-lexer-devel.files
+ '[' -f ghc-haskell-lexer-devel.files ']'
+ sed -i -e 's!/builddir/build/BUILDROOT/ghc-haskell-lexer-1.0-1.fc20.x86_64!!g' ghc-haskell-lexer-devel.files
+ find /builddir/build/BUILDROOT/ghc-haskell-lexer-1.0-1.fc20.x86_64 -type f -exec sh -c 'file {} | grep -q '\''dynamically linked'\''' ';' -exec strip '{}' ';'
+ find /builddir/build/BUILDROOT/ghc-haskell-lexer-1.0-1.fc20.x86_64/usr/bin -type f -exec sh -c 'file {} | grep -q '\'' ELF '\''' ';' -exec execstack -c '{}' ';'
find: '/builddir/build/BUILDROOT/ghc-haskell-lexer-1.0-1.fc20.x86_64/usr/bin': No such file or directory
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.9gvoIx (%install)
    Bad exit status from /var/tmp/rpm-tmp.9gvoIx (%install)
Child return code was: 1

Comment 2 Jens Petersen 2013-07-21 10:46:33 UTC
Sorry that was my fault (I broke ghc-rpm-macros for one day the week before last).

It should build fine now.

Comment 3 Jens Petersen 2013-07-22 13:15:01 UTC
Only real problem I see is that the license file is MIT though
the cabal file claims it is BSD which it is not.

Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

- Static libraries in -static subpackage, if present.
  Note: Archive *.a files found in ghc-haskell-lexer-devel
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries

This is allowed for Fedora Haskell libraries.

- Large documentation must go in a -doc subpackage.
  Note: Documentation size is 1495040 bytes in 22 files.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation

Still smaller than size of the static libs - waived.

===== MUST items =====

[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[-]: Fully versioned dependency in subpackages, if present.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ghc-

This is okay since API hash which is used in generated requires
is arch dependent anyway.

[x]: Package complies to the Packaging Guidelines
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. No licenses
     found. Please check the source files for licenses manually.

License is MIT not BSD.

[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macros (instead of hard-coded directory
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.

===== SHOULD items =====

[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.

===== EXTRA items =====

[x]: Large data in /usr/share should live in a noarch subpackage if package is
     Note: Arch-ed rpms have a total of 1525760 bytes in /usr/share 10240 ghc-
     haskell-lexer-1.0-1.fc20.x86_64.rpm 1515520 ghc-haskell-lexer-

I feel this can be waived:

$ du -s ghc-haskell-lexer-devel-1.0-1.fc20.x86_64.rpm/usr/*
8112	lib64
1500	share

[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.

Checking: ghc-haskell-lexer-1.0-1.fc20.x86_64.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

Rpmlint (installed packages)
# rpmlint ghc-haskell-lexer ghc-haskell-lexer-devel
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
# echo 'rpmlint-done:'

ghc-haskell-lexer (rpmlib, GLIBC filtered):

ghc-haskell-lexer-devel (rpmlib, GLIBC filtered):



Unversioned so-files
ghc-haskell-lexer: /usr/lib64/ghc-7.6.3/haskell-lexer-1.0/libHShaskell-lexer-1.0-ghc7.6.3.so

Source checksums
http://hackage.haskell.org/packages/archive/haskell-lexer/1.0/haskell-lexer-1.0.tar.gz :
  CHECKSUM(SHA256) this package     : 86d0c4071295c8613eb965768cb61a0c8422fc0c429a49c7a93e93a72b185b86
  CHECKSUM(SHA256) upstream package : 86d0c4071295c8613eb965768cb61a0c8422fc0c429a49c7a93e93a72b185b86

Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -b 974724

I am happy to approve if you update License to MIT.
But this discrepancy should be reported to the author.

Comment 5 Jens Petersen 2013-08-26 07:51:16 UTC
Ben, will you update the package or do you want to fix it when importing?

Comment 7 Jens Petersen 2013-08-27 01:37:48 UTC
Thanks - looks good now.


Comment 8 Ben Boeckel 2013-08-27 02:03:33 UTC
New Package SCM Request
Package Name: ghc-haskell-lexer
Short Description: A fully compliant Haskell 98 lexer
Owners: mathstuf
Branches: f20 f19 f18 el6
InitialCC: haskell-sig

Comment 9 Gwyn Ciesla 2013-08-27 12:13:44 UTC
Git done (by process-git-requests).

Comment 10 Fedora Update System 2013-09-04 01:14:51 UTC
ghc-haskell-lexer-1.0-2.fc18 has been submitted as an update for Fedora 18.

Comment 11 Fedora Update System 2013-09-04 01:15:02 UTC
ghc-haskell-lexer-1.0-2.fc19 has been submitted as an update for Fedora 19.

Comment 12 Fedora Update System 2013-09-05 01:29:14 UTC
ghc-haskell-lexer-1.0-2.fc18 has been pushed to the Fedora 18 testing repository.

Comment 13 Fedora Update System 2013-09-14 02:32:38 UTC
ghc-haskell-lexer-1.0-2.fc19 has been pushed to the Fedora 19 stable repository.

Comment 14 Fedora Update System 2013-09-14 02:35:41 UTC
ghc-haskell-lexer-1.0-2.fc18 has been pushed to the Fedora 18 stable repository.

Note You need to log in before you can comment on or make changes to this bug.