Bug 975386 - Review Request: ddate - Convert Gregorian dates to Discordian dates
Summary: Review Request: ddate - Convert Gregorian dates to Discordian dates
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-06-18 10:34 UTC by Petr Pisar
Modified: 2014-04-04 06:10 UTC (History)
3 users (show)

Fixed In Version: ddate-0.2.1-1.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-04-04 02:22:50 UTC
Type: ---
Embargoed:
psabata: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Petr Pisar 2013-06-18 10:34:10 UTC
Spec URL: http://ppisar.fedorapeople.org/ddate/ddate.spec
SRPM URL: http://ppisar.fedorapeople.org/ddate/ddate-0.2.1-1.fc18.src.rpm
Description:
This tool prints a date in the Discordian date format.

Fedora Account System Username: ppisar

Comment 1 Petr Šabata 2013-06-18 12:29:51 UTC
You could use the tag tarballs instead of the commit, e.g.:
https://github.com/bo0ts/ddate/archive/v0.2.1.tar.gz
That will make many things somewhat less ugly.

Additionally, I'd suggest including patch c19fe89, too.

Use %{name} in URL.

Comment 2 Petr Pisar 2013-06-18 12:55:38 UTC
Thanks for the hints. I'm not an expert on Github user interface.

Updated package is on the same address.

Comment 3 Petr Šabata 2013-06-18 13:25:27 UTC
Much better.
Approving.

Comment 4 Petr Pisar 2013-06-18 13:48:57 UTC
New Package SCM Request
=======================
Package Name: ddate
Short Description: Convert Gregorian dates to Discordian dates
Owners: ppisar
Branches: f17 f18 f19
InitialCC:

Comment 5 Gwyn Ciesla 2013-06-18 14:50:34 UTC
Git done (by process-git-requests).

Comment 6 Petr Pisar 2013-06-18 15:27:02 UTC
Thank you for the review and the repository.

Comment 7 Petr Šabata 2014-04-03 16:55:34 UTC
Hmm, I don't see any messages from the update system here.
Did you push and build this into all the branches you requested?

Comment 8 Petr Pisar 2014-04-04 06:10:24 UTC
Tue Jun 18 17:23:53 2013: ddate-0.2.1-1.fc19 tagged into f19-updates-candidate by ppisar
Tue Jun 18 17:27:31 2013: ddate-0.2.1-1.fc19 tagged into f19-updates-testing-pending by bodhi
Tue Jun 18 19:07:49 2013: ddate-0.2.1-1.fc19 untagged from f19-updates-candidate by bodhi
Tue Jun 18 19:07:49 2013: ddate-0.2.1-1.fc19 tagged into f19-updates-testing by bodhi
Tue Jun 18 19:12:35 2013: ddate-0.2.1-1.fc19 untagged from f19-updates-testing-pending by bodhi
Wed Jun 26 08:29:14 2013: ddate-0.2.1-1.fc19 tagged into f19-updates-pending by bodhi
Sat Jun 29 17:31:31 2013: ddate-0.2.1-1.fc19 untagged from f19-updates-testing by bodhi
Sat Jun 29 17:31:31 2013: ddate-0.2.1-1.fc19 tagged into f19-updates by bodhi [still active]
Sat Jun 29 17:38:15 2013: ddate-0.2.1-1.fc19 untagged from f19-updates-pending by bodhi

It's in the stable.


Note You need to log in before you can comment on or make changes to this bug.