Bug 977156 - Code to return
Summary: Code to return
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: rpmlint
Version: 18
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Tom "spot" Callaway
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-06-23 22:15 UTC by MERCIER Jonathan
Modified: 2013-06-25 20:46 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-06-25 20:46:50 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description MERCIER Jonathan 2013-06-23 22:15:29 UTC 
why rpmdiff return 1 when it found a diff ?

The return code 1 is used for error.

a diff is not an error


this break my worklow as trap exit on error aka exit code 1
Comment 1 Todd Zullinger 2013-06-24 00:08:25 UTC 
This is the standard way that diff behaves.  To quote the diff documentation¹, "An exit status of 0 means no differences were found, 1 means some differences were found, and 2 means trouble."

I don't think there is any bug in rpmdiff following the same pattern.

¹ https://www.gnu.org/software/diffutils/manual/html_node/Invoking-diff.html
Comment 2 MERCIER Jonathan 2013-06-25 20:46:50 UTC 
ok no problem if that is intentional i can understand why you done this.

Thanks
Note You need to log in before you can comment on or make changes to this bug.