Bug 977568 - grubby fails to build for 64-bit ARM (Aarch64)
Summary: grubby fails to build for 64-bit ARM (Aarch64)
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: grubby
Version: 19
Hardware: arm
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Peter Jones
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-06-24 23:13 UTC by D. Marlin
Modified: 2014-05-29 19:22 UTC (History)
2 users (show)

Fixed In Version: grubby-8.31-1.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-05-29 19:22:52 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Patch to only set RPM_OPT_FLAGS if undefined. (1.03 KB, patch)
2013-06-24 23:15 UTC, D. Marlin
no flags Details | Diff

Description D. Marlin 2013-06-24 23:13:05 UTC
Description of problem:

grubby fails to build for 64-bit ARM (Aarch64) due to a compile error.

Version-Release number of selected component (if applicable):

grubby-8.26-2.fc19

How reproducible:

Consistently

Steps to Reproduce:
on an Aarch64 simulator/builder - 
1. yum downloader --source grubby
2. mock --rebuild grubby-8.26-2.fc19.src.rpm
3.

Actual results:
--------------------
+ make
gcc -O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector -std=gnu99 -Wall -Werror -Wno-error=unused-function -Wno-unused-function -ggdb -DVERSION='"8.26"' -c -o grubby.o grubby.c
grubby.c:1:0: error: -fstack-protector not supported for this target [-Werror]
 /*
 ^
cc1: all warnings being treated as errors
make: *** [grubby.o] Error 1
--------------------

Expected results:

Package builds without errors.

Additional info:

RPM_OPT_FLAGS is set in the grubby Makefile, which overrides the settings in the rpm macros.  This breaks the Aarch64 build.

Comment 1 D. Marlin 2013-06-24 23:15:29 UTC
Created attachment 764811 [details]
Patch to only set RPM_OPT_FLAGS if undefined.

I verified this builds through mock on both x86_64 and aarch64.

Comment 2 D. Marlin 2014-05-29 19:22:52 UTC
Verified the current version (grubby-8.33-1.fc21) built in rawhide.


Note You need to log in before you can comment on or make changes to this bug.