RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 977678 - Options handle problem for blockjob command
Summary: Options handle problem for blockjob command
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libvirt
Version: 7.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Ján Tomko
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-06-25 06:54 UTC by yanbing du
Modified: 2014-06-18 00:51 UTC (History)
9 users (show)

Fixed In Version: libvirt-1.1.1-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-06-13 10:29:49 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)

Description yanbing du 2013-06-25 06:54:16 UTC 
Description of problem:
For virsh blockjob, which can manage active block operations(abort or pivot), and there may be several problems which need fix about the corresponding options.
1. "--abort" and "--pivot" should be mutually exclusive;
2. "--async" should only work with "--abort";
3. "--pivot" should only work when copy job in mirroring phase, that means when the job in data copy phase, execute pivot should report error.


Version-Release number of selected component (if applicable):
libvirt-1.0.6-1.el7.x86_64 

How reproducible:
100% 

Steps to Reproduce:
1. Start a block copy job.
#virsh blockcopy $guest $target $dest_path --wait --verbose

2. Run virsh blcokjob with
#virsh blockjob $guest $target --abort --pivot
#virsh blockjob $guest $target --async

or before copy job progress up to 100%, do pivot:
#virsh blockjob $guest $target --pivot 


Actual results:
There's no check about the problems mentioned above. 

Expected results:
Libvirt should handle these options before respond them. 

Additional info:
Comment 2 Ján Tomko 2013-07-01 13:15:45 UTC 
I'm not sure we should make --abort and --pivot exclusive, since --pivot is done through virDomainBlockJobAbort API.

I have posted patches for the other two issues upstream:
https://www.redhat.com/archives/libvir-list/2013-July/msg00035.html
Comment 3 Ján Tomko 2013-07-02 06:14:52 UTC 
For --pivot: --async has no effect, since pivot is always asynchronous at the moment and we shouldn't forbid the combination:
https://www.redhat.com/archives/libvir-list/2013-July/msg00046.html

The missing error messages are now fixed upstream:
commit c34107dfd3a25232255e6d6f559b1306ef99bb3b
Author:     Ján Tomko <jtomko>
AuthorDate: 2013-07-01 12:41:34 +0200
Commit:     Ján Tomko <jtomko>
CommitDate: 2013-07-02 07:51:51 +0200

    qemu: fix return value of qemuDomainBlockPivot on errors
    
    If qemuMonitorBlockJob returned 0, qemuDomainBlockPivot
    might return 0 even if an error occured.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=977678

git describe: v1.1.0-7-gc34107d
Comment 4 Luwen Su 2013-08-02 07:53:15 UTC 
According the patch  , only test the procudre that do pivot when blockcopy

libvirt-1.1.1-1.el7.x86_64

One terminal excute:
# virsh blockcopy test hda /var/lib/libvirt/images/c.img --wait --verbose
Block Copy: [  2 %]

At the same time , open another terminal do
# virsh blockjob test hda  --pivot
error: block copy still active: disk 'hda' not ready for pivot yet

the function went to 

if (!disk->mirroring) {
        virReportError(VIR_ERR_BLOCK_COPY_ACTIVE,
                       _("disk '%s' not ready for pivot yet"),
                       disk->dst);
        goto cleanup;
    }

So set it VERIFIED
Comment 5 Ludek Smid 2014-06-13 10:29:49 UTC 
This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.
Note You need to log in before you can comment on or make changes to this bug.