Spec URL: http://axilleas.fedorapeople.org/pkgs/rubygem-redis/rubygem-redis.spec SRPM URL: http://axilleas.fedorapeople.org/pkgs/rubygem-redis/rubygem-redis-3.0.4-1.fc19.src.rpm Description: A Ruby client that tries to match Redis' API one-to-one, while still providing an idiomatic interface. It features thread-safety, client-side sharding, pipelining, and an obsession for performance. Fedora Account System Username: axilleas ------ koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5539385 (Although, it fails as it cannot open a netcat connection needed by one of tests, will refer about this on devel) Other useful logs (rpmlint, mock): http://axilleas.fedorapeople.org/pkgs/rubygem-redis/
I'll take this for a review.
(In reply to Axilleas Pipinellis from comment #0) > (Although, it fails as it cannot open a netcat connection needed by one of > tests, will refer about this on devel) This can be workarounded by applying: sed -i "s/localhost/localhost4/" test/publish_subscribe_test.rb prior the test suite is executed. After discussion with ncat maintainer, we discovered, that the "localhost" resolves to IPv6 address, while Redis does not suppoer IPv6 yet [1]. You might want to try to propose this fix to upstream as well, until Redis is IPv6 ready. * rpmlint error - You should not include dot files in RPM, as is reported by rpmlint: rubygem-redis-doc.noarch: E: version-control-internal-file /usr/share/gems/gems/redis-3.0.4/test/db/.gitignore * Remove Requires: Redis - This is Redis client library. The server can run on Remote machine. Therefore Redis should not be runtime dependency of this package, until there will be some kind of soft dependencies supported by YUM/RPM Otherwise the package looks good. Please fix these two nits. [1] https://github.com/antirez/redis/pull/61
Actually 3 nits ;)
Just FYI: https://bugzilla.redhat.com/show_bug.cgi?id=978964
(In reply to Vít Ondruch from comment #2) > (In reply to Axilleas Pipinellis from comment #0) > > (Although, it fails as it cannot open a netcat connection needed by one of > > tests, will refer about this on devel) > > This can be workarounded by applying: > > sed -i "s/localhost/localhost4/" test/publish_subscribe_test.rb > > prior the test suite is executed. After discussion with ncat maintainer, we > discovered, that the "localhost" resolves to IPv6 address, while Redis does > not suppoer IPv6 yet [1]. You might want to try to propose this fix to > upstream as well, until Redis is IPv6 ready. Replacing localhost with localhost4 fails with: [422/485] TestPublishSubscribe#test_subscribe_past_a_timeoutNcat: Could not resolve hostname "localhost4": Name or service not known. QUITTING. Which is ok, since in my /etc/hosts I have localhost6 for IPv6 and localhost for IPv4. I don't think changing these values should be the way of this fix. How come it plays nice for you? I changed it to 127.0.0.1 in order to pass the test. On another note, some distros still use the old gnu-netcat which doesn't fail as with ncat. That might be an issue if I opened a bug report. Finally, I found out that by explicitly telling ncat to use IPv4, build passes. See this koji build where I passed the -4 switch to nc: http://koji.fedoraproject.org/koji/taskinfo?taskID=5551282 > * rpmlint error > - You should not include dot files in RPM, as is reported by rpmlint: > > rubygem-redis-doc.noarch: E: version-control-internal-file > /usr/share/gems/gems/redis-3.0.4/test/db/.gitignore Oops, I forgot to run rpmlint on the -doc subpackage... Fixed. > * Remove Requires: Redis > - This is Redis client library. The server can run on Remote machine. > Therefore Redis should not be runtime dependency of this package, until > there will be some kind of soft dependencies supported by YUM/RPM Removed. -------------------- New Spec URL: http://axilleas.fedorapeople.org/pkgs/rubygem-redis/rubygem-redis.spec New SRPM URL: http://axilleas.fedorapeople.org/pkgs/rubygem-redis/rubygem-redis-3.0.4-2.fc19.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5551169
Hi, sorry for the delay :/ * ncat - You might want to reference bug 978964 in your .spec file, since it seems there is also some progress with regard to fallback to IPv4 if IPv6 is not available. Let's see, which of the two fixes will land sooner ;) * rpmlint - rpmlint still complains: rubygem-redis-doc.noarch: E: version-control-internal-file /usr/share/gems/gems/redis-3.0.4/test/db/.gitignore - You should exclude the file in -doc subpackage, not in the main package. * Unstable test suite - It seems that test suite may fail sometimes: http://koji.fedoraproject.org/koji/taskinfo?taskID=5882957 - It might be even ARM related. Who knows ... Second build on ARM was just OK and it builds on my laptop just fine. So it might be just worth of consultation with upstream. It seems to be just floating point precision issue anyway. Otherwise the package looks good => APPROVED. Please fix the rpmlint issue prior importing.
Thanks, I've updated the relevant parts, see SPEC in my previous comment. New Package SCM Request ======================= Package Name: rubygem-redis Short Description: A Ruby client library for Redis Owners: axilleas Branches: f19 f20 InitialCC:
Git done (by process-git-requests).
rubygem-redis-3.0.4-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/rubygem-redis-3.0.4-3.fc19
rubygem-redis-3.0.4-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/rubygem-redis-3.0.4-3.fc20
rubygem-redis-3.0.4-3.fc20 has been pushed to the Fedora 20 testing repository.
rubygem-redis-3.0.4-3.fc20 has been pushed to the Fedora 20 stable repository.
rubygem-redis-3.0.4-3.fc19 has been pushed to the Fedora 19 stable repository.