Spec URL: http://phracek.fedorapeople.org/libtiff3/libtiff3.spec SRPM URL: http://phracek.fedorapeople.org/libtiff3/libtiff3-3.9.7-3.fc19.src.rpm Description: Proposed backwards-compatibility package for libtiff 3 The libtiff3 package provides libtiff 3, an older version of libtiff library for manipulating TIFF (Tagged Image File Format) image format files. This version should be used only if you are unable to use the current version of libtiff. Fedora Account System Username: phracek == Review == rpmlint outputs: ~/work/libtiff3> rpmlint libtiff3.spec libtiff3.spec:57: W: make-check-outside-check-section LD_LIBRARY_PATH=$PWD:$LD_LIBRARY_PATH make check 0 packages and 1 specfiles checked; 0 errors, 1 warnings. ~/work/libtiff3> rpmlint /home/phracek/rpmbuild/SRPMS/libtiff3-3.9.7-3.fc19.src.rpm libtiff3.src: W: spelling-error Summary(en_US) libtiff -> lib tiff, lib-tiff, liftoff libtiff3.src: W: spelling-error %description -l en_US libtiff -> lib tiff, lib-tiff, liftoff libtiff3.src:57: W: make-check-outside-check-section LD_LIBRARY_PATH=$PWD:$LD_LIBRARY_PATH make check 1 packages and 0 specfiles checked; 0 errors, 3 warnings. ~/work/libtiff3> ~/work/libtiff3> rpmlint /var/lib/mock/fedora-19-x86_64/result/libtiff3-3.9.7-3.fc19.x86_64.rpm libtiff3.x86_64: W: spelling-error Summary(en_US) libtiff -> lib tiff, lib-tiff, liftoff libtiff3.x86_64: W: spelling-error %description -l en_US libtiff -> lib tiff, lib-tiff, liftoff 1 packages and 0 specfiles checked; 0 errors, 2 warnings. ~/work/libtiff3> ~/work/libtiff3> rpm -qpl /var/lib/mock/fedora-19-x86_64/result/libtiff3-3.9.7-3.fc19.x86_64.rpm /usr/lib64/libtiff.so.3 /usr/lib64/libtiff.so.3.9.7 /usr/lib64/libtiffxx.so.3 /usr/lib64/libtiffxx.so.3.9.7 /usr/share/doc/libtiff3-3.9.7 /usr/share/doc/libtiff3-3.9.7/COPYRIGHT /usr/share/doc/libtiff3-3.9.7/README /usr/share/doc/libtiff3-3.9.7/RELEASE-DATE /usr/share/doc/libtiff3-3.9.7/VERSION ~/work/libtiff3>
first coupe of notes before a formal review: - you can drop %buildroot and %defattr, rpmbuild cares of them since F-12 - can you use autoreconf instead of calling the tools individually? - can the "make check" be moved to %check section? - the Summary tag should be like "libtiff version 3 runtime library", the details, why it exists, are in Description
libtiff3 compatibility package will not be included in Fedora repositories