Note: This bug is displayed in read-only format because
the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Prior to this update, the libvirtd daemon leaked memory in the virCgroupMoveTask() function. A fix has been provided which prevents libvirtd from incorrect management of memory allocations.
Description of problem:
libvirtd leaks memory in virCgroupMoveTask
Version-Release number of selected component (if applicable):
libvirt-0.10.2-18.el6_4.9.x86_64
How reproducible:
100 %
Steps to Reproduce:
1. run libvirtd under valgrind:
valgrind --leak-check=full libvirtd
2. create a domain:
virsh create /dev/stdin <<EOF
<domain type='qemu'>
<name>duck</name>
<memory unit='MiB'>32</memory>
<os>
<type arch='x86_64' machine='pc'>hvm</type>
</os>
</domain>
EOF
Domain duck created from /dev/stdin
Actual results:
Valgrind shows a memory leak:
==4945== 16,386 bytes in 2 blocks are definitely lost in loss record 715 of 722
==4945== at 0x4A069EE: malloc (vg_replace_malloc.c:270)
==4945== by 0x4A06B62: realloc (vg_replace_malloc.c:662)
==4945== by 0x4E787CB: virReallocN (memory.c:160)
==4945== by 0x4E87A89: virFileReadLimFD (util.c:400)
==4945== by 0x4E87BF7: virFileReadAll (util.c:461)
==4945== by 0x4E6D140: virCgroupGetValueStr (cgroup.c:363)
==4945== by 0x4E6DD7D: virCgroupMoveTask (cgroup.c:897)
==4945== by 0x471328: qemuSetupCgroupForEmulator (qemu_cgroup.c:695)
==4945== by 0x48648E: qemuProcessStart (qemu_process.c:3965)
==4945== by 0x461678: qemudDomainCreate (qemu_driver.c:1595)
==4945== by 0x4F0A580: virDomainCreateXML (libvirt.c:1954)
==4945== by 0x43FBD0: remoteDispatchDomainCreateXMLHelper (remote_dispatch.h:1172)
Expected results:
libvirtd frees the memory.
Fixed upstream:
commit 5bc8ecb8d1170f41d4c177c1cf0e87c54194a3a3
Author: Ján Tomko <jtomko>
AuthorDate: 2013-06-26 14:55:27 +0200
Commit: Ján Tomko <jtomko>
CommitDate: 2013-06-26 15:38:01 +0200
Plug leak in virCgroupMoveTask
We only break out of the while loop if *content is an empty string.
However the buffer has been allocated to BUFSIZ + 1 (8193 in my case),
but it gets overwritten in the next for iteration.
Move VIR_FREE right before we overwrite it to avoid the leak.
==5777== 16,386 bytes in 2 blocks are definitely lost in loss record 1,022 of 1,027
==5777== by 0x5296E28: virReallocN (viralloc.c:184)
==5777== by 0x52B0C66: virFileReadLimFD (virfile.c:1137)
==5777== by 0x52B0E1A: virFileReadAll (virfile.c:1199)
==5777== by 0x529B092: virCgroupGetValueStr (vircgroup.c:534)
==5777== by 0x529AF64: virCgroupMoveTask (vircgroup.c:1079)
Introduced by 83e4c77.
https://bugzilla.redhat.com/show_bug.cgi?id=978352
git describe: v1.1.0-rc1-26-g5bc8ecb
Downstream patch posted too:
http://post-office.corp.redhat.com/archives/rhvirt-patches/2013-June/msg00656.html
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.
http://rhn.redhat.com/errata/RHBA-2013-1581.html
Description of problem: libvirtd leaks memory in virCgroupMoveTask Version-Release number of selected component (if applicable): libvirt-0.10.2-18.el6_4.9.x86_64 How reproducible: 100 % Steps to Reproduce: 1. run libvirtd under valgrind: valgrind --leak-check=full libvirtd 2. create a domain: virsh create /dev/stdin <<EOF <domain type='qemu'> <name>duck</name> <memory unit='MiB'>32</memory> <os> <type arch='x86_64' machine='pc'>hvm</type> </os> </domain> EOF Domain duck created from /dev/stdin Actual results: Valgrind shows a memory leak: ==4945== 16,386 bytes in 2 blocks are definitely lost in loss record 715 of 722 ==4945== at 0x4A069EE: malloc (vg_replace_malloc.c:270) ==4945== by 0x4A06B62: realloc (vg_replace_malloc.c:662) ==4945== by 0x4E787CB: virReallocN (memory.c:160) ==4945== by 0x4E87A89: virFileReadLimFD (util.c:400) ==4945== by 0x4E87BF7: virFileReadAll (util.c:461) ==4945== by 0x4E6D140: virCgroupGetValueStr (cgroup.c:363) ==4945== by 0x4E6DD7D: virCgroupMoveTask (cgroup.c:897) ==4945== by 0x471328: qemuSetupCgroupForEmulator (qemu_cgroup.c:695) ==4945== by 0x48648E: qemuProcessStart (qemu_process.c:3965) ==4945== by 0x461678: qemudDomainCreate (qemu_driver.c:1595) ==4945== by 0x4F0A580: virDomainCreateXML (libvirt.c:1954) ==4945== by 0x43FBD0: remoteDispatchDomainCreateXMLHelper (remote_dispatch.h:1172) Expected results: libvirtd frees the memory.