Spec URL: http://mstuchli.fedorapeople.org/rpm-compare-req.spec SRPM URL: http://mstuchli.fedorapeople.org/rpm-compare-req-0.1.0-1.fc18.src.rpm Description: rpm-compare-req is a tool for comparing dependencies of an RPM against a set of repositories. Fedora Account System Username: mstuchli
Where is the %changelog section?
And summary is too log, please change it.
(In reply to Christopher Meng from comment #2) > And summary is too log, please change it. Interesting, I can not find any reference to "is too log". How do you measure it and where is the limit? https://fedoraproject.org/wiki/Packaging:Guidelines#summary
Whops! Changelog added and summary shortened. Spec URL: http://mstuchli.fedorapeople.org/rpm-compare-req.spec SRPM URL: http://mstuchli.fedorapeople.org/rpm-compare-req-0.1.0-1.fc18.src.rpm
(In reply to Christopher Meng from comment #1) > Where is the %changelog section? Are you willing to continue in review or this is just drop-by comment? Because I'd like to assign this one to myself.
(In reply to Matthias Runge from comment #3) > (In reply to Christopher Meng from comment #2) > > And summary is too log, please change it. > > Interesting, I can not find any reference to "is too log". > How do you measure it and where is the limit? > > https://fedoraproject.org/wiki/Packaging:Guidelines#summary Now that I look at it rpmlint does complain about the length of the summary.
also https://fedoraproject.org/wiki/Examples_of_good_package_summaries [this is a drop-by comment with no look at the spec file ;)]
(In reply to Robert Kuska from comment #5) > (In reply to Christopher Meng from comment #1) > > Where is the %changelog section? > > Are you willing to continue in review or this is just drop-by comment? > Because I'd like to assign this one to myself. So I am taking this for a review.
Rpmlint ------- Checking: rpm-compare-req-0.1.0-1.fc18.x86_64.rpm rpm-compare-req.x86_64: E: description-line-too-long C rpm-compare-req is a tool for comparing dependencies of an rpm-compare-req.x86_64: E: no-binary rpm-compare-req.x86_64: W: no-manual-page-for-binary rpm-compare-req 1 packages and 0 specfiles checked; 2 errors, 1 warnings. * fix the line length, should be =< 80 * add BuildArch: noarch
Fix'd. Spec URL: http://mstuchli.fedorapeople.org/rpm-compare-req.spec SRPM URL: http://mstuchli.fedorapeople.org/rpm-compare-req-0.1.0-2.fc18.src.rpm
Looks good now. Approved.
New Package SCM Request ======================= Package Name: rpm-compare-req Short Description: Tool for comparing RPM dependencies against a set of repositories Owners: mstuchli Branches: f19 InitialCC:
Git done (by process-git-requests).
rpm-compare-req-0.1.0-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/rpm-compare-req-0.1.0-2.fc19
rpm-compare-req-0.1.0-2.fc19 has been pushed to the Fedora 19 testing repository.
(In reply to Robert Kuska from comment #5) > Are you willing to continue in review or this is just drop-by comment? > Because I'd like to assign this one to myself. Ah...Sorry a bit late now... I will take a review if I change its flag, sorry for not making it clear.
rpm-compare-req-0.1.0-2.fc19 has been pushed to the Fedora 19 stable repository.