Bug 978941 - Grub uses the wrong memory node
Summary: Grub uses the wrong memory node
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: grub2
Version: 18
Hardware: ppc64
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Peter Jones
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-06-27 10:19 UTC by Benjamin Herrenschmidt
Modified: 2014-02-05 21:59 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-02-05 21:59:26 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Benjamin Herrenschmidt 2013-06-27 10:19:45 UTC
Description of problem:

On a system with multiple "/memory@xxx" nodes, grub misbehaves. For it's memory
allocations I observe that it does a "finddevice" call to the client interface
for the "/memory" node and then looks for the "available" property in there.

This is broken potentially on systems with several such nodes, as OF can return
any of the memory nodes. They might not all have an 'available' property and
may represent memory outside of the "RMA" which is the only area grub2 should
be allowed to access in real mode on some systems.

A typical case of that breakage is running under KVM on a 970 where the RMA
is only 256M and the rest of memory is represented in a separate node.

I have added a hack to SLOF to workaround that problem by forcing any "finddevice" of "/memory" to always return "/memory@0" instead but grub should be made smarter and either:

 - Request "/memory@0"

or

 - Iterate all memory nodes and pick up the lowest one

The latter is only needed if that code is to be used on a system which doesn't have memory starting at 0.

At least on powerpc...

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Fedora End Of Life 2013-12-21 14:10:20 UTC
This message is a reminder that Fedora 18 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 18. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '18'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 18's end of life.

Thank you for reporting this issue and we are sorry that we may not be 
able to fix it before Fedora 18 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior to Fedora 18's end of life.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 2 Fedora End Of Life 2014-02-05 21:59:26 UTC
Fedora 18 changed to end-of-life (EOL) status on 2014-01-14. Fedora 18 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.