Red Hat Bugzilla – Bug 979749
Review Request: rubygem-time-lord - Managing concepts of time and space in Ruby
Last modified: 2016-01-04 00:51:22 EST
Spec URL: http://codeblock.fedorapeople.org/packages/rubygem-time-lord/rubygem-time-lord.spec
SRPM URL: http://codeblock.fedorapeople.org/packages/rubygem-time-lord/rubygem-time-lord-1.0.1-1.fc19.src.rpm
time-lord is a gem that gives you more human like expressions for time and
space math. Underneath the covers time-lord gives you single purpose objects
for handling the more complex parts of Time & Space. Specifically conversion,
periods between two points, and scaling.
Fedora Account System Username: codeblock
1, "# I filed a bug on this upstream, but this works around it for now."
In such cases. please always include the link to the upstream bug.
2, The package should BuildRequires: ruby(release) for >= f19 and BuildRequires: ruby(abi) for < f19
3, Please change BuildRequires of rubygem(timecop), rubygem(yard), rubygem(pry), ... to the new syntax: rubygem-timecop, rubygem-yard, rubygem-pry, ...
4, Don't use rake for running the test suite, ideally use MiniTest. See the guidelines 
5, Get rid of Bundler dependency as it's not needed and it's problematic to use in packages.
6, 'pry', 'coveralls', 'timecop' are listed as development dependencies... are they really needed for tests? I think if you delete those lines from the test suite, it will work without them. Less dependencies -> better.
7, Introduce -doc subpackage according to guidelines , separate files, mark %doc files, exclude gem cache and keep the rakefile:
For main package:
For -doc subpackage:
(In reply to Josef Stribny from comment #2)
> 1, "# I filed a bug on this upstream, but this works around it for now."
> In such cases. please always include the link to the upstream bug.
For reference, the URL was https://github.com/krainboltgreene/time-lord/issues/14
> 2, The package should BuildRequires: ruby(release) for >= f19 and
> BuildRequires: ruby(abi) for < f19
Also, now that F18 is EOL, you can remove this and just use ruby(release).
In addition to the above comments, you can remove the text about kramdown being absent from Fedora (it's present now), and change the URLs to HTTPS.
Bumping out of my bug queue for now as I don't need this anymore.