Bug 979831 - Remove align attribute on image template
Summary: Remove align attribute on image template
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: PressGang CCMS
Classification: Community
Component: Web-UI
Version: 1.1
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: ---
Assignee: pressgang-ccms-dev
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-06-30 23:49 UTC by Matthew Casperson
Modified: 2014-08-04 22:27 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-06-30 23:49:32 UTC


Attachments (Terms of Use)

Description Matthew Casperson 2013-06-30 23:49:07 UTC
From an email discussion between Josh and Rudi:

Hey Josh

There's no standard or guideline of which I'm aware. Books on design, 
layout, and typesetting might be able to provide something if someone's 
motivated to do the research, or a UX designer like Andy might be able 
to point you straight to something useful. What follows is my personal 
opinion only.

If images are left-aligned in LTR text, we would definitely want them to 
be right-aligned in RTL text (which Publican does by default; I just 
verified this with Publican 3.1 in Hebrew) or the output becomes very 
weird indeed.

I would argue against centring images on two grounds:

1. We encode information in the level of indent in our docs. Elements 
that share the same level of left margin share the same level in the 
hierarchy of information that we present. A centred image with an 
effectively random amount of left margin breaks with this model.

2. Images are not necessarily all the same width. Even if we ignore 
point 1 completely, a single centred image, or a number of centred 
images of the same width, doesn't look so bad. If a page contains 
multiple images of different widths, ragged right presents much better 
than centred images of different widths, especially when it's already 
surrounded by text that's set ragged right. If we do consider point 1, 
then the breakage is much, much worse.

To my mind, the question of "why don't we centre images?" really isn't 
very different from "why don't we centre body text?"

Cheers,

Rudi

Comment 1 Matthew Casperson 2013-06-30 23:49:32 UTC
Fixed in build 201307010943


Note You need to log in before you can comment on or make changes to this bug.