Bug 97995 - Bug in tools/rpmsignature
Summary: Bug in tools/rpmsignature
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Raw Hide
Classification: Retired
Component: rpm
Version: 1.0
Hardware: All
OS: Linux
low
high
Target Milestone: ---
Assignee: Jeff Johnson
QA Contact: Mike McLean
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2003-06-25 04:20 UTC by Chris Chabot
Modified: 2005-10-31 22:00 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2003-06-25 17:18:58 UTC
Embargoed:


Attachments (Terms of Use)

Description Chris Chabot 2003-06-25 04:20:12 UTC
in rpmsignature.c it reads
if (rpmReadSignature(fdi, &sig, lead.signature_type, NULL) !=  RPMRC_OK) {
   // do stuff..

but it should be
if (rpmReadSignature(fdi, &sig, lead.signature_type, NULL) !=  RPMRC_OK) {
  exit(1)
}
// do stuff..

Now, if the sig is read in correctly, it exits with exit code 1

Comment 1 Jeff Johnson 2003-06-25 17:18:58 UTC
rpmsignature.c ain't been changed for >5 years, while rpm has.

I'm not sure this is worh fixing, rpm-4.1 and later use a whole
different interface and API; rpmsignature has never been more than
an illustration of a now largely defunct (but still present) API.

See rpm2cpio.sh for an example of how to extract the signature
blob from shell, not hard.


Note You need to log in before you can comment on or make changes to this bug.