Created attachment 767352 [details] alert_notification_email Description of problem: It is possible to add incorrect email in alert Definition Notifications Version-Release number of selected component (if applicable): Version: 4.8.0 Build Number: f21300f How reproducible: always Steps to Reproduce: 1. Log in to Server gui 2. Edit Alert Definition under RHQ Storage/Cassandra Server JVM/ VM Memory Subsystem 3. In Notification/Direct Email add incorrect email "asdf@@@asdf.cz,asdf@@ca.c" Actual results: Alert Definition is saved with incorrect email Expected results: Alert Definition is not saved with incorrect email - red sign is visible asking for correct email format. Additional info: screen-shot attached
From 7/1 BZ triage: Fix via smartgwt or regex check
This is actually validated currently, just not with very strict regexp: <c:regex-constraint expression=".+@[^@, ]+(,.+@[^,@ ]+)?"/> Do we really need stricter email validation here?
I do not think we need "strict" validation but we do need basic validation. From the regex you display here it would seem that "asdf@@@asdf.cz,asdf@@ca.c" would be invalid? If not, it should. The double and triple '@' should have cause a validation error.
Changed in master to use stricter validation: commit 2672ea76be3b94f468fb1ac6d267c2b612ba443b Author: Michael Burman <miburman> Date: Tue Sep 16 15:23:14 2014 +0300 [BZ 980084] Add stricter email validation regexp to alert-email serverplugin. Use the same regexp as with other EmailValidations
Cherry-picked over to release/jon3.3.x commit a719242d1e5155eb907fed844c6be534c3b398d5 Author: Michael Burman <miburman> Date: Tue Sep 16 15:23:14 2014 +0300 [BZ 980084] Add stricter email validation regexp to alert-email serverplugin. Use the same regexp as with other EmailValidations (cherry picked from commit 2672ea76be3b94f468fb1ac6d267c2b612ba443b) Signed-off-by: Thomas Segismont <tsegismo>
Moving to ON_QA as available for test with build: https://brewweb.devel.redhat.com/buildinfo?buildID=388959