Bug 980813 - [Admin Portal] there's twice 'Default OS' value in 'Operating System' selection box
Summary: [Admin Portal] there's twice 'Default OS' value in 'Operating System' selecti...
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine-webadmin-portal
Version: 3.3.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: 3.3.0
Assignee: Roy Golan
QA Contact: Jiri Belka
URL:
Whiteboard: virt
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-07-03 09:55 UTC by Jiri Belka
Modified: 2015-09-22 13:09 UTC (History)
6 users (show)

Fixed In Version: is5
Doc Type: Deprecated Functionality
Doc Text:
REST API Note: OSs with OS type "Unassigned" are now converted to "Other". The value is still supported but is auto converted to "other", both on creation and on import.
Clone Of:
Environment:
Last Closed: 2013-07-19 06:05:34 UTC
oVirt Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 16531 0 None None None Never
oVirt gerrit 16679 0 None None None Never

Description Jiri Belka 2013-07-03 09:55:40 UTC
Description of problem:
there's twice 'Default OS' value in 'Operating System' selection box

it looks like issue when parsing osinfo-defaults.properties

# fgrep os.Unassigned /usr/share/ovirt-engine/conf/osinfo-defaults.properties | sort -t \. -k 2 -V
os.Unassigned.bus.value = 32
os.Unassigned.cpuArchitecture.value = x86
os.Unassigned.devices.audio.value = ich6
os.Unassigned.devices.network.value =  rtl8139, e1000, pv
os.Unassigned.family.value = Other
os.Unassigned.id.value = 0
os.Unassigned.name.value = default OS
os.Unassigned.resources.maximum.ram.value = 64000
os.Unassigned.resources.minimum.disksize.value = 1
os.Unassigned.resources.minimum.numberOsCpus.value = 1
os.Unassigned.resources.minimum.ram.value = 256
os.Unassigned.spiceSupport.value = true
os.Unassigned_64.bus.value = 64
os.Unassigned_64.derivedFrom.value = Unassigned
os.Unassigned_64.id.value = 1000
os.Unassigned_64.resources.minimum.ram.value = 1024
os.Unassigned_64.resources.recommended.ram.value = 2000

so 'Unassigned_64' is useless, as it does not have specific 'name', thus it inherits 'name' from Unassigned. This causes 'Unassinged' to be lottery, which 'Default OS' in VM properties is the one a user wants? :)

Version-Release number of selected component (if applicable):
IS4

How reproducible:
100%

Steps to Reproduce:
1. check VM properties for 'Operating system' values in the list
2. check /usr/share/ovirt-engine/conf/osinfo-defaults.properties
3.

Actual results:
Unassigned_64 does not have name, thus it uses 'Default OS' as Unassigned

Expected results:
second column in osinfo property line should always have 'name' value. it means that if you have os.foo..... then you _MUST_ have os.foo.id.value and os.foo.name.value

Additional info:

Comment 1 Jiri Belka 2013-07-03 11:21:13 UTC
Or maybe better... if os.foobar.... does not have 'name', then do not display it publically in VM properties. Maybe one would like to created his own 'hidden' base property section as a base for later sections which would have 'name'...

Comment 2 Michal Skrivanek 2013-07-04 05:47:19 UTC
the whole "unassigned" is going away soon...

Comment 3 Roy Golan 2013-07-08 06:57:34 UTC
removed unassinged_64.

Comment 6 Michal Skrivanek 2013-08-01 13:01:37 UTC
removal of Unassigned and replacing it by Other merged:
http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=commit;h=0630ce4aa0ee89e22d95f7fa57ee40da437701e7


Note You need to log in before you can comment on or make changes to this bug.