Bug 981892 - Enable build with opengl and openmp
Summary: Enable build with opengl and openmp
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: gabedit
Version: 19
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Dominik 'Rathann' Mierzejewski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-07-06 18:48 UTC by lg
Modified: 2013-11-10 06:33 UTC (History)
2 users (show)

Fixed In Version: gabedit-2.4.7-3.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-11-01 03:56:33 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
pass OpenGL and openmp related flags independently of COMMONCFLAGS (4.12 KB, patch)
2013-07-06 18:48 UTC, lg
no flags Details | Diff
updated gabedit-gtk patch (184.13 KB, patch)
2013-07-06 18:49 UTC, lg
no flags Details | Diff
allow build with -O0 (322 bytes, patch)
2013-07-06 18:50 UTC, lg
no flags Details | Diff
updated versions of gtk and cflags patches for gabedit-2.4.7 (16.27 KB, patch)
2013-08-09 12:22 UTC, lg
no flags Details | Diff

Description lg 2013-07-06 18:48:28 UTC
Created attachment 769721 [details]
pass OpenGL and openmp related flags independently of COMMONCFLAGS

Currently the use of OpenGL (partiallY) and openmp is effectively disabled in spec file. Please build gabedit with -DENABLE_OMP -fopenmp -DDRAWGEOMGL

Benefit to fedora users:
nicer picture in "Draw geometry" window

Affected version:
gabedit-2.4.6-2.fc19

Possible solution:
Flags to enable openmp and OpenGL are passed with COMMONCFLAGS which is overridden by $RPM_OPT_FLAGS in spec file. Either add missing parameters

%{__make} %{?_smp_mflags} COMMONCFLAGS="$RPM_OPT_FLAGS -DENABLE_OMP -fopenmp -DDRAWGEOMGL"

to spec file or apply gabedit-cflags.patch. You also need gabedit-gtk.patch to allow build without -DENABLE_DEPRECATED

Additional info:
With current build of gabedit (gabedit-2.4.6-2.fc19) it is not possible to change bond length or bond angle with "Measure" tool. This bug is not observed with OpenGL-enabled build.

Comment 1 lg 2013-07-06 18:49:31 UTC
Created attachment 769722 [details]
updated gabedit-gtk patch

Comment 2 lg 2013-07-06 18:50:20 UTC
Created attachment 769723 [details]
allow build with -O0

Comment 3 lg 2013-08-09 12:22:25 UTC
Created attachment 784828 [details]
updated versions of gtk and cflags patches for gabedit-2.4.7

Comment 4 Fedora Update System 2013-10-12 11:32:48 UTC
gabedit-2.4.7-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/gabedit-2.4.7-1.fc20

Comment 5 Fedora Update System 2013-10-12 11:33:06 UTC
gabedit-2.4.7-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/gabedit-2.4.7-1.fc19

Comment 6 Fedora Update System 2013-10-13 19:50:24 UTC
Package gabedit-2.4.7-2.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing gabedit-2.4.7-2.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-18960/gabedit-2.4.7-2.fc20
then log in and leave karma (feedback).

Comment 7 Fedora Update System 2013-11-01 03:56:33 UTC
gabedit-2.4.7-3.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2013-11-10 06:33:46 UTC
gabedit-2.4.7-3.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.