Red Hat Bugzilla – Bug 982174
cli crashes when setting diagnostics.client-log-level is set to trace
Last modified: 2014-04-17 07:43:15 EDT
Description of problem: CLI crashes when diagnostics.client-log-level is incorrectly set to 'trace' instead of 'TRACE' How reproducible: Always Steps to Reproduce: 1. gluster volume set <volname> diagnostics.client-log-level trace Actual results: segfault Expected results: The message: "volume set: failed: option log-level trace: 'trace' is not valid(possible options are DEBUG, WARNING, ERROR, INFO, CRITICAL, NONE, TRACE.)"
REVIEW: http://review.gluster.org/5298 (cli: check for null in is_server_debug_xlator()) posted (#1) for review on master by Ravishankar N (ravishankar@redhat.com)
REVIEW: http://review.gluster.org/5298 (cli: check for null in is_server_debug_xlator()) posted (#2) for review on master by Ravishankar N (ravishankar@redhat.com)
REVIEW: http://review.gluster.org/5298 (cli: check for null in is_server_debug_xlator()) posted (#3) for review on master by Ravishankar N (ravishankar@redhat.com)
COMMIT: http://review.gluster.org/5298 committed in master by Vijay Bellur (vbellur@redhat.com) ------ commit 07833f13d43a3e3532171bb2edbe068e3a7205b1 Author: Ravishankar N <ravishankar@redhat.com> Date: Mon Jul 8 15:45:54 2013 +0530 cli: check for null in is_server_debug_xlator() Command: gluster volume set <volname> diagnostics.client-log-level trace Expected output: "volume set: failed: option log-level trace: 'trace' is not valid (possible options are DEBUG, WARNING, ERROR, INFO, CRITICAL, NONE, TRACE.)" Current output: gluster cli receives a segmentation fault Fix: check for NULL before calling strstr Change-Id: If4c7a85a635849a388cf122543e12349c109643c BUG: 982174 Signed-off-by: Ravishankar N <ravishankar@redhat.com> Reviewed-on: http://review.gluster.org/5298 Reviewed-by: Kaushal M <kaushal@redhat.com> Tested-by: Gluster Build System <jenkins@build.gluster.com>
REVIEW: http://review.gluster.org/5814 (cli: check for null in is_server_debug_xlator()) posted (#1) for review on release-3.4 by Vijay Bellur (vbellur@redhat.com)
REVIEW: http://review.gluster.org/5814 (cli: check for null in is_server_debug_xlator()) posted (#2) for review on release-3.4 by Vijay Bellur (vbellur@redhat.com)
REVIEW: http://review.gluster.org/5814 (cli: check for null in is_server_debug_xlator()) posted (#3) for review on release-3.4 by Vijay Bellur (vbellur@redhat.com)
REVIEW: http://review.gluster.org/5814 (cli: check for null in is_server_debug_xlator()) posted (#4) for review on release-3.4 by Vijay Bellur (vbellur@redhat.com)
REVIEW: http://review.gluster.org/5814 (cli: check for null in is_server_debug_xlator()) posted (#5) for review on release-3.4 by Vijay Bellur (vbellur@redhat.com)
COMMIT: http://review.gluster.org/5814 committed in release-3.4 by Anand Avati (avati@redhat.com) ------ commit f7f12d1fc644e400eec58944a24c7f7b16f41530 Author: Ravishankar N <ravishankar@redhat.com> Date: Mon Jul 8 15:45:54 2013 +0530 cli: check for null in is_server_debug_xlator() Command: gluster volume set <volname> diagnostics.client-log-level trace Expected output: "volume set: failed: option log-level trace: 'trace' is not valid (possible options are DEBUG, WARNING, ERROR, INFO, CRITICAL, NONE, TRACE.)" Current output: gluster cli receives a segmentation fault Fix: check for NULL before calling strstr Change-Id: If4c7a85a635849a388cf122543e12349c109643c BUG: 982174 Signed-off-by: Ravishankar N <ravishankar@redhat.com> Reviewed-on: http://review.gluster.org/5298 Reviewed-by: Kaushal M <kaushal@redhat.com> Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-on: http://review.gluster.org/5814 Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com> Reviewed-by: Anand Avati <avati@redhat.com>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.0, please reopen this bug report. glusterfs-3.5.0 has been announced on the Gluster Developers mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/6137 [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user