Bug 982302 - Review Request: mod_xslt - Dynamic xsl transformations for apache
Summary: Review Request: mod_xslt - Dynamic xsl transformations for apache
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2013-07-08 15:38 UTC by Christopher Meng
Modified: 2021-05-23 00:45 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-05-23 00:45:19 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Christopher Meng 2013-07-08 15:38:39 UTC
Spec URL: http://cicku.me/mod_xslt.spec
SRPM URL: http://cicku.me/mod_xslt-1.4.3-1.fc20.src.rpm
Description: mod-xslt is a server side module able to transform xml documents by applying xsl stylesheets on the fly.

It can:

- Transform dynamically generated xml, like the output of perl, php or 
cgi scripts.
- Allows you to specify which xsl stylesheet to use based on <?xml-stylesheet 
statements.
- Provides many extension to access client headers, GET parameters, 
regular expressions, build local URLs or to choose a different stylesheet 
based on any of those paramters.
- Fetch stylesheets or external entities from other dynamic pages, http or ftp 
urls if you are so inclined.
- Manipulate returned headers from the xsl stylesheet, and set the mime 
type of the transformation result.
- Parse external DTDs and use the defaults provided.
- Provide a set of standard compliant functions allowing you to keep your xsl 
or xml files compatible with any other xsl processor, even when using 
mod-xslt enhanced features.

Fedora Account System Username: cicku

Comment 1 Juan Orti 2013-07-10 06:52:23 UTC
You miss pcre-devel in BuildRequires

It fails to build to me in mock:

../../../lib/parser/modxslt-screen-expr.parser.c: In function 'mxslt_expr_yy_parse':
../../../lib/parser/modxslt-screen-expr.parser.c:1403:7: error: too few arguments to function 'mxslt_expr_yy_lex'
../../../lib/parser/modxslt-screen-expr.y:29:12: note: declared here
../../../lib/parser/modxslt-screen-expr.y:33:59: error: 'scanner' undeclared (first use in this function)
../../../lib/parser/modxslt-screen-expr.y:77:7: note: in expansion of macro 'mxslt_yy_accept'
../../../lib/parser/modxslt-screen-expr.y:33:59: note: each undeclared identifier is reported only once for each function it appears in
../../../lib/parser/modxslt-screen-expr.y:77:7: note: in expansion of macro 'mxslt_yy_accept'
make[1]: *** [parser/modxslt-screen-expr.parser.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make[2]: Leaving directory `/builddir/build/BUILD/mod-xslt-1.4.3/lib/parser'
make[1]: Leaving directory `/builddir/build/BUILD/mod-xslt-1.4.3/lib'
make: *** [library] Error 2

Comment 2 Christopher Meng 2013-07-10 09:48:36 UTC
Can you tell me your Fedora version?

I can ensure this can be built on Rawhide machine.

Comment 3 Juan Orti 2013-07-10 11:26:47 UTC
I'm working in Fedora 19 and do
$ mock -r fedora-rawhide-x86_64 mod_xslt-1.4.3-1.fc20.src.rpm

Comment 4 Christopher Meng 2013-07-16 00:33:58 UTC
Hi,

Are you still meeting this problem after adding pcre-devel?

In order to make your life easier, I've uploaded a new spec with pcre-devel added.

If you still have problem with this revision, please paste the full log.

I'm confused also...

Spec URL: http://cicku.me/mod_xslt.spec
SRPM URL: http://cicku.me/mod_xslt-1.4.3-2.fc20.src.rpm

Comment 5 Juan Orti 2013-07-16 07:00:38 UTC
I've catched the issue, the Makefile has problems with parallelization, compiling with "make -j 1" works ok.

rpmlint warns about some problems that worry me:
mod_xslt.x86_64: W: unstripped-binary-or-object /usr/lib64/libmodxslt1.so.1.0.0
mod_xslt.x86_64: W: shared-lib-calls-exit /usr/lib64/libmodxslt1.so.1.0.0 exit.5
mod_xslt.x86_64: W: unstripped-binary-or-object /usr/lib64/httpd/modules/mod_xslt.so
mod_xslt.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/httpd/modules/mod_xslt.so ['/usr/lib64']
mod_xslt-devel.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/modxslt-parse ['/usr/lib64']

Also, in the %description, you have a typo, in the third bullet: paramters -> parameters.

Take a look at the rpmlint problems to see what can be done. I'm also going to investigate them.

Comment 6 Package Review 2021-04-23 00:45:18 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 7 Package Review 2021-05-23 00:45:19 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.


Note You need to log in before you can comment on or make changes to this bug.