Description of problem:
After running packstack (from commit feef9b09f1) the quantum-openvswitch-agent.service doesn't start and the quantum dhcp_agent reports errors in /var/log/messages.

Both of these are due to sudo errors.

Version-Release number of selected component (if applicable):
openstack-packstack feef9b09f1

How reproducible:
Always

Steps to Reproduce:
1. Install f19 @core
2. git clone --recursive https://github.com/stackforge/packstack.git
3. cd packstack
4. git checkout feef9b09f1
5. (apply patches to make packstack use mariadb)
6. ./bin/packstack --allinone

Actual results:
Packstack completes, but the quantum-openvswitch-agent.service doesn't start and shows errors in /var/log/messages relating to sudo configuration. Later, the dhcp agent shows errors. 

I believe this is because the OVS plugin configuration (/etc/quantum/plugins/openvswitch/ovs_quantum_plugin.ini) in the AGENT section, and the dhcpd agent configuratoin (/etc/quantum/dhcp_agent.ini) in the DEFAULT section are missing "root_helper" definitions.

The sudo errors look like this:
Jul  5 12:31:45 cas01 quantum-ovs-cleanup[4759]: Command: ['sudo', 'ovs-vsctl', '--timeout=2', 'list-br']
Jul  5 12:31:45 cas01 quantum-ovs-cleanup[4759]: Exit code: 1

Jul  8 12:40:58 cas01 quantum-dhcp-agent[1387]: Command: ['sudo', 'ip', 'netns', 'exec', 'qdhcp-96c697b8-58b4-4f87-b13d-b8df001ef51d', 'quantum-ns-metadata-proxy', '--pid_file=/var/lib/quantum/external/pids/96c697b8-58b4-4f87-b13d-b8df001ef51d.pid', '--network_id=96c697b8-58b4-4f87-b13d-b8df001ef51d', '--state_path=/var/lib/quantum', '--metadata_port=80', '--verbose', '--log-file=quantum-ns-metadata-proxy96c697b8-58b4-4f87-b13d-b8df001ef51d.log', '--log-dir=/var/log/quantum']
Jul  8 12:40:58 cas01 quantum-dhcp-agent[1387]: Exit code: 1

Expected results:
There should be no sudo related errors and the OVS agent should start correctly.

Additional info:
Applying the following patches corrects the configuration:

--- a/manifests/agents/dhcp.pp
+++ b/manifests/agents/dhcp.pp
@@ -41,7 +41,8 @@ class quantum::agents::dhcp (
   $resync_interval  = 30,
   $interface_driver = 'quantum.agent.linux.interface.OVSInterfaceDriver',
   $dhcp_driver      = 'quantum.agent.linux.dhcp.Dnsmasq',
-  $use_namespaces   = true
+  $use_namespaces   = true,
+  $root_helper      = 'sudo /usr/bin/quantum-rootwrap /etc/quantum/rootwrap.conf'
 ) {
 
   include quantum::params
@@ -72,6 +73,7 @@ class quantum::agents::dhcp (
     'DEFAULT/interface_driver':   value => $interface_driver;
     'DEFAULT/dhcp_driver':        value => $dhcp_driver;
     'DEFAULT/use_namespaces':     value => $use_namespaces;
+    'DEFAULT/root_helper':        value => $root_helper;
   }
 
   if $::quantum::params::dhcp_agent_package {


index 1329fe2..343cd64 100644
--- a/manifests/plugins/ovs.pp
+++ b/manifests/plugins/ovs.pp
@@ -14,7 +14,8 @@ class quantum::plugins::ovs (
   # because the list of networks there is still important
   # even if the ranges aren't specified
   $network_vlan_ranges  = 'physnet1:1000:2000',
-  $tunnel_id_ranges     = '1:1000'
+  $tunnel_id_ranges     = '1:1000',
+  $root_helper          = 'sudo /usr/bin/quantum-rootwrap /etc/quantum/rootwrap.conf'
 ) {
 
   include 'quantum::params'
@@ -52,6 +53,7 @@ class quantum::plugins::ovs (
     'DATABASE/sql_max_retries':     value => $sql_max_retries;
     'DATABASE/reconnect_interval':  value => $reconnect_interval;
     'OVS/tenant_network_type':      value => $tenant_network_type;
+    'AGENT/root_helper':            value => $root_helper;
   }
 
   if($tenant_network_type == 'gre') {

I don't know if more root_helper's are needed for the other quantum agents. It would be preferable to refactor the common $root_helper into a class parameter, but I don't understand well enough how the module works to suggest an alternative.