Bug 982424 - newer libxml2 eating white space in spec files
Summary: newer libxml2 eating white space in spec files
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Publican
Classification: Community
Component: publican
Version: 3.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: 3.2
Assignee: Ruediger Landmann
QA Contact: tools-bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-07-09 02:09 UTC by Stephen Gordon
Modified: 2013-08-09 04:49 UTC (History)
6 users (show)

Fixed In Version: 3.2.0
Clone Of:
Environment:
Last Closed: 2013-08-09 04:49:12 UTC
Embargoed:


Attachments (Terms of Use)
screenshot of docs-devel (43.13 KB, image/png)
2013-07-29 06:49 UTC, Tim Hildred
no flags Details

Description Stephen Gordon 2013-07-09 02:09:21 UTC
Description of problem:

I have a book that has brackets in the title (long story) so the title is currently:

Deployment Guide (Foreman Technical Preview)

This is a relatively temporary situation but I digress. Like all other books for this product it also has a web_version_label set in publican.cfg. I found that in terms of the package name the brackets were escaped/ignored as I would expect:

Red_Hat_OpenStack-Deployment_Guide_Foreman_Technical_Preview-3-web-en-US

When I had the package installed on a Publican run website however the entry that appeared on the splash page for this product was:

Deployment Guide (Foreman Technical Preview)--version label=Red Hat OpenStack 3.0 (Grizzly)

The version label is the result of the web_version_label I have set in publican.cfg, but obviously it is being included in the name label for some reason.

On looking in the spec file I found that for some reason there was no space between the value of name_label and the version_label parameter:

--name_label="Deployment_Guide_(Foreman_Technical_Preview)"--version_label="Red Hat OpenStack 3.0 (Grizzly)"

Note that all other guides for this product use the same web_version_label, this issue seems to be specific to the combination of it with this name_label.

As a workaround I am manually injecting the space and rebuilding the RPM.

Version-Release number of selected component (if applicable):

publican-3.1.5-0.fc18.noarch

Comment 8 Ruediger Landmann 2013-07-12 00:59:10 UTC
Taking this one because I need to patch this in recent Fedora

Comment 9 Ruediger Landmann 2013-07-12 01:22:07 UTC
84346f5..ae48e28  devel -> devel

Added some whitespace to web-spec.xsl per comment 6 to work around this issue

Comment 10 HSS Product Manager 2013-07-16 03:47:35 UTC
HSS-QE has reviewed and declined this request. QE for this bug will be handled by IED.

Comment 11 Tim Hildred 2013-07-23 10:25:46 UTC
I think testing this fix involves:

- Setting up a publican site [1]
- adding brackets to the name of a book in the web_version_label parameter of publican.cfg
- packaging the book with publican package
- installing the book package on your publican site.

[1]http://jfearn.fedorapeople.org/en-US/Publican/2.6/html-single/Users_Guide/index.html#sect-Users_Guide-Website

I don't mind picking this up again tomorrow morning it is too late to start tonight.

So, if someone beats me to it, I will not be too upset. But if you do pick it up, please leave a comment or ping me.

Comment 13 Tim Hildred 2013-07-29 06:48:57 UTC
I staged a book (the RHEV User Portal Guide) with an addition to the publican.cfg:

web_version_label: User (Portal Guide)


I've attached a screenshot of what happened to the stage, which Rudi assures me means that the bug is fixed.

Comment 14 Tim Hildred 2013-07-29 06:49:44 UTC
Created attachment 779652 [details]
screenshot of docs-devel

Comment 15 Jeff Fearn 🐞 2013-08-09 04:49:12 UTC
The fix for this bug has been shipped in publican 3.2.0


Note You need to log in before you can comment on or make changes to this bug.