Red Hat Bugzilla – Bug 983019
[RFE] add support for disabling spice agent based file transfer support
Last modified: 2016-03-09 15:31:45 EST
Starting with RHEL-6.5 spice-vdagent & virt-viewer, spice has agent based file transfer support. In some environments there might be a desire to turn this off.
In order to facilitate this qemu in RHEL-6.5 will have a new -spice option called disable-agent-file-xfer, see bug 961850. Adding support for this new qemu option to libvirt is tracked in bug 983018.
This bug is for tracking adding support for this to RHEV-M.
libvirt still lacks support for this option. Patch for libvirt posted on libvir-list on January, 2 and under review; should be merged in libvirt 1.2.2.
Hi I wasn't able to verify this RFE on:
1. create vm
2. start vm with "Enable SPICE file transfer" checked to test sanity.
3. in vdsm.log under VM.create didn't see fileTransferEnable=false parameter as expeceted.
4. stoped vm.
5. edited vm and unchecked "Enable SPICE file transfer" to disable file transfer.
6. start vm.
under VM.create parameter or when dumping the libvirt xml for the vm couldn't see the fileTransferEnable=false as expected.
Probably broken by https://gerrit.ovirt.org/#/c/30837/
@Francesco: indeed - the problem is in VmInfoBuilderBase does not check if the SPICE device is there but if there are graphics infos (e.g. for infos about IP, port etc) which is available only after VM starts. And that is too late since we are just about to start the VM. Preparing a patch for it.
(In reply to Tomas Jelinek from comment #13)
> @Francesco: indeed - the problem is in VmInfoBuilderBase does not check if
> the SPICE device is there but if there are graphics infos (e.g. for infos
> about IP, port etc) which is available only after VM starts. And that is too
> late since we are just about to start the VM. Preparing a patch for it.
Thanks a lot Tomas! I was out of date with the last changes, and I was about to ask some advice, but you were faster :)
Failed to verify with 3.6.0-4:
same flow as in comment 11. after unchecking file transfer in vm->console menu, restarting the vm, drag and drop file worked.
attaching a tar with engine + vdsm log and vm's dumpxml after disabling file transfer.
Created attachment 1057563 [details]
engine + vdsm logs and vm dumpxml
(In reply to sefi litmanovich from comment #16)
> Failed to verify with 3.6.0-4:
> same flow as in comment 11. after unchecking file transfer in vm->console
> menu, restarting the vm, drag and drop file worked.
> attaching a tar with engine + vdsm log and vm's dumpxml after disabling file
Thanks for finding this out! The problem here is that Engine is sending per-vm options, while VDSM is expecting the parameters inside the devices specParams.
To put it differently,
VDSM works the new way, Engine works the old way. Patch is ongoing.
fix 44815 merged on 3.6 branch
Verified with rhevm-188.8.131.52-0.1.el6.noarch according to steps in comment 11 and test plan attached in tracker.
See test run to review:
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.