Created attachment 772254 [details] Commits in GIT - screenshot Description of problem: New feature 'Auto Save' generates new commit every 30 seconds, even if process does not change. Version-Release number of selected component (if applicable): 6.0.0 DR6 How reproducible: Steps to Reproduce: 2. create a process (in jbpm-playground) 3. enable auto save 4. after some time checkout the git repository git clone EAP6/jboss-eap-6.1/bin/.niogit/jbpm-playground.git/ 5. open gitk for this repository Actual results: Attached picture. Expected results: Auto save check if there is some new changes and than save the process. Imagine that user interrupts his work for a long time (some meetings, calls etc.) but process is still open. There is so many amount of commits, which are useless. Additional info: Screenshot shows that file is changed, but if you take a better look, you can see that there is only one change - all IDs. Maybe if IDs stay same, then the git does not generates commits so offen.
This has been fixed to save only if there were changes to the process. Note that even clicking on the canvas can trigger a re-save as as possible change (any onmouse-out does).
Verified that if I am not working with designer, 'save' method is not invoked. Tiho is really necessarily to change the ID of each XML element every time if an user click on canvas? (see attached commit, which was generated as reaction of click on canvas) I think that if you save process with the same sequence of characters (use same ID) then there is nothing to commit. This fact leads to implication: if there is nothing to commit then the file does not contain any change. So you can use git repository to determinate changes: - operation save: -> save actual BPMN2 code (do not change IDs) -> commit the changes - operation close the editor: -> save actual BPMN2 code (do not change IDs) -> if there is nothing to commit then just close the editor -> if there are some changes to commit then you ask the user for action "Save (Commit) changes" or "Discard changes" Tiho: - is too hard to use old ID for XML element? - is this algorith applicable?
Created attachment 799345 [details] Commit in GIT after click on canvas
Tiho and what about changing properties? Step to reproduce: ------------------ 1. enable autosave 2. create a process Start->UserTask->EndTask 3. wait until alert "saved" is appear 4. modify properties of UserTask: - name - task name - data assignment - on-entry script - actors - etc. 5. Without clicking into canvas, close process 6. Reopen process Actual results -------------- User task has empty properties. Expected results ---------------- Properties are very important parts of BPMN2 process. They should be saved by autosave as well as flow elements.
Auto-save only saves when there were no modifications made to the process. Note that even clicking on the canvas is considered a modification (user could have changed properties). As far as the node IDs is concerned, nodes IDs are generated on each save (have to be unique). This is necessary to maintain the unique id requirement.
Please consider this situation for saving properties: - an user works on process, the auto save is enabled - an user activates a node - the auto save saves a process - an user change a name of element - an user close a process So an activation of node is done a few seconds before auto-save. Another autosave is not called because an user has closed the process. Between autosave and closing the process is done only one action -> Change a property. I understand that an user can see that process was saved (alert is present) and he can activate a node again to be sure that a property will be saved. I just show a risk of this solution (the limit situation). Tiho, can you reproduce this issue?
Please consider these facts about IDs: - if no element is added then the IDs are still unique. -> So why you generate these unique IDs again? - if some element is added then you need just one unique ID. -> Is it so hard to choose one unique ID?
I have updated designer to set the "dirty" flag on any property changes. I think for the ID issue we could discuss that in another BZ? WDYT?
Thank you, I agree with comment #11.
I verified for ER5 that changes in nodes (click on canvas) and properties (change in any property) are saved by autosave and if there are no changes then operation save is not called.