Bug 984227 - libnl-1 is deprecated, iw should be linked with libnl3
Summary: libnl-1 is deprecated, iw should be linked with libnl3
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: iw
Version: 20
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Adel Gadllah
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 984226
TreeView+ depends on / blocked
 
Reported: 2013-07-13 19:48 UTC by Account closed by the user
Modified: 2013-11-09 20:30 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-11-09 20:21:49 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
dates+nl3 (2.26 KB, patch)
2013-07-13 19:50 UTC, Account closed by the user
b38617: review-
Details | Diff
dates+nl3 (2.80 KB, patch)
2013-07-17 22:49 UTC, Account closed by the user
no flags Details | Diff

Description Account closed by the user 2013-07-13 19:48:05 UTC
It builds fine with libnl3.

Comment 1 Account closed by the user 2013-07-13 19:50:54 UTC
Created attachment 773149 [details]
dates+nl3

- fix wrong dates
- link with libnl3

Comment 2 Account closed by the user 2013-07-13 19:57:53 UTC
(In reply to Xose Vazquez Perez from comment #1)

> - link with libnl3

Something weird is happening, building from tar.gz source with libnl3 is fine.

But the rpmbuild environment is unable to find libnl3:


$ rpmbuild -ba iw.spec
Executing(%prep): /bin/sh -e /home/xose/rpmbuild/tmp/rpm-tmp.JXnfi3
+ umask 022
+ cd /home/xose/rpmbuild/BUILD
+ cd /home/xose/rpmbuild/BUILD
+ rm -rf iw-3.10
+ /usr/bin/xz -dc /home/xose/rpmbuild/SOURCES/iw-3.10/iw-3.10.tar.xz
+ /usr/bin/tar -xf -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd iw-3.10
+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ exit 0
Executing(%build): /bin/sh -e /home/xose/rpmbuild/tmp/rpm-tmp.NZJtgp
+ umask 022
+ cd /home/xose/rpmbuild/BUILD
+ cd iw-3.10
+ make -j 4 'CFLAGS=-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -grecord-gcc-switches  -m64 -mtune=generic'
 CC   iw.o
 CC   genl.o
 CC   event.o
 CC   info.o
genl.c:6:31: fatal error: netlink/genl/genl.h: No such file or directory
 #include <netlink/genl/genl.h>
                               ^
compilation terminated.
In file included from event.c:5:0:
iw.h:5:29: fatal error: netlink/netlink.h: No such file or directory
 #include <netlink/netlink.h>
                             ^
compilation terminated.
info.c:5:31: fatal error: netlink/genl/genl.h: No such file or directory
 #include <netlink/genl/genl.h>
                               ^
compilation terminated.
make: *** [genl.o] Error 1
make: *** Waiting for unfinished jobs....
iw.c:17:31: fatal error: netlink/genl/genl.h: No such file or directory
 #include <netlink/genl/genl.h>
                               ^
compilation terminated.
make: *** [info.o] Error 1
make: *** [event.o] Error 1
make: *** [iw.o] Error 1
error: Bad exit status from /home/xose/rpmbuild/tmp/rpm-tmp.NZJtgp (%build)


RPM build errors:
    Bad exit status from /home/xose/rpmbuild/tmp/rpm-tmp.NZJtgp (%build)
---end---


$ cat /home/xose/rpmbuild/tmp/rpm-tmp.NZJtgp
#!/bin/sh

  RPM_SOURCE_DIR="/home/xose/rpmbuild/SOURCES/iw-3.10"
  RPM_BUILD_DIR="/home/xose/rpmbuild/BUILD"
  RPM_OPT_FLAGS="-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -grecord-gcc-switches  -m64 -mtune=generic"
  RPM_LD_FLAGS="-Wl,-z,relro "
  RPM_ARCH="x86_64"
  RPM_OS="linux"
  export RPM_SOURCE_DIR RPM_BUILD_DIR RPM_OPT_FLAGS RPM_LD_FLAGS RPM_ARCH RPM_OS
  RPM_DOC_DIR="/usr/share/doc"
  export RPM_DOC_DIR
  RPM_PACKAGE_NAME="iw"
  RPM_PACKAGE_VERSION="3.10"
  RPM_PACKAGE_RELEASE="2.fc19"
  export RPM_PACKAGE_NAME RPM_PACKAGE_VERSION RPM_PACKAGE_RELEASE
  LANG=C
  export LANG
  unset CDPATH DISPLAY ||:
  RPM_BUILD_ROOT="/home/xose/rpmbuild/BUILDROOT/iw-3.10-2.fc19.x86_64"
  export RPM_BUILD_ROOT
  
  PKG_CONFIG_PATH="%{_PKG_CONFIG_PATH}:/usr/lib64/pkgconfig:/usr/share/pkgconfig"
  export PKG_CONFIG_PATH
  
  set -x
  umask 022
  cd "/home/xose/rpmbuild/BUILD"
cd 'iw-3.10'
make -j 4 CFLAGS="$RPM_OPT_FLAGS"

exit 0
---end---

Comment 3 Account closed by the user 2013-07-17 22:49:55 UTC
Created attachment 775011 [details]
dates+nl3

Comment 4 Account closed by the user 2013-07-17 22:53:19 UTC
Now it was built fine.

Comment 5 Fedora End Of Life 2013-09-16 14:30:37 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 20 development cycle.
Changing version to '20'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora20

Comment 6 Account closed by the user 2013-11-06 22:14:11 UTC
ping !

Comment 7 Adel Gadllah 2013-11-06 22:18:45 UTC
(In reply to Xose Vazquez Perez from comment #6)
> ping !

Sorry completely forgot about it, will have a look this weekend. Thanks for the ping.

Comment 8 Adel Gadllah 2013-11-09 18:57:18 UTC
Does not build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6158067

Comment 9 Account closed by the user 2013-11-09 19:06:21 UTC
(In reply to Adel Gadllah from comment #8)
> Does not build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6158067

I looks like you did not apply the patch [1]:
http://koji.fedoraproject.org/koji/getfile?taskID=6158078&name=build.log&offset=-4000

[1] https://bugzilla.redhat.com/attachment.cgi?id=775011

Comment 10 Account closed by the user 2013-11-09 19:09:56 UTC
You did apply only half of it.

It is broke because this is missing:

-make %{?_smp_mflags} CFLAGS="$RPM_OPT_FLAGS"
+export CFLAGS="$RPM_OPT_FLAGS"
+make %{?_smp_mflags} 

Apply the _full_ patch.

Comment 11 Adel Gadllah 2013-11-09 20:21:49 UTC
(In reply to Xose Vazquez Perez from comment #10)
> You did apply only half of it.
> 
> It is broke because this is missing:
> 
> -make %{?_smp_mflags} CFLAGS="$RPM_OPT_FLAGS"
> +export CFLAGS="$RPM_OPT_FLAGS"
> +make %{?_smp_mflags} 

Oh I have (wrongly) though that this was an unrelated change. Built fine in rawhide now. Is there any urgency to get this into released versions? libnl1 isn't going away there so it is probably not worth doing an update.

Comment 12 Account closed by the user 2013-11-09 20:30:11 UTC
(In reply to Adel Gadllah from comment #11)

> rawhide now. Is there any urgency to get this into released versions? libnl1
> isn't going away there so it is probably not worth doing an update.

No, there is nothing urgent.

FYI, 3.11 was released time ago. see bug 890399 .

thanks.


Note You need to log in before you can comment on or make changes to this bug.