Bug 985204 - Socket not closed when web executor drops task
Summary: Socket not closed when web executor drops task
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Enterprise Application Platform 6
Classification: JBoss
Component: Other
Version: 6.1.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: EAP 6.2.0
Assignee: Jason Greene
QA Contact:
URL:
Whiteboard:
Depends On: 994281
Blocks: 1001872
TreeView+ depends on / blocked
 
Reported: 2013-07-17 05:48 UTC by James Livingston
Modified: 2018-12-03 19:20 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
This release of JBoss EAP corrects a bug which caused web connector sockets to not be closed properly when tasks were dropped by the executor. The cause was traced to the *QueueExecutor* class not throwing a *RejectedExecutionException* when there was no *handoffExecutor* set (as *QueuelessExecutor* does). In these cases the task would be dropped, which was not the expected behavior. The *QueueExecutor* class has been updated to throw the required exception when a task cannot be added to the queue and, as a result, sockets are now closed correctly.
Clone Of:
: 1001872 (view as bug list)
Environment:
Last Closed: 2014-01-21 02:06:42 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker JBTHR-24 0 Major Resolved QueueExecutor does not throw RejectedExecutionException when dropping task 2016-06-14 13:00:27 UTC

Description James Livingston 2013-07-17 05:48:22 UTC
When org.apache.tomcat.util.net.JIoEndpoint catches Throwable and write a log message, it does not do anything with the Socket. This means it will be left open until the client times out and closes the connection.


This causes problems when non-blocking thread pools are used by the web container, since a RejectedExecutionException is thrown.

Comment 1 James Livingston 2013-07-22 01:00:14 UTC
This is actually caused by QueueExecutor not emitting RejectedExecutionExceptions when there is no handoff executor, but QueuelessExecutor doing so.

Comment 2 JBoss JIRA Server 2013-07-25 03:58:25 UTC
James Livingston <jlivings> updated the status of jira JBTHR-24 to Coding In Progress

Comment 3 JBoss JIRA Server 2013-08-05 16:22:29 UTC
David Lloyd <david.lloyd> updated the status of jira JBTHR-24 to Resolved

Comment 4 JBoss JIRA Server 2013-08-05 16:22:29 UTC
David Lloyd <david.lloyd> made a comment on jira JBTHR-24

Merged, thanks.

Comment 8 Scott Mumford 2013-11-21 00:41:46 UTC
Reformatted supplied Doc Text (thanks James) and marked for inclusion in the 6.2 Release Notes.

Comment 9 James Livingston 2014-01-21 02:06:42 UTC
This was fixed in EAP 6.2, by the component upgrade of bug 994281, and is in the release notes. It must have accidentally not been closed.


Note You need to log in before you can comment on or make changes to this bug.