Bug 985204 – Socket not closed when web executor drops task

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 985204 - Socket not closed when web executor drops task

Summary:	Socket not closed when web executor drops task

Status:	CLOSED CURRENTRELEASE

Aliases:	None

Product:	JBoss Enterprise Application Platform 6
Classification:	JBoss
Component:	Other (Show other bugs)
Sub Component:
Version:	6.1.0
Hardware:	Unspecified Unspecified

Priority	unspecified Severity unspecified
Target Milestone:	---
Target Release:	EAP 6.2.0
Assigned To:	Jason Greene
QA Contact:
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:	994281
Blocks:	1001872
	Show dependency tree / graph

Reported:	2013-07-17 01:48 EDT by James Livingston
Modified:	2016-02-21 19:56 EST (History)
CC List:	3 users (show)

See Also:
Fixed In Version:
Doc Type:	Bug Fix
Doc Text:	This release of JBoss EAP corrects a bug which caused web connector sockets to not be closed properly when tasks were dropped by the executor. The cause was traced to the QueueExecutor class not throwing a RejectedExecutionException when there was no handoffExecutor set (as QueuelessExecutor does). In these cases the task would be dropped, which was not the expected behavior. The QueueExecutor class has been updated to throw the required exception when a task cannot be added to the queue and, as a result, sockets are now closed correctly.
Story Points:	---
Clone Of:
Clones:	1001872 (view as bug list)
Environment:
Last Closed:	2014-01-20 21:06:42 EST
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
JBoss Issue Tracker	JBTHR-24	Major	Resolved	QueueExecutor does not throw RejectedExecutionException when dropping task	2016-06-14 09:00 EDT

Groups: None (edit)

Description James Livingston 2013-07-17 01:48:22 EDT

When org.apache.tomcat.util.net.JIoEndpoint catches Throwable and write a log message, it does not do anything with the Socket. This means it will be left open until the client times out and closes the connection.


This causes problems when non-blocking thread pools are used by the web container, since a RejectedExecutionException is thrown.

Comment 1 James Livingston 2013-07-21 21:00:14 EDT

This is actually caused by QueueExecutor not emitting RejectedExecutionExceptions when there is no handoff executor, but QueuelessExecutor doing so.

Comment 2 JBoss JIRA Server 2013-07-24 23:58:25 EDT

James Livingston <jlivings@redhat.com> updated the status of jira JBTHR-24 to Coding In Progress

Comment 3 JBoss JIRA Server 2013-08-05 12:22:29 EDT

David Lloyd <david.lloyd@redhat.com> updated the status of jira JBTHR-24 to Resolved

Comment 4 JBoss JIRA Server 2013-08-05 12:22:29 EDT

David Lloyd <david.lloyd@redhat.com> made a comment on jira JBTHR-24

Merged, thanks.

Comment 8 Scott Mumford 2013-11-20 19:41:46 EST

Reformatted supplied Doc Text (thanks James) and marked for inclusion in the 6.2 Release Notes.

Comment 9 James Livingston 2014-01-20 21:06:42 EST

This was fixed in EAP 6.2, by the component upgrade of bug 994281, and is in the release notes. It must have accidentally not been closed.

Note You need to log in before you can comment on or make changes to this bug.