Red Hat Bugzilla – Bug 985294
python-meh Python 3 compatibility
Last modified: 2015-01-21 09:26:17 EST
is there any plan/estimate of making python-meh compatible with Python 3? I'm currently trying to figure out what it'd take to move Fedora to Python 3 and since python-meh is one of Anaconda's deps, it'd need to be converted as one of the first.
(In reply to Bohuslav "Slavek" Kabrda from comment #0)
> is there any plan/estimate of making python-meh compatible with Python 3?
> I'm currently trying to figure out what it'd take to move Fedora to Python 3
> and since python-meh is one of Anaconda's deps, it'd need to be converted as
> one of the first.
I think it shouldn't be a big problem, I believe vast majority of work could by done by 2to3 or something like that. My brief testing shows it's mainly about changing print statements to function calls etc.
This bug appears to have been reported against 'rawhide' during the Fedora 20 development cycle.
Changing version to '20'.
More information and reason for this action is here:
How are we standing with this?
If you need any extra hand with this, feel free to use me :)
(In reply to Miro Hrončok from comment #3)
> How are we standing with this?
> If you need any extra hand with this, feel free to use me :)
Sorry, but this is not a priority now. Feel free to send patches. Either to me or (preferably) to email@example.com (use git send-email and prefix the cover letter with [python-meh]).
The sources are available at:
Sent a patch to Anaconda Patches List.
Python 3 compatible python-meh built for rawhide.
Actually, I see no python3-meh subpackage in koji/rawhide, could you explain why this is closed?
(In reply to Miro Hrončok from comment #8)
> Actually, I see no python3-meh subpackage in koji/rawhide, could you explain
> why this is closed?
I had no idea we need two packages with the same content.
Based on our IRC talk, I'll prepare the Python 3 subpackage.
Created attachment 964135 [details]
Patch for upstream git to allow python3 subpackages
Patch attached for spec and Makefile in the upstream repo (i.e. not fedpkg).
It should work, but apparently, there is still something not Python3 compatible.
Bytecompiling .py files below /home/churchyard/rpmbuild/BUILDROOT/python-meh-0.32-2.fc22.x86_64/usr/lib/python3.3 using /usr/bin/python3.3
*** Error compiling '/home/churchyard/rpmbuild/BUILDROOT/python-meh-0.32-2.fc22.x86_64/usr/lib/python3.3/site-packages/meh/ui/gui.py'...
File "/usr/lib/python3.3/site-packages/meh/ui/gui.py", line 34
raise RuntimeError, "Unable to find glade file %s" % file
SyntaxError: invalid syntax
I'll look into this as well.
(In reply to Miro Hrončok from comment #11)
> Created attachment 964135 [details]
> Patch for upstream git to allow python3 subpackages
> Patch attached for spec and Makefile in the upstream repo (i.e. not fedpkg).
> It should work, but apparently, there is still something not Python3
> Bytecompiling .py files below
> python3.3 using /usr/bin/python3.3
> *** Error compiling
> File "/usr/lib/python3.3/site-packages/meh/ui/gui.py", line 34
> raise RuntimeError, "Unable to find glade file %s" % file
> SyntaxError: invalid syntax
> I'll look into this as well.
FYI  will prolly help.
Created attachment 964137 [details]
Patch for Python 3 subpackages
Upstream patch for Python 3 subpackages.
Matej Stuchlik:(In reply to Matej Stuchlik from comment #12)
> FYI  will prolly help.
I knew, I was just afraid more errors will follow. But it seems this was the only one.
I would built a Fedora package, but it seems silly to patch Makefile and gui.py in the Fedora spec. So please merge this and let me know if the resulting packages are weird/broken.
Thanks for the patch! I've applied it and identified some more Python3-related issues that needed fixing. Patches with them are now ready for a review on the anaconda-patches list. Once reviewed, they will all be pushed and built as python-meh-0.34-1 that will have the python3 subpackage(s).
I'm closing this with resolution "rawhide", since it seems there is nothing more to do here.