Bug 985410 - Removes VM which fails to remove snapshot with RAM will stay in the system
Summary: Removes VM which fails to remove snapshot with RAM will stay in the system
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 3.3.0
Hardware: Unspecified
OS: Unspecified
medium
high
Target Milestone: ---
: 3.3.0
Assignee: Arik
QA Contact: Tareq Alayan
URL:
Whiteboard: virt
Depends On:
Blocks: 1019461
TreeView+ depends on / blocked
 
Reported: 2013-07-17 12:36 UTC by Ohad Basan
Modified: 2015-09-22 13:09 UTC (History)
8 users (show)

Fixed In Version: is8
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
oVirt Team: ---
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 17308 0 None None None Never

Description Ohad Basan 2013-07-17 12:36:06 UTC 
Description of problem:

I am using an engine with three vms
only one of them has a nic
I am trying to add a nic to another vm and getitng a message Mac address already in use
The engine should, in case a new mac is added, pick another mac from the range defined in engine-config
Comment 2 Ohad Basan 2013-07-17 15:45:13 UTC 
This bug was caused by a zombie vm with one nic. 
when tried to remove that vm > it did not remove it (because the vm was damaged because of another bug) but it did add the mac of the nic back to the pool.
Therefore the problem relates to the remove vm command which is not atomic
Comment 3 Mike Kolesnik 2013-07-18 14:14:47 UTC 
Please look at line 6399 at the attached engine.log and see that the remove which is supposed to remove only from the DB calls VDSM verb which fails, causing the remove from DB to rollback, and keep the VM with NICs and everything in the system although it is supposed to be deleted.

The method involved is:
org.ovirt.engine.core.bll.VmCommand.removeVmSnapshots()

I propose that the VDSM code be run outside a transaction scope.
Comment 4 Arik 2013-07-29 06:33:03 UTC 
http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=commit;h=f71f2ba071d70e07198650cecc19e8e65a129994
Comment 5 Tareq Alayan 2013-08-07 07:02:49 UTC 
verified on is8.
Comment 6 Itamar Heim 2014-01-21 22:26:20 UTC 
Closing - RHEV 3.3 Released
Comment 7 Itamar Heim 2014-01-21 22:29:45 UTC 
Closing - RHEV 3.3 Released
Note You need to log in before you can comment on or make changes to this bug.