Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.
Bug 985419 - p11-kit: realloc behavior
p11-kit: realloc behavior
Status: CLOSED ERRATA
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: p11-kit (Show other bugs)
7.1
Unspecified Windows
low Severity low
: rc
: 7.1
Assigned To: Daiki Ueno
Hubert Kario
:
Depends On:
Blocks: 983512
  Show dependency treegraph
 
Reported: 2013-07-17 08:59 EDT by Florian Weimer
Modified: 2017-08-01 12:52 EDT (History)
3 users (show)

See Also:
Fixed In Version: p11-kit-0.20.4-1.el7
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2017-08-01 12:52:09 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
common: Don't do repeated linear reallocation of array memory (899 bytes, patch)
2014-08-07 02:40 EDT, Stef Walter
no flags Details | Diff


External Trackers
Tracker ID Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2017:1981 normal SHIPPED_LIVE p11-kit bug fix update 2017-08-01 13:58:17 EDT

  None (edit)
Description Florian Weimer 2013-07-17 08:59:09 EDT
Some mallocs (notably on Windows) have really poor behavior when called repeatedly with a linearly growing buffer.

This appears to affect p11-kit/pin.c:p11_kit_pin_file_callback() and common/array.c:maybe_expand_array().  An exponential growth policy would prevent that.
Comment 2 Stef Walter 2013-07-17 14:36:44 EDT
Thanks. Will work on this later in p11-kit git master, rather than the stable branch.
Comment 5 Stef Walter 2014-08-07 02:40:11 EDT
Created attachment 924720 [details]
common: Don't do repeated linear reallocation of array memory

Some mallocs (notably on Windows) have really poor behavior when
called repeatedly with a linearly growing buffer.
Comment 6 Stef Walter 2014-08-07 02:41:30 EDT
Didn't fix the case in p11_kit_pin_file_callback() as it only has a couple possible iterations, and very unlikely to realloc() in any case.
Comment 10 Stef Walter 2014-10-13 12:16:08 EDT
This fix was not included in the stable 0.20.x series of p11-kit. It is in the 0.22.x series. Removing from RHEL 7.1.
Comment 12 Mike McCune 2016-03-28 19:37:25 EDT
This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune@redhat.com with any questions
Comment 16 errata-xmlrpc 2017-08-01 12:52:09 EDT
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1981

Note You need to log in before you can comment on or make changes to this bug.