RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 985419 - p11-kit: realloc behavior
Summary: p11-kit: realloc behavior
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: p11-kit
Version: 7.1
Hardware: Unspecified
OS: Windows
low
low
Target Milestone: rc
: 7.1
Assignee: Daiki Ueno
QA Contact: Hubert Kario
URL:
Whiteboard:
Depends On:
Blocks: 983512
TreeView+ depends on / blocked
 
Reported: 2013-07-17 12:59 UTC by Florian Weimer
Modified: 2017-08-01 16:52 UTC (History)
3 users (show)

Fixed In Version: p11-kit-0.20.4-1.el7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-08-01 16:52:09 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
common: Don't do repeated linear reallocation of array memory (899 bytes, patch)
2014-08-07 06:40 UTC, Stef Walter
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2017:1981 0 normal SHIPPED_LIVE p11-kit bug fix update 2017-08-01 17:58:17 UTC

Description Florian Weimer 2013-07-17 12:59:09 UTC
Some mallocs (notably on Windows) have really poor behavior when called repeatedly with a linearly growing buffer.

This appears to affect p11-kit/pin.c:p11_kit_pin_file_callback() and common/array.c:maybe_expand_array().  An exponential growth policy would prevent that.

Comment 2 Stef Walter 2013-07-17 18:36:44 UTC
Thanks. Will work on this later in p11-kit git master, rather than the stable branch.

Comment 5 Stef Walter 2014-08-07 06:40:11 UTC
Created attachment 924720 [details]
common: Don't do repeated linear reallocation of array memory

Some mallocs (notably on Windows) have really poor behavior when
called repeatedly with a linearly growing buffer.

Comment 6 Stef Walter 2014-08-07 06:41:30 UTC
Didn't fix the case in p11_kit_pin_file_callback() as it only has a couple possible iterations, and very unlikely to realloc() in any case.

Comment 10 Stef Walter 2014-10-13 16:16:08 UTC
This fix was not included in the stable 0.20.x series of p11-kit. It is in the 0.22.x series. Removing from RHEL 7.1.

Comment 12 Mike McCune 2016-03-28 23:37:25 UTC
This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions

Comment 16 errata-xmlrpc 2017-08-01 16:52:09 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1981


Note You need to log in before you can comment on or make changes to this bug.