Red Hat Bugzilla – Bug 985782
Some flag values of method are missing in libvirt-python bindings
Last modified: 2016-04-26 11:15:13 EDT
Description of problem: The VIR_NETWORK_UPDATE_COMMAND_ADD_LAST= 3 is missing in update function of virNetwork class in libvirt-python bindings. Version-Release number of selected component (if applicable): libvirt-python-0.10.2-20.el6.x86_64 How reproducible: 100% Steps to Reproduce: 1. # rpm -q libvirt-python libvirt-python-0.10.2-20.el6.x86_64 2. # vim /usr/lib64/python2.6/site-packages/libvirt.py 4469 # virNetworkUpdateCommand 4470 VIR_NETWORK_UPDATE_COMMAND_NONE = 0 4471 VIR_NETWORK_UPDATE_COMMAND_MODIFY = 1 4472 VIR_NETWORK_UPDATE_COMMAND_DELETE = 2 4473 VIR_NETWORK_UPDATE_COMMAND_ADD_FIRST = 4 3. http://libvirt.org/html/libvirt-libvirt.html#virNetworkUpdateCommand virNetworkUpdateCommand enum virNetworkUpdateCommand { VIR_NETWORK_UPDATE_COMMAND_NONE = 0 (invalid) VIR_NETWORK_UPDATE_COMMAND_MODIFY = 1 modify an existing element VIR_NETWORK_UPDATE_COMMAND_DELETE = 2 delete an existing element VIR_NETWORK_UPDATE_COMMAND_ADD_LAST = 3 add an element at end of list VIR_NETWORK_UPDATE_COMMAND_ADD_FIRST = 4 add an element at start of list VIR_NETWORK_UPDATE_COMMAND_LAST = 5 } Actual results: The VIR_NETWORK_UPDATE_COMMAND_ADD_LAST= 3 is missing in update function of virNetwork class in libvirt-python bindings. Expected results: It exists in libvirt-python binding Additional info:
The VIR_DOMAIN_REBOOT_INITCTL =4 and VIR_DOMAIN_REBOOT_SIGNAL = 8 are missing in the reboot method of virDomain class in libvirt-python bindings. 1. # vim /usr/lib64/python2.6/site-packages/libvirt.py 5155 # virDomainRebootFlagValues 5156 VIR_DOMAIN_REBOOT_DEFAULT = 0 5157 VIR_DOMAIN_REBOOT_ACPI_POWER_BTN = 1 5158 VIR_DOMAIN_REBOOT_GUEST_AGENT = 2 2. http://libvirt.org/html/libvirt-libvirt.html#virDomainRebootFlagValues virDomainRebootFlagValues enum virDomainRebootFlagValues { VIR_DOMAIN_REBOOT_DEFAULT = 0 hypervisor choice VIR_DOMAIN_REBOOT_ACPI_POWER_BTN = 1 Send ACPI event VIR_DOMAIN_REBOOT_GUEST_AGENT = 2 Use guest agent VIR_DOMAIN_REBOOT_INITCTL = 4 Use initctl VIR_DOMAIN_REBOOT_SIGNAL = 8 Send a signal }
(In reply to hongming from comment #2) This is totally irrelevant. Upstream added these flags after 1.0.0 was released so of course it is missing from 0.10.2. You cannot refer to upstream (the webpage you are referring to). I'm still investigating about the ADD_LAST now.
With VIR_NETWORK_UPDATE_COMMAND_ADD_LAST the problem is that it ends with "_LAST" which we effectively filter out as a sentinel.
Fixed upstream by commit v1.2.1-6-g014d9bb: commit 014d9bbaf368b33a881f1d6b2fd8a5dd285a4f71 Author: Martin Kletzander <mkletzan@redhat.com> Date: Thu Feb 20 16:35:02 2014 +0100 generator: Skip exporting only sentinels
This bug was not selected to be addressed in Red Hat Enterprise Linux 6. We will look at it again within the Red Hat Enterprise Linux 7 product.
Verify it as follows.The result is expected. Move its status to VERIFIED. # rpm -q libvirt libvirt-python libvirt-1.2.8-8.el7.x86_64 libvirt-python-1.2.8-5.el7.x86_64 # python -c "import libvirt; print libvirt.VIR_NETWORK_UPDATE_COMMAND_ADD_LAST" 3 # python -c "import libvirt; print libvirt.VIR_DOMAIN_REBOOT_INITCTL" 4 # python -c "import libvirt; print libvirt.VIR_DOMAIN_REBOOT_SIGNAL" 8
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHSA-2015-0323.html