Spec URL: http://gil.fedorapeople.org/mybatis-generator.spec SRPM URL: http://gil.fedorapeople.org/mybatis-generator-1.3.2-1.fc19.src.rpm Description: MyBatis Generator (MBG) is a code generator for MyBatis and iBATIS. Fedora Account System Username: gil Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=5627261
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Fully versioned dependency in subpackages, if present. Note: Missing: Requires: %{name} = %{version}-%{release} in mybatis- generator-maven-plugin, mybatis-generator-systests-common, mybatis- generator-systests-mybatis3 See: http://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [-]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mybatis- generator-maven-plugin , mybatis-generator-systests-common , mybatis- generator-systests-mybatis3 , mybatis-generator-javadoc [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 61 files have unknown license. Detailed output of licensecheck in /home/slaanesh/Documents/fedora/985854-mybatis-generator/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 102400 bytes in 11 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Java: [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) [x]: Bundled jar/class files should be removed before build Maven: [x]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Pom files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [!]: Packager, Vendor, PreReq, Copyright tags should not be in spec file Note: Found : Packager: Simone Caronni <negativo17> [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: mybatis-generator-1.3.2-1.fc20.noarch.rpm mybatis-generator-maven-plugin-1.3.2-1.fc20.noarch.rpm mybatis-generator-systests-common-1.3.2-1.fc20.noarch.rpm mybatis-generator-systests-mybatis3-1.3.2-1.fc20.noarch.rpm mybatis-generator-javadoc-1.3.2-1.fc20.noarch.rpm mybatis-generator.noarch: W: spelling-error Summary(en_US) iBATIS -> Batista, batiste mybatis-generator.noarch: W: spelling-error %description -l en_US iBATIS -> Batista, batiste mybatis-generator.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mybatis-generator-1.3.2/NOTICE mybatis-generator.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mybatis-generator-1.3.2/releasing.txt mybatis-generator.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mybatis-generator-1.3.2/todo.txt mybatis-generator.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mybatis-generator-1.3.2/ReleaseNotes.txt mybatis-generator.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mybatis-generator-1.3.2/LICENSE mybatis-generator-maven-plugin.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mybatis-generator-maven-plugin-1.3.2/NOTICE mybatis-generator-maven-plugin.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mybatis-generator-maven-plugin-1.3.2/LICENSE mybatis-generator-systests-common.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mybatis-generator-systests-common-1.3.2/NOTICE mybatis-generator-systests-common.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mybatis-generator-systests-common-1.3.2/LICENSE mybatis-generator-systests-mybatis3.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mybatis-generator-systests-mybatis3-1.3.2/NOTICE mybatis-generator-systests-mybatis3.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mybatis-generator-systests-mybatis3-1.3.2/LICENSE mybatis-generator-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mybatis-generator-javadoc-1.3.2/NOTICE mybatis-generator-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mybatis-generator-javadoc-1.3.2/LICENSE 5 packages and 0 specfiles checked; 0 errors, 15 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint mybatis-generator-systests-common mybatis-generator-javadoc mybatis-generator-maven-plugin mybatis-generator mybatis-generator-systests-mybatis3 mybatis-generator-systests-common.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mybatis-generator-systests-common-1.3.2/NOTICE mybatis-generator-systests-common.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mybatis-generator-systests-common-1.3.2/LICENSE mybatis-generator-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mybatis-generator-javadoc-1.3.2/NOTICE mybatis-generator-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mybatis-generator-javadoc-1.3.2/LICENSE mybatis-generator-maven-plugin.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mybatis-generator-maven-plugin-1.3.2/NOTICE mybatis-generator-maven-plugin.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mybatis-generator-maven-plugin-1.3.2/LICENSE mybatis-generator.noarch: W: spelling-error Summary(en_US) iBATIS -> Batista, batiste mybatis-generator.noarch: W: spelling-error %description -l en_US iBATIS -> Batista, batiste mybatis-generator.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mybatis-generator-1.3.2/NOTICE mybatis-generator.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mybatis-generator-1.3.2/releasing.txt mybatis-generator.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mybatis-generator-1.3.2/todo.txt mybatis-generator.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mybatis-generator-1.3.2/ReleaseNotes.txt mybatis-generator.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mybatis-generator-1.3.2/LICENSE mybatis-generator-systests-mybatis3.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mybatis-generator-systests-mybatis3-1.3.2/NOTICE mybatis-generator-systests-mybatis3.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mybatis-generator-systests-mybatis3-1.3.2/LICENSE 5 packages and 0 specfiles checked; 0 errors, 15 warnings. # echo 'rpmlint-done:' Requires -------- mybatis-generator-systests-common (rpmlib, GLIBC filtered): java jpackage-utils mybatis-generator-javadoc (rpmlib, GLIBC filtered): jpackage-utils mybatis-generator-maven-plugin (rpmlib, GLIBC filtered): java jpackage-utils mvn(org.apache.maven:maven-plugin-api) mvn(org.apache.maven:maven-project) mvn(org.mybatis.generator:mybatis-generator-core) mybatis-generator (rpmlib, GLIBC filtered): java jpackage-utils mybatis-generator-systests-mybatis3 (rpmlib, GLIBC filtered): java jpackage-utils mvn(org.mybatis.generator:mybatis-generator-systests-common) mvn(org.mybatis:mybatis) Provides -------- mybatis-generator-systests-common: mvn(org.mybatis.generator:mybatis-generator-systests-common) mybatis-generator-systests-common osgi(org.mybatis.generator.mybatis-generator-systests-common) mybatis-generator-javadoc: mybatis-generator-javadoc mybatis-generator-maven-plugin: mvn(org.mybatis.generator:mybatis-generator-maven-plugin) mybatis-generator-maven-plugin osgi(org.mybatis.generator.mybatis-generator-maven-plugin) mybatis-generator: mvn(org.mybatis.generator:mybatis-generator) mvn(org.mybatis.generator:mybatis-generator-core) mybatis-generator osgi(org.mybatis.generator.mybatis-generator-core) mybatis-generator-systests-mybatis3: mvn(org.mybatis.generator:mybatis-generator-systests-mybatis3) mybatis-generator-systests-mybatis3 osgi(org.mybatis.generator.mybatis-generator-systests-mybatis3) Source checksums ---------------- https://github.com/mybatis/generator/archive/mybatis-generator-1.3.2.tar.gz : CHECKSUM(SHA256) this package : 6dcd74f261699c8dee2b7fe1dbb7501538a29c41e014887b3b136c93bfec74ef CHECKSUM(SHA256) upstream package : 6dcd74f261699c8dee2b7fe1dbb7501538a29c41e014887b3b136c93bfec74ef Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 985854
(In reply to Simone Caronni from comment #1) > Issues: > ======= > - Fully versioned dependency in subpackages, if present. > Note: Missing: Requires: %{name} = %{version}-%{release} in mybatis- > generator-maven-plugin, mybatis-generator-systests-common, mybatis- > generator-systests-mybatis3 This can be ignored, dependencies are generated from maven build tools. > ===== SHOULD items ===== > [!]: Packager, Vendor, PreReq, Copyright tags should not be in spec file > Note: Found : Packager: Simone Caronni <negativo17> This is me, just my local .rpmmacros spec file. > Rpmlint > ------- > mybatis-generator.noarch: W: spelling-error Summary(en_US) iBATIS -> > Batista, batiste > mybatis-generator.noarch: W: spelling-error %description -l en_US iBATIS -> > Batista, batiste > mybatis-generator.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/mybatis-generator-1.3.2/NOTICE > mybatis-generator.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/mybatis-generator-1.3.2/releasing.txt > mybatis-generator.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/mybatis-generator-1.3.2/todo.txt > mybatis-generator.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/mybatis-generator-1.3.2/ReleaseNotes.txt > mybatis-generator.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/mybatis-generator-1.3.2/LICENSE > mybatis-generator-maven-plugin.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/mybatis-generator-maven-plugin-1.3.2/NOTICE > mybatis-generator-maven-plugin.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/mybatis-generator-maven-plugin-1.3.2/LICENSE > mybatis-generator-systests-common.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/mybatis-generator-systests-common-1.3.2/NOTICE > mybatis-generator-systests-common.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/mybatis-generator-systests-common-1.3.2/LICENSE > mybatis-generator-systests-mybatis3.noarch: W: > wrong-file-end-of-line-encoding > /usr/share/doc/mybatis-generator-systests-mybatis3-1.3.2/NOTICE > mybatis-generator-systests-mybatis3.noarch: W: > wrong-file-end-of-line-encoding > /usr/share/doc/mybatis-generator-systests-mybatis3-1.3.2/LICENSE > mybatis-generator-javadoc.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/mybatis-generator-javadoc-1.3.2/NOTICE > mybatis-generator-javadoc.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/mybatis-generator-javadoc-1.3.2/LICENSE > 5 packages and 0 specfiles checked; 0 errors, 15 warnings. These can be ignored. > Rpmlint (installed packages) > ---------------------------- > # rpmlint mybatis-generator-systests-common mybatis-generator-javadoc > mybatis-generator-maven-plugin mybatis-generator > mybatis-generator-systests-mybatis3 > mybatis-generator-systests-common.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/mybatis-generator-systests-common-1.3.2/NOTICE > mybatis-generator-systests-common.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/mybatis-generator-systests-common-1.3.2/LICENSE > mybatis-generator-javadoc.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/mybatis-generator-javadoc-1.3.2/NOTICE > mybatis-generator-javadoc.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/mybatis-generator-javadoc-1.3.2/LICENSE > mybatis-generator-maven-plugin.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/mybatis-generator-maven-plugin-1.3.2/NOTICE > mybatis-generator-maven-plugin.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/mybatis-generator-maven-plugin-1.3.2/LICENSE > mybatis-generator.noarch: W: spelling-error Summary(en_US) iBATIS -> > Batista, batiste > mybatis-generator.noarch: W: spelling-error %description -l en_US iBATIS -> > Batista, batiste > mybatis-generator.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/mybatis-generator-1.3.2/NOTICE > mybatis-generator.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/mybatis-generator-1.3.2/releasing.txt > mybatis-generator.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/mybatis-generator-1.3.2/todo.txt > mybatis-generator.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/mybatis-generator-1.3.2/ReleaseNotes.txt > mybatis-generator.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/mybatis-generator-1.3.2/LICENSE > mybatis-generator-systests-mybatis3.noarch: W: > wrong-file-end-of-line-encoding > /usr/share/doc/mybatis-generator-systests-mybatis3-1.3.2/NOTICE > mybatis-generator-systests-mybatis3.noarch: W: > wrong-file-end-of-line-encoding > /usr/share/doc/mybatis-generator-systests-mybatis3-1.3.2/LICENSE > 5 packages and 0 specfiles checked; 0 errors, 15 warnings. > # echo 'rpmlint-done:' Same errors, can be ignored.
Can you explain line 21-23 of the spec file? Is mvn(org.hsqldb:hsqldb) a requirement for mybatis-generator-maven-plugin? If it is, then it should be added into the "%package maven-plugin" section as "Requires:". Apart from this, it seems good to go.
Another thing, can BuildRequires from line 27 to 31 be specified in the form mvn(xxxì:xxx)?
(In reply to Simone Caronni from comment #3) > Can you explain line 21-23 of the spec file? Is mvn(org.hsqldb:hsqldb) a > requirement for mybatis-generator-maven-plugin? > > If it is, then it should be added into the "%package maven-plugin" section > as "Requires:". > > Apart from this, it seems good to go. for this module the plugin is configured so, and uses the dependencies listed in <dependencies>...</dependencies> i dont know if for other projects can be the same mybatis-generator-systests-mybatis3/pom.xml <plugin> <groupId>org.mybatis.generator</groupId> <artifactId>mybatis-generator-maven-plugin</artifactId> <version>${project.version}</version> <executions> <execution> <id>Generate MyBatis Artifacts</id> <goals> <goal>generate</goal> </goals> </execution> </executions> <configuration> <sqlScript>classpath:mbg/test/common/scripts/CreateDB.sql</sqlScript> <jdbcDriver>org.hsqldb.jdbcDriver</jdbcDriver> <jdbcURL>jdbc:hsqldb:mem:aname</jdbcURL> <jdbcUserId>sa</jdbcUserId> <overwrite>true</overwrite> </configuration> <dependencies> <dependency> <groupId>org.hsqldb</groupId> <artifactId>hsqldb</artifactId> <version>${hsqldb.version}</version> </dependency> <dependency> <groupId>org.mybatis.generator</groupId> <artifactId>mybatis-generator-systests-common</artifactId> <version>${project.version}</version> </dependency> <dependency> <groupId>org.mybatis.generator</groupId> <artifactId>mybatis-generator-core</artifactId> <version>${project.version}</version> </dependency> <dependency> <groupId>net.sourceforge.cobertura</groupId> <artifactId>cobertura</artifactId> <version>${cobertura.version}</version> </dependency> </dependencies> </plugin> Spec URL: http://gil.fedorapeople.org/mybatis-generator.spec SRPM URL: http://gil.fedorapeople.org/mybatis-generator-1.3.2-1.fc19.src.rpm - fix wrong file end of line encoding
(In reply to Simone Caronni from comment #4) > Another thing, can BuildRequires from line 27 to 31 be specified in the form > mvn(xxxì:xxx)? isn't really essential, i think, e.g. maven-local i don't know if it has references as mvn(xxxì:xxx) regards
Very good, thanks! Package approved.
New Package SCM Request ======================= Package Name: mybatis-generator Short Description: A code generator for MyBatis and iBATIS Owners: gil slaanesh InitialCC: java-sig
Git done (by process-git-requests).