Bug 986374 - Review Request: python-neutronclient - rename of python-quantumclient
Summary: Review Request: python-neutronclient - rename of python-quantumclient
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Christopher Meng
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-07-19 15:20 UTC by Jakub Ruzicka
Modified: 2013-07-23 17:12 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-07-23 17:12:38 UTC
Type: ---
Embargoed:
i: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Jakub Ruzicka 2013-07-19 15:20:27 UTC
Spec URL: http://jruzicka.fedorapeople.org/python-neutronclient/python-neutronclient.spec
SRPM URL: http://jruzicka.fedorapeople.org/python-neutronclient/python-neutronclient-2.2.4-1.fc19.src.rpm
Description: Client library and command line utility for interacting with Openstack Neutron's API.
Fedora Account System Username: jruzicka

python-neutronclient is a rename of python-quantumclient so this spec file is based on cleaned up python-quantumclient.spec.

Comment 1 Christopher Meng 2013-07-20 00:36:01 UTC
APPROVED.

Comment 2 Pádraig Brady 2013-07-22 10:31:52 UTC
Provides: and Obsoletes: look correct.

I.E. provides is not present as there is no command/module compatibility provision in the new package.

Comment 3 Jakub Ruzicka 2013-07-22 12:20:58 UTC
New Package SCM Request
=======================
Package Name: python-neutronclient
Short Description: Python API and CLI for OpenStack Neutron
Owners: jruzikca
Branches: f20 el6
InitialCC: pbrady

Comment 4 Michael Schwendt 2013-07-22 12:36:29 UTC
Obsoletes ought to be versioned, following the guidelines.
  http://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages
Unversioned Obsoletes are hard to get rid of, if one ever wanted to return a python-neutronclient package with a higher version.

Comment 5 Jakub Ruzicka 2013-07-22 14:05:04 UTC
rpmlint was suggesting versioned Obosletes as well but I see no reason why it should be since this is a rename so there won't ever be python-quantumclient package with higher version. Even if it was, it would still be obsoleted by python-neutronclient.

Comment 6 Michael Schwendt 2013-07-22 14:42:02 UTC
Well, you are free to not follow the guidelines and run your own show, but that isn't exactly a good attitude. The guidelines are a result of RPM Packaging related experience that has been gained over several years. If you find something questionable, there's the https://lists.fedoraproject.org/mailman/listinfo/packaging list to discuss it.

  Obsoletes: python-quantumclient < 2.2.1-4

would make it possible/easier to reintroduce a package with that name and a version-release >= 2.2.1-4. On the contrary,

  Obsoletes: python-quantumclient

blocks that name completely, because it doesn't specify a maximum version. It would be necessary to get rid of the non-versioned Obsoletes in installed packages and metadata before a python-quantumclient package could be reintroduced.

Comment 7 Pádraig Brady 2013-07-22 21:48:59 UTC
This is a fair point.
Even though OpenStack will never have this name for legal reasons,
theoretically that package name could be used in future for something completely different.

We'll ensure that an appropriate EVR is used in the Obsoletes for the built package. Jakub please choose a version that won't be updated beyond on any branch.

Jakub I'm setting the fedora-cvs: ? flag to initiate the SCM request.

thanks,
Pádraig.

Comment 8 Gwyn Ciesla 2013-07-23 12:02:42 UTC
"jruzikca" is not a valid FAS account, f20==devel and should not be
specifically requested.  Please correct.

Comment 9 Jakub Ruzicka 2013-07-23 14:03:12 UTC
New Package SCM Request
=======================
Package Name: python-neutronclient
Short Description: Python API and CLI for OpenStack Neutron
Owners: jruzicka pbrady
Branches: el6
InitialCC: pbrady

Comment 10 Gwyn Ciesla 2013-07-23 14:49:33 UTC
Git done (by process-git-requests).

Comment 11 Jakub Ruzicka 2013-07-23 17:12:38 UTC
Obsoletes is versioned as requested.


Note You need to log in before you can comment on or make changes to this bug.