Bug 987313 - [RFE] Hide "Lab Info" tab by default
[RFE] Hide "Lab Info" tab by default
Status: CLOSED CURRENTRELEASE
Product: Beaker
Classification: Community
Component: web UI (Show other bugs)
0.14
Unspecified Unspecified
unspecified Severity unspecified (vote)
: 0.15
: ---
Assigned To: Dan Callaghan
tools-bugs
: FutureFeature
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-23 04:36 EDT by Nick Coghlan
Modified: 2013-10-02 22:27 EDT (History)
8 users (show)

See Also:
Fixed In Version:
Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2013-10-02 22:27:40 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Nick Coghlan 2013-07-23 04:36:44 EDT
The current rudimentary asset management features Beaker provides are well outside Beaker's scope, and shouldn't be used in new Beaker installations.

The relevant parts of the web UI should be hidden by default, and require an explicit "enable_legacy_asset_management" setting in the server config for them to be displayed.
Comment 2 Dan Callaghan 2013-09-08 20:54:54 EDT
Is the "Lab Info" tab the only thing that needs hiding here?
Comment 3 Nick Coghlan 2013-09-08 21:54:54 EDT
I'm not aware of anything else, so that would be the place to start.
Comment 4 Dan Callaghan 2013-09-18 01:21:47 EDT
On Gerrit: http://gerrit.beaker-project.org/2275
Comment 5 Dan Callaghan 2013-09-18 02:07:10 EDT
The current approach is to always hide the Lab Info tab unless there is existing data for it. That has the advantage of not needing a config option to be fiddled with, while also preventing any system owners from adding new lab info data to their system.
Comment 6 Amit Saha 2013-09-18 02:08:09 EDT
(In reply to Dan Callaghan from comment #5)
> The current approach is to always hide the Lab Info tab unless there is
> existing data for it. That has the advantage of not needing a config option
> to be fiddled with, while also preventing any system owners from adding new
> lab info data to their system.

I took a brief look and it seems that there is option for CSV import of Lab info data.
Comment 7 Dan Callaghan 2013-09-18 02:08:48 EDT
Steps to verify:
1. For a new system which has no existing lab info, go to the system page: Lab Info tab is not present.
2. For an old system which has existing lab info, go to the system page: Lab Info tab is present, shows existing data, and allows it to be modified as before.
Comment 8 Nick Coghlan 2013-09-18 02:45:06 EDT
Limiting this to just hiding the tab when systems have no lab info data.

The CSV import is still enabled, so if anyone *really* wants to use it, they can start by uploading the initial data that way, and then the tab will become visible.

The overall feature is still on a path towards deprecation and removal though :)
Comment 11 xjia 2013-09-18 08:10:16 EDT
wrongly click needinfo, sorry.
Comment 12 Nick Coghlan 2013-10-02 22:27:40 EDT
Beaker 0.15 has been released.

Note You need to log in before you can comment on or make changes to this bug.