Red Hat Bugzilla – Bug 987335
[supervdsm] supervdsm crashes when parsing misformed ip rule
Last modified: 2016-02-10 14:48:40 EST
Created attachment 777263 [details]
Description of problem:
supervdsm cannot handle with wrong ip rule, it crashes. We think that
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. have a block pool with 2 hosts and 2 data domains on different storage servers
2. run a vm on each host
3. block connectivity from HSM host to the non-master storage domain with iptables
4. maintenance SPM, wait for the other host to take SPM
5. retrieve connectivity between SPM to non-master SD
supervdsm crashes because a misformed ip rule:
MainThread::ERROR::2013-07-22 15:04:07,942::supervdsmServer::403::SuperVdsm.Server::(main) Could not start Super Vdsm
Traceback (most recent call last):
File "/usr/share/vdsm/supervdsmServer.py", line 391, in main
File "/usr/share/vdsm/sourceRouteThread.py", line 60, in subscribeToInotifyLoop
SOURCE_ROUTES_FOLDER + '/' + filePath)
File "/usr/share/vdsm/sourceRouteThread.py", line 36, in process_IN_CLOSE_WRITE_filePath
File "/usr/share/vdsm/sourceRoute.py", line 171, in remove
rules = self._getRules(self.device)
File "/usr/share/vdsm/sourceRoute.py", line 150, in _getRules
allRules = [Rule.fromText(entry) for entry in ruleList()]
File "/usr/lib64/python2.6/site-packages/vdsm/ipwrapper.py", line 147, in fromText
raise ValueError('The length of a textual representation of a '
ValueError: The length of a textual representation of a rule must be odd
supervdsm should continue to run
Please do not refer to 'We think that' in the description.
I added a patch to VDSM that properly logs these types of errors.
I installed VDSM from master on the two hosts you gave me Elad. When you reproduce the error please upload the new logs here.
Assaf, I'm convinced. It is interesting which rule has caused this bug, but we should not die on finding a manually-concocted routing rule.
verified on IS8, supervdsm survives reproducer from BZ
This bug is currently attached to errata RHBA-2013:15291. If this change is not to be documented in the text for this errata please either remove it from the errata, set the requires_doc_text flag to
minus (-), or leave a "Doc Text" value of "--no tech note required" if you do not have permission to alter the flag.
Otherwise to aid in the development of relevant and accurate release documentation, please fill out the "Doc Text" field above with these four (4) pieces of information:
* Cause: What actions or circumstances cause this bug to present.
* Consequence: What happens when the bug presents.
* Fix: What was done to fix the bug.
* Result: What now happens when the actions or circumstances above occur. (NB: this is not the same as 'the bug doesn't present anymore')
Once filled out, please set the "Doc Type" field to the appropriate value for the type of change made and submit your edits to the bug.
For further details on the Cause, Consequence, Fix, Result format please refer to:
Thanks in advance.
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.