Bug 987525
| Summary: | Can't update the bond name | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Virtualization Manager | Reporter: | GenadiC <gcheresh> | ||||||||
| Component: | vdsm | Assignee: | Antoni Segura Puimedon <asegurap> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | GenadiC <gcheresh> | ||||||||
| Severity: | high | Docs Contact: | |||||||||
| Priority: | high | ||||||||||
| Version: | 3.3.0 | CC: | acathrow, asegurap, bazulay, danken, gcheresh, iheim, lpeer, yeylon | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | 3.3.0 | ||||||||||
| Hardware: | x86_64 | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | network | ||||||||||
| Fixed In Version: | is12 | Doc Type: | Bug Fix | ||||||||
| Doc Text: |
Previously VDSM bonding handled adding, editing and removing bonds in a non-deterministic order. Consequently, the bond to be created with the new name could be processed before the one with the old name was destroyed. The bond slaves would not have been freed yet and the new name bond would fail to be created. Now, VDSM first process all bonds to delete, then all the bonds to edit, and finally all the bonds to add. As a result, bond names can be modified and slaves can be taken from bonds to be removed in the same setupNetworks command.
|
Story Points: | --- | ||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2014-01-21 16:29:36 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | Network | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
Created attachment 777357 [details]
engine log
Genadi, the juicy stuff is tucked in supervdsm.log these days. Could you find and attach the relevant snippet? I suppose we can do without supervdsm.log for this specific bug, but in general, it is important to look inside it.
Thread-325::DEBUG::2013-07-23 17:39:56,568::BindingXMLRPC::979::vds::(wrapper) client [10.35.161.40]::call setupNetworks with ({}, {'bond01234': {'nics': ['eth3', 'eth2'], 'options': 'mode=4'}, 'bond10': {'remove': 'true'}}, {'connectivityCheck': 'true', 'connectivityTimeout': 120}) {}
Thread-326::DEBUG::2013-07-23 17:39:56,570::BindingXMLRPC::979::vds::(wrapper) client [10.35.161.40]::call ping with () {}
Thread-326::DEBUG::2013-07-23 17:39:56,571::BindingXMLRPC::986::vds::(wrapper) return ping with {'status': {'message': 'Done', 'code': 0}}
Thread-325::ERROR::2013-07-23 17:39:56,631::API::1261::vds::(setupNetworks) nic eth3 already used by bond10
Traceback (most recent call last):
File "/usr/share/vdsm/API.py", line 1259, in setupNetworks
supervdsm.getProxy().setupNetworks(networks, bondings, options)
File "/usr/share/vdsm/supervdsm.py", line 49, in __call__
return callMethod()
File "/usr/share/vdsm/supervdsm.py", line 48, in <lambda>
**kwargs)
File "<string>", line 2, in setupNetworks
File "/usr/lib64/python2.6/multiprocessing/managers.py", line 740, in _callmethod
raise convert_to_error(kind, result)
ConfigNetworkError: (24, 'nic eth3 already used by bond10')
Thread-325::DEBUG::2013-07-23 17:39:56,636::BindingXMLRPC::986::vds::(wrapper) return setupNetworks with {'status': {'message': 'nic eth3 already used by bond10', 'code': 24}}
Created attachment 777588 [details]
supervdsm log
Toni, it's great that you re-took this bug upon yourself, but you should have set its state to POST while at it. Now that it's in master branch, it can be declared MODIFIED. Please move it to ON_QA once there's a build containing it. The field for update is greyed out, so it's impossible to update the bond name This bug is currently attached to errata RHBA-2013:15291. If this change is not to be documented in the text for this errata please either remove it from the errata, set the requires_doc_text flag to minus (-), or leave a "Doc Text" value of "--no tech note required" if you do not have permission to alter the flag. Otherwise to aid in the development of relevant and accurate release documentation, please fill out the "Doc Text" field above with these four (4) pieces of information: * Cause: What actions or circumstances cause this bug to present. * Consequence: What happens when the bug presents. * Fix: What was done to fix the bug. * Result: What now happens when the actions or circumstances above occur. (NB: this is not the same as 'the bug doesn't present anymore') Once filled out, please set the "Doc Type" field to the appropriate value for the type of change made and submit your edits to the bug. For further details on the Cause, Consequence, Fix, Result format please refer to: https://bugzilla.redhat.com/page.cgi?id=fields.html#cf_release_notes Thanks in advance. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2014-0040.html |
Created attachment 777356 [details] vdsm log Description of problem: Fail on update name of existing bond with "eth-x is already in use by bond"message How reproducible: Steps to Reproduce: 1. Create bond with name 'bond01234567' 2. Try to update the bond name to something different 3. Actual results: The setupNetworks action fails on this operation Expected results: SetupNetwork should succeed Additional info: