Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.
Bug 987745 - fail to do hotplug with qemu i/o throttling including iops,iops_wr,iops_rd,bps,bps_wr,bps_rd inofs [NEEDINFO]
fail to do hotplug with qemu i/o throttling including iops,iops_wr,iops_rd,bp...
Status: CLOSED ERRATA
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: qemu-kvm (Show other bugs)
6.5
Unspecified Unspecified
medium Severity medium
: rc
: ---
Assigned To: Fam Zheng
Virtualization Bugs
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-24 00:39 EDT by Sibiao Luo
Modified: 2013-11-21 19:39 EST (History)
12 users (show)

See Also:
Fixed In Version: qemu-kvm-0.12.1.2-2.389.el6
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2013-11-21 19:39:23 EST
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
cboyle: needinfo?


Attachments (Terms of Use)


External Trackers
Tracker ID Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2013:1754 normal SHIPPED_LIVE Important: qemu-kvm-rhev, qemu-kvm-rhev-tools, qemu-img-rhev security and bug fix update 2013-11-21 05:48:24 EST

  None (edit)
Description Sibiao Luo 2013-07-24 00:39:01 EDT
Description of problem:
As subject.

Version-Release number of selected component (if applicable):
host info:
2.6.32-400.el6.x86_64
qemu-kvm-rhev-0.12.1.2-2.379.el6.x86_64
seabios-0.6.1.2-28.el6.x86_64
guest info:
2.6.32-400.el6.x86_64

How reproducible:
100%

Steps to Reproduce:
1.boot guest with QMP server.
# /usr/libexec/qemu-kvm -S -M rhel6.5.0 -cpu SandyBridge -enable-kvm -m 4096 -smp 4,sockets=2,cores=2,threads=1 -no-kvm-pit-reinjection -name sluo -uuid 43425b70-86e5-4664-bf2c-3b76699b8bec -rtc base=localtime,clock=host,driftfix=slew -device virtio-serial-pci,id=virtio-serial0,max_ports=16,vectors=0,bus=pci.0,addr=0x3 -chardev socket,id=channel1,path=/tmp/helloworld1,server,nowait -device virtserialport,chardev=channel1,name=com.redhat.rhevm.vdsm.1,bus=virtio-serial0.0,id=port1,nr=1 -chardev socket,id=channel2,path=/tmp/helloworld2,server,nowait -device virtserialport,chardev=channel2,name=com.redhat.rhevm.vdsm.2,bus=virtio-serial0.0,id=port2,nr=2 -drive file=/home/RHEL6.5-20130721.n.0_6.5_Server_x86_64.qcow2,if=none,id=drive-system-disk,format=qcow2,cache=none,aio=native,werror=stop,rerror=stop,serial="QEMU-DISK1" -device virtio-blk-pci,scsi=off,bus=pci.0,addr=0x4,drive=drive-system-disk,id=system-disk,bootindex=1 -device virtio-balloon-pci,id=ballooning,bus=pci.0,addr=0x5 -global PIIX4_PM.disable_s3=0 -global PIIX4_PM.disable_s4=0 -netdev tap,id=hostnet0,vhost=off,script=/etc/qemu-ifup -device virtio-net-pci,netdev=hostnet0,id=virtio-net-pci0,mac=2C:41:38:B6:40:21,bus=pci.0,addr=0x6,bootindex=2 -k en-us -boot menu=on -qmp tcp:0:4444,server,nowait -serial unix:/tmp/ttyS0,server,nowait -vnc :1 -spice port=5931,disable-ticketing -monitor stdio
2.do hotplug data disk with iops,iops_wr,iops_rd,bps,bps_wr,bps_rd inofs.
(qemu) ? __com.redhat_drive_add
__com.redhat_drive_add id=name,[file=file][,format=f][,media=d]... -- Create a drive similar to -device if=none.
(qemu) __com.redhat_drive_add file=/home/my-data-disk.qcow2,id=drive-data-disk,format=qcow2,cache=none,aio=native,werror=stop,rerror=stop,serial="QEMU-DISK2",bps=1000000,iops=10000
Invalid parameter 'iops'
(qemu) __com.redhat_drive_add file=/home/my-data-disk.qcow2,id=drive-data-disk,format=qcow2,bps=1000000,iops=10000
Invalid parameter 'iops'
(qemu) __com.redhat_drive_add file=/home/my-data-disk.qcow2,id=drive-data-disk,format=qcow2,bps=1000000
Invalid parameter 'bps'

{"execute":"qmp_capabilities"}
{"return": {}}
{"execute":"__com.redhat_drive_add","arguments":{"file":"/home/my-data-disk.qcow2","format":"qcow2","id":"drive-data-disk","bps":"1000000", "iops":"10000" }} 
{"error": {"class": "InvalidParameter", "desc": "Invalid parameter 'iops'", "data": {"name": "iops"}}}

Actual results:
after step 2, it fail to do hotplug.

Expected results:
It can do hotplug with qemu i/o throttling including iops,iops_wr,iops_rd,bps,bps_wr,bps_rd inofs successfully.

Additional info:
# /usr/libexec/qemu-kvm --help
...
-drive [file=file][,if=type][,bus=n][,unit=m][,media=d][,index=i]
       [,cyls=c,heads=h,secs=s[,trans=t]][,snapshot=on|off]
       [,cache=writethrough|writeback|none|unsafe][,format=f]
       [,serial=s][,addr=A][,id=name][,aio=threads|native]
       [,readonly=on|off][,copy-on-read=on|off]
       [[,bps=b]|[[,bps_rd=r][,bps_wr=w]]][[,iops=i]|[[,iops_rd=r][,iops_wr=w]]
                use 'file' as a drive image
Comment 3 Sibiao Luo 2013-08-27 01:27:14 EDT
Verify this issue on qemu-kvm-rhev-0.12.1.2-2.398.el6.x86_64.

host info:
# uname -r && rpm -q qemu-kvm-rhev
2.6.32-413.el6.x86_64
qemu-kvm-rhev-0.12.1.2-2.398.el6.x86_64

# /usr/libexec/qemu-kvm --help
-drive [file=file][,if=type][,bus=n][,unit=m][,media=d][,index=i]
       [,cyls=c,heads=h,secs=s[,trans=t]][,snapshot=on|off]
       [,cache=writethrough|writeback|none|unsafe][,format=f]
       [,serial=s][,addr=A][,id=name][,aio=threads|native]
       [,readonly=on|off][,copy-on-read=on|off]
       [[,bps=b]|[[,bps_rd=r][,bps_wr=w]]][[,iops=i]|[[,iops_rd=r][,iops_wr=w]]
                use 'file' as a drive image

(qemu) __com.redhat_drive_add file=/home/data-disk.qcow2,id=drive-data-disk,format=qcow2,cache=none,aio=native,serial="QEMU-DISK2",bps=1000000,iops=1000
(qemu) device_add virtio-blk-pci,scsi=off,bus=pci.0,drive=drive-data-disk,id=data-disk
(qemu) info block
drive-system-disk: removable=0 io-status=ok file=/home/RHEL6.5-20130814.n.0-6.5-Server.qcow2 ro=0 drv=qcow2 encrypted=0 bps=0 bps_rd=0 bps_wr=0 iops=0 iops_rd=0 iops_wr=0
ide1-cd0: removable=1 locked=0 tray-open=0 io-status=ok [not inserted]
floppy0: removable=1 locked=0 tray-open=0 [not inserted]
sd0: removable=1 locked=0 tray-open=0 [not inserted]
drive-data-disk: removable=0 io-status=ok file=/home/data-disk.qcow2 ro=0 drv=qcow2 encrypted=0 bps=1000000 bps_rd=0 bps_wr=0 iops=1000 iops_rd=0 iops_wr=0
(qemu) 

{"execute":"__com.redhat_drive_add","arguments":{"file":"/home/data-disk.qcow2","format":"qcow2","id":"drive-data-disk","bps":"1000000","iops":"10000" }} 
{"return": {}}
{"execute": "device_add", "arguments": {"driver": "virtio-blk-pci", "scsi": "off", "bus": "pci.0", "drive": "drive-data-disk", "id": "data-disk" }}
{"return": {}}
{"execute":"query-block"}
{"return": [...{"io-status": "ok", "device": "drive-data-disk", "locked": false, "removable": false, "inserted": {"iops_rd": 0, "iops_wr": 0, "ro": false, "drv": "qcow2", "iops": 10000, "bps_wr": 0, "encrypted": false, "bps": 1000000, "bps_rd": 0, "file": "/home/data-disk.qcow2"}, "type": "unknown"}]}

Base on above, this issue has been fixed correctly, set it to verified status.

Best Regards,
sluo
Comment 5 Charlie 2013-11-12 20:21:32 EST
Does this text seem right for a description of this? 


* When booting a guest with QMP server, hotplug was failing. It can now do
hotplug with QEMU i/o throttling including
iops,iops_wr,iops_rd,bps,bps_wr,bps_rd inofs successfully.

would "can now complete hotplugging" be better (terminology) also, is there an explanation of why this was failing? 

Thanks in advance
Comment 7 errata-xmlrpc 2013-11-21 19:39:23 EST
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2013-1754.html

Note You need to log in before you can comment on or make changes to this bug.