Bug 987832 - failed to add ovirtmgmt bridge when the host has static ip
Summary: failed to add ovirtmgmt bridge when the host has static ip
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: oVirt
Classification: Retired
Component: vdsm
Version: unspecified
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ---
: 3.4.0
Assignee: Antoni Segura Puimedon
QA Contact: Martin Pavlik
URL:
Whiteboard: network
Depends On:
Blocks: 1024889
TreeView+ depends on / blocked
 
Reported: 2013-07-24 09:14 UTC by Sandro Bonazzola
Modified: 2014-04-01 04:53 UTC (History)
13 users (show)

Fixed In Version: ovirt-3.4.0-beta1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-03-31 12:32:00 UTC
oVirt Team: ---


Attachments (Terms of Use)
ifcfg-em1 before adding the host (326 bytes, text/plain)
2013-07-24 09:15 UTC, Sandro Bonazzola
no flags Details
ifcfg-em1 after adding the host (97 bytes, text/plain)
2013-07-24 09:16 UTC, Sandro Bonazzola
no flags Details
ifcfg-ovirtmgmt created after adding the host (72 bytes, text/plain)
2013-07-24 09:16 UTC, Sandro Bonazzola
no flags Details


Links
System ID Priority Status Summary Last Updated
oVirt gerrit 23329 None None None Never

Description Sandro Bonazzola 2013-07-24 09:14:31 UTC
Description of problem:
adding a newly installed host configured with static IP fails to configure management network on the host.

Version-Release number of selected component (if applicable):
Fedora 19, ovirt-engine 3.3 nightly - git0c5620a, adding to 3.3 cluster

host deploy exits with success.

I'll attach ifcfg* to the bug.

Comment 1 Sandro Bonazzola 2013-07-24 09:15:14 UTC
Created attachment 777681 [details]
ifcfg-em1 before adding the host

Comment 2 Sandro Bonazzola 2013-07-24 09:16:02 UTC
Created attachment 777682 [details]
ifcfg-em1 after adding the host

Comment 3 Sandro Bonazzola 2013-07-24 09:16:54 UTC
Created attachment 777683 [details]
ifcfg-ovirtmgmt created after adding the host

Comment 4 Dan Kenigsberg 2013-07-31 15:09:59 UTC
from the original ifcfg-em1:
======================
IPADDR0=192.168.1.107
PREFIX0=24
GATEWAY0=192.168.1.1

Are these trailing 0s conventional? Is it a new anaconda behavior?

I suspect that vdsm does not parse them, and not expose them properly to Engine. Vdsm should better treat them as their zero-less form (just as initscripts does?)

Comment 5 Sandro Bonazzola 2013-08-01 06:10:09 UTC
(In reply to Dan Kenigsberg from comment #4)

> Are these trailing 0s conventional? Is it a new anaconda behavior?

Not sure if the trailing 0s are from anaconda or from gnome network configuration app. However they come from system configuration tools so we can expect to find them quite often.

Comment 7 Dan Kenigsberg 2013-09-21 15:44:34 UTC
In a (late) second thought, I think that it would be much nicer to solve this on the Engine side. Engine should avoid relying on the 'cfg' parameter of network devices, as 'cfg' utterly breaks the Vdsm abstraction and does not fit into where Vdsm wants to go (non-ifcfg netconf).

IPADDR and GATEWAY should be take from the network's 'addr' and 'gateway' attributes. If I am not mistaken at the moment, the only need for 'cfg' is BOOTPROTO and BONDING_OPTS. Can we make everything else go?

Comment 8 Moti Asayag 2013-09-22 08:05:08 UTC
(In reply to Dan Kenigsberg from comment #7)
> In a (late) second thought, I think that it would be much nicer to solve
> this on the Engine side. Engine should avoid relying on the 'cfg' parameter
> of network devices, as 'cfg' utterly breaks the Vdsm abstraction and does
> not fit into where Vdsm wants to go (non-ifcfg netconf).
> 
> IPADDR and GATEWAY should be take from the network's 'addr' and 'gateway'
> attributes. If I am not mistaken at the moment, the only need for 'cfg' is
> BOOTPROTO and BONDING_OPTS. Can we make everything else go?

When you're adding a new host, there are no records on it for in the 'networks' element. Therefore we should rely on some other attribute which could provide the engine the ip address and the gateway of the specific interface.

Perhaps we'd like to extend the api of the last_client_iface to provide these values so they won't be tied to a specific implementation.

Comment 9 Dan Kenigsberg 2013-09-22 08:55:35 UTC
Oh. 'addr' is already reported per device, however 'gateway' is only a network property. Vdsm would have to report 'gateway' and 'bootproto' per device in order for Engine to drop the 'cfg' dependency.

Comment 11 Sven Kieske 2014-01-13 07:59:58 UTC
Does this also affect EL 6 based Hosts?
Does this just affect the minimal node iso or also the "full blown host" install?

Comment 12 Dan Kenigsberg 2014-01-16 13:59:06 UTC
http://gerrit.ovirt.org/23329/ does not add a new 'gateway' attribute. It only translates GATEWAY0 to GATEWAY, and keeps the ifcfg dependency.

Comment 13 Sandro Bonazzola 2014-01-27 13:45:13 UTC
This should be fixed in 3.4.0 beta1

Comment 14 Martin Pavlik 2014-02-17 14:14:47 UTC
verified
 oVirt Engine Version: 3.4.0-0.7.beta2.el6

Comment 15 Sandro Bonazzola 2014-03-31 12:32:00 UTC
this is an automated message: moving to Closed CURRENT RELEASE since oVirt 3.4.0 has been released


Note You need to log in before you can comment on or make changes to this bug.