Bug 988087 - [ExternalTasks] When adding new step, state is always STARTED
Summary: [ExternalTasks] When adding new step, state is always STARTED
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: oVirt
Classification: Retired
Component: ovirt-engine-core
Version: 3.3
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: ---
Assignee: Eli Mesika
QA Contact:
URL:
Whiteboard: infra
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-07-24 17:31 UTC by Vojtech Szocs
Modified: 2013-09-23 07:27 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-09-23 07:27:20 UTC
oVirt Team: ---
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 17469 0 None None None Never
oVirt gerrit 18389 0 None None None Never

Description Vojtech Szocs 2013-07-24 17:31:44 UTC
Assume JOB_ID is ID of existing job.

POST /api/jobs/JOB_ID/steps/
<step>
  <description>Test Step</description>
  <type>EXECUTING</type>
  <status>
    <state>FINISHED</state>
  </status>
</step>

POST response = step created with state STARTED
<step href="/api/jobs/JOB_ID/steps/NEW_STEP_ID" id="NEW_STEP_ID">
    <actions>
        <link href="/api/jobs/JOB_ID/steps/NEW_STEP_ID/end" rel="end"/>
    </actions>
    <description>Test Step</description>
    <job href="/api/jobs/JOB_ID" id="JOB_ID"/>
    <type>executing</type>
    <number>0</number>
    <status>
        <state>STARTED</state>
    </status>
    <start_time>2013-07-24T16:59:37.061+02:00</start_time>
    <external>true</external>
</step>

New step always put into STARTED state actually makes sense.

But if I omit <status> from POST request, I'll get following fault: Step [status.state] required for add

This makes <status> required in POST request but it doesn't seem to have any effect.

Comment 1 Eli Mesika 2013-08-12 20:55:23 UTC
fixed in commit: d47a623

Comment 2 Itamar Heim 2013-08-21 16:40:04 UTC
as RC is built, moving to ON_QA (hopefully did not catch incorrect bugs when doing this)

Comment 3 Itamar Heim 2013-09-23 07:27:20 UTC
closing as this should be in 3.3 (doing so in bulk, so may be incorrect)


Note You need to log in before you can comment on or make changes to this bug.